[kudu-CR] auto rebalancer: ignore deleted tables
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Reviewed-on: http://gerrit.cloudera.org:8080/15970 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 104 insertions(+), 15 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] auto rebalancer: ignore deleted tables
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15970 )
Change subject: auto_rebalancer: ignore deleted tables
..
Patch Set 6: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@685
PS4, Line 685: GetTableLocationsResponsePB table_locs;
: ASSERT_OK(GetTableLocations(cluster_->master_proxy(),
kNewTableName,
: MonoDelta::FromSeconds(10),
ReplicaTypeFilter::ANY_REPLICA,
: /*table_id*/boost::none,
_locs));
: unordered_set deleted_tablet_ids;
: for (const auto& t : table_locs.tablet_locations()) {
: EmplaceIfNotPresent(_tablet_ids, t.tablet_id());
: }
: ASSERT_OK(workload_->client()->DeleteTable(kNewTableName));
:
: // Add a new tablet server and restart the stopped server so
the rebalancer
: // can proceed.
: ASS
> This wasn't testing that, but I can update it to check that.
Ah, great. Thank you for doing this!
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Hannah Nguyen
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 21 May 2020 05:28:34 +
Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15970 to look at the new patch set (#6). Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 104 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/6 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] auto rebalancer: ignore deleted tables
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15970 )
Change subject: auto_rebalancer: ignore deleted tables
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@647
PS4, Line 647: or (const auto& str : post_capture_l
> nit: it would be nice to add an extra sentence to explain what is the desir
Done
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@685
PS4, Line 685: ASSERT_OK(GetTableLocations(cluster_->master_proxy(),
kNewTableName,
: MonoDelta::FromSeconds(10),
ReplicaTypeFilter::ANY_REPLICA,
: /*table_id*/boost::none,
_locs));
: unordered_set deleted_tablet_ids;
: for (const auto& t : table_locs.tablet_locations()) {
: EmplaceIfNotPresent(_tablet_ids, t.tablet_id());
: }
: ASSERT_OK(workload_->client()->DeleteTable(kNewTableName));
:
: // Add a new tablet server and restart the stopped server so
the rebalancer
: // can proceed.
: ASSERT_OK(cluster_->AddTabletServer());
: ASS
> Does it give a guarantee that the replicas of the deleted table were not at
This wasn't testing that, but I can update it to check that.
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc
File src/kudu/master/auto_rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc@498
PS4, Line 498: const SysTablesEntryPB& table_data =
table->metadata().state().pb;
: if (table_data.state() == SysTablesEntryPB::REMOVED) {
: // Don't worry about rebalancing replicas that belong to
deleted tables.
: continue;
: }
: TableSummary table_summary;
: t
> nit: does it make sense to re-order the lines to avoid instantiating 'table
Done
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Hannah Nguyen
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 May 2020 03:17:11 +
Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15970 to look at the new patch set (#5). Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 103 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/5 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] auto rebalancer: ignore deleted tables
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15970 )
Change subject: auto_rebalancer: ignore deleted tables
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@647
PS4, Line 647: Test rebalancing with deleted tables
nit: it would be nice to add an extra sentence to explain what is the desired
behavior of the auto-rebalancer w.r.t. deleted tables, like do we simply want
to make sure it doesn't stall; doesn't attempt to move replicas of the deleted
tables, etc.?
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@685
PS4, Line 685: // Even though not all tables are running, this should succeed
because the
: // table that isn't running has been deleted.
: ASSERT_EVENTUALLY([&] {
: int bytes_sent_in_orig_tservers =
: AggregateMetricCounts(GetBytesSentByTServer(), 0,
kNumTServers);
: ASSERT_GT(bytes_sent_in_orig_tservers,
initial_bytes_sent_in_orig_tservers);
: });
: ASSERT_EVENTUALLY([&] {
: int bytes_fetched_in_new_tservers =
: AggregateMetricCounts(GetBytesFetchedByTServer(),
kNumTServers,
: cluster_->num_tablet_servers());
: ASSERT_GT(bytes_fetched_in_new_tservers, 0);
: });
Does it give a guarantee that the replicas of the deleted table were not
attempted to be moved? Or this test isn't trying to verify that?
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc
File src/kudu/master/auto_rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc@498
PS4, Line 498: TableSummary table_summary;
: table_summary.id = table->id();
: const SysTablesEntryPB& table_data =
table->metadata().state().pb;
: if (table_data.state() == SysTablesEntryPB::REMOVED) {
: // Don't worry about rebalancing replicas that belong to
deleted tables.
: continue;
: }
nit: does it make sense to re-order the lines to avoid instantiating
'table_summary' at all for the short-circuit case? Something like:
const SysTablesEntryPB& table_data = table->metadata().state().pb;
if (table_data.state() == SysTablesEntryPB::REMOVED) {
// Don't worry about rebalancing replicas that belong to deleted tables.
continue;
}
TableSummary table_summary;
table_summary.id = table->id();
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Hannah Nguyen
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 May 2020 02:24:46 +
Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15970 to look at the new patch set (#4). Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 69 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/4 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [master] cache for table locations
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15971 Change subject: WIP [master] cache for table locations .. WIP [master] cache for table locations This patch introduces a cache for table locations in catalog manager. With the cache enabled, the performance of the CatalogManager::GetTableLocations method improved about 1.7x times and a small improvement for GetTableLocations RPC according to GetTableLocationsBenchmarkFunctionCall scenario from the TableLocationsTest suite: with cache disabled: GetTableLocations function call: 157894.6 req/sec GetTableLocations RPC: 14749 req/sec with cache enabled: GetTableLocations function call: 268782.2 req/sec GetTableLocations RPC: 16911.4 req/sec WIP: * the only test failing is ClientTest.TestPartitione; need to clarify on the reason * parameterize a few tests to run it with and without table location cache Change-Id: I7d2a4771ddc455d92a1da00db91c555a21151a23 --- M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master_service.cc A src/kudu/master/table_locations_cache.cc A src/kudu/master/table_locations_cache.h A src/kudu/master/table_locations_cache_metrics.cc A src/kudu/master/table_locations_cache_metrics.h 8 files changed, 502 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/15971/1 -- To view, visit http://gerrit.cloudera.org:8080/15971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7d2a4771ddc455d92a1da00db91c555a21151a23 Gerrit-Change-Number: 15971 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] auto rebalancer: ignore deleted tables
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 May 2020 00:11:03 + Gerrit-HasComments: No
[kudu-CR] auto rebalancer: ignore deleted tables
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@659 PS2, Line 659: > SetupWorkload() also creates a table with a default name. I renamed the method so it's more obvious what it's doing. http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@679 PS2, Line 679: > nit: downed? Went with "stopped" -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 May 2020 00:02:59 + Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15970 to look at the new patch set (#3). Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 68 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/3 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] rebalancer: throttle logging when building cluster info
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15920 ) Change subject: rebalancer: throttle logging when building cluster info .. rebalancer: throttle logging when building cluster info I enabled the auto-rebalancer on a cluster with many single-replica tablets and was met with hundreds of messages like the following in very short bursts: I0514 16:24:53.469353 151489 rebalancer.cc:325] tablet 0bc9157245694b57a313d1e032093393 of table 'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c' (0d852b00af434a1980b83e63da3d984a) has single replica, skipping I0514 16:24:53.469357 151489 rebalancer.cc:325] tablet 1f9507a576dd4115b445faac37b9fcf3 of table 'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c' (0d852b00af434a1980b83e63da3d984a) has single replica, skipping I0514 16:24:53.469362 151489 rebalancer.cc:325] tablet 65c794016e3a4e8eb635a3764e3e33a7 of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping I0514 16:24:53.469367 151489 rebalancer.cc:325] tablet 20910b83145f4e7c83b6d8c6885e423b of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping I0514 16:24:53.469373 151489 rebalancer.cc:325] tablet 577024c5dea74edd8f286de9d5b73b41 of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping This converts such logs to use VLOG instead, and updates some others to throttle logging. Change-Id: I93007b50213244c14e47fc6e913415fad7698057 Reviewed-on: http://gerrit.cloudera.org:8080/15920 Reviewed-by: Bankim Bhavsar Tested-by: Kudu Jenkins --- M src/kudu/rebalance/rebalancer.cc M src/kudu/tools/rebalancer_tool-test.cc 2 files changed, 16 insertions(+), 11 deletions(-) Approvals: Bankim Bhavsar: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I93007b50213244c14e47fc6e913415fad7698057 Gerrit-Change-Number: 15920 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] auto rebalancer: ignore deleted tables
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@679 PS2, Line 679: down nit: downed? -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 23:25:35 + Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@659 PS2, Line 659: multiple tables > I took a quick look at the TestWorkload and judging by single set_table_nam SetupWorkload() also creates a table with a default name. -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 23:24:31 + Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@659 PS2, Line 659: multiple tables I took a quick look at the TestWorkload and judging by single set_table_name(), I see only only 1 table created in Setup(). What am I missing? -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 23:23:44 + Gerrit-HasComments: Yes
[kudu-CR] rebalancer: throttle logging when building cluster info
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15920 ) Change subject: rebalancer: throttle logging when building cluster info .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93007b50213244c14e47fc6e913415fad7698057 Gerrit-Change-Number: 15920 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 23:08:12 + Gerrit-HasComments: No
[kudu-CR] auto rebalancer: ignore deleted tables
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15970 to look at the new patch set (#2). Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/2 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] rebalancer: throttle logging when building cluster info
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15920 to look at the new patch set (#3). Change subject: rebalancer: throttle logging when building cluster info .. rebalancer: throttle logging when building cluster info I enabled the auto-rebalancer on a cluster with many single-replica tablets and was met with hundreds of messages like the following in very short bursts: I0514 16:24:53.469353 151489 rebalancer.cc:325] tablet 0bc9157245694b57a313d1e032093393 of table 'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c' (0d852b00af434a1980b83e63da3d984a) has single replica, skipping I0514 16:24:53.469357 151489 rebalancer.cc:325] tablet 1f9507a576dd4115b445faac37b9fcf3 of table 'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c' (0d852b00af434a1980b83e63da3d984a) has single replica, skipping I0514 16:24:53.469362 151489 rebalancer.cc:325] tablet 65c794016e3a4e8eb635a3764e3e33a7 of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping I0514 16:24:53.469367 151489 rebalancer.cc:325] tablet 20910b83145f4e7c83b6d8c6885e423b of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping I0514 16:24:53.469373 151489 rebalancer.cc:325] tablet 577024c5dea74edd8f286de9d5b73b41 of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping This converts such logs to use VLOG instead, and updates some others to throttle logging. Change-Id: I93007b50213244c14e47fc6e913415fad7698057 --- M src/kudu/rebalance/rebalancer.cc M src/kudu/tools/rebalancer_tool-test.cc 2 files changed, 16 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15920/3 -- To view, visit http://gerrit.cloudera.org:8080/15920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93007b50213244c14e47fc6e913415fad7698057 Gerrit-Change-Number: 15920 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] rebalancer: throttle logging when building cluster info
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15920 )
Change subject: rebalancer: throttle logging when building cluster info
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15920/1/src/kudu/rebalance/rebalancer.cc
File src/kudu/rebalance/rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/15920/1/src/kudu/rebalance/rebalancer.cc@313
PS1, Line 313: for (const auto& s : raw_info.tserver_summaries) {
: if (s.health != ServerHealth::HEALTHY) {
: skipped_tserver_msgs.emplace_back(
: Substitute("skipping tablet server $0 ($1) because of
its "
: "non-HEALTHY status ($2)",
> I guess it's OK to do so if we are not interested to get information on all
Hrm, good point. It's probably worth logging all of the unhealthy ones, we
don't expect this to be a very long list.
http://gerrit.cloudera.org:8080/#/c/15920/1/src/kudu/rebalance/rebalancer.cc@317
PS1, Line 317:
> Why no THROTTLE_MSG here like below?
Done
http://gerrit.cloudera.org:8080/#/c/15920/1/src/kudu/rebalance/rebalancer.cc@327
PS1, Line 327:
> Unless there is user intervention to increase number of replica tablets, th
Went with VLOG for this instead, since you're right that these messages will
not go away.
--
To view, visit http://gerrit.cloudera.org:8080/15920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93007b50213244c14e47fc6e913415fad7698057
Gerrit-Change-Number: 15920
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 May 2020 21:59:42 +
Gerrit-HasComments: Yes
[kudu-CR] auto rebalancer: ignore deleted tables
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15970 Change subject: auto_rebalancer: ignore deleted tables .. auto_rebalancer: ignore deleted tables The auto-rebalancer would previously not do any rebalancing if any of the tables in the cluster were deleted, since the tablets of these tables would not be RUNNING. This updates the auto-rebalancer to ignore such tables. Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/1 -- To view, visit http://gerrit.cloudera.org:8080/15970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691 Gerrit-Change-Number: 15970 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] rebalancer: throttle logging when building cluster info
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15920 to look at the new patch set (#2). Change subject: rebalancer: throttle logging when building cluster info .. rebalancer: throttle logging when building cluster info I enabled the auto-rebalancer on a cluster with many single-replica tablets and was met with hundreds of messages like the following in very short bursts: I0514 16:24:53.469353 151489 rebalancer.cc:325] tablet 0bc9157245694b57a313d1e032093393 of table 'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c' (0d852b00af434a1980b83e63da3d984a) has single replica, skipping I0514 16:24:53.469357 151489 rebalancer.cc:325] tablet 1f9507a576dd4115b445faac37b9fcf3 of table 'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c' (0d852b00af434a1980b83e63da3d984a) has single replica, skipping I0514 16:24:53.469362 151489 rebalancer.cc:325] tablet 65c794016e3a4e8eb635a3764e3e33a7 of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping I0514 16:24:53.469367 151489 rebalancer.cc:325] tablet 20910b83145f4e7c83b6d8c6885e423b of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping I0514 16:24:53.469373 151489 rebalancer.cc:325] tablet 577024c5dea74edd8f286de9d5b73b41 of table 'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9' (49599b5cee6f48308425dafd04519b02) has single replica, skipping This converts such logs to use VLOG instead, and updates some others to throttle logging. Change-Id: I93007b50213244c14e47fc6e913415fad7698057 --- M src/kudu/rebalance/rebalancer.cc 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15920/2 -- To view, visit http://gerrit.cloudera.org:8080/15920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93007b50213244c14e47fc6e913415fad7698057 Gerrit-Change-Number: 15920 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. [KUDU-3116] Enhance KuduContext row operation metrics Adds the ability to track operation counts per table. Introduces the MapAccumulator to track these metrics in a single accumulator per operation type. Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e Reviewed-on: http://gerrit.cloudera.org:8080/15882 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke Reviewed-by: Andrew Wong --- M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala A java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala 3 files changed, 157 insertions(+), 32 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e Gerrit-Change-Number: 15882 Gerrit-PatchSet: 9 Gerrit-Owner: Brian McDevitt Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Brian McDevitt Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 8: Code-Review+2 Sorry for the review delay. Thanks for the contribution! :) -- To view, visit http://gerrit.cloudera.org:8080/15882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e Gerrit-Change-Number: 15882 Gerrit-PatchSet: 8 Gerrit-Owner: Brian McDevitt Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Brian McDevitt Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 20:55:28 + Gerrit-HasComments: No
[kudu-CR] [docs] add a release step to update the previous release notes
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15969 Change subject: [docs] add a release step to update the previous release notes .. [docs] add a release step to update the previous release notes Change-Id: I5eb0f0443a16c92f5fe7810d46539312c7dc5be7 --- M RELEASING.adoc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/15969/1 -- To view, visit http://gerrit.cloudera.org:8080/15969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5eb0f0443a16c92f5fe7810d46539312c7dc5be7 Gerrit-Change-Number: 15969 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
[kudu-CR] release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15968 Change subject: release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1 .. release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1 Change-Id: Id747e39758180a9cf65749ff45c91c0d7b9dfd73 --- M docs/prior_release_notes.adoc 1 file changed, 334 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/15968/1 -- To view, visit http://gerrit.cloudera.org:8080/15968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id747e39758180a9cf65749ff45c91c0d7b9dfd73 Gerrit-Change-Number: 15968 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
[kudu-CR] ksck: remove --verbose from description
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15965 ) Change subject: ksck: remove --verbose from description .. ksck: remove --verbose from description The flag was removed a while ago as a part of a refactor. Change-Id: I9925b0e5a0c8716cb75e45e22501625bdb9c4e47 Reviewed-on: http://gerrit.cloudera.org:8080/15965 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M src/kudu/tools/tool_action_cluster.cc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9925b0e5a0c8716cb75e45e22501625bdb9c4e47 Gerrit-Change-Number: 15965 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. KUDU-2817: Upgrade glog to 0.4.0 We are currently on glog 0.3.5 which is from 2017. We also have 4 patches on top of that version in thirdparty. This patch upgrades us to glog 0.4.0 which was released in 2019 and removes 3/4 patches that are now included in the release. I needed to adjust the remaining patch to apply and fix some usage of the CHECK macros to wrap in parenthesis to prevent macro expansion issues as well. I also adjusted the build scripts to use cmake instead of autoconf so that I could disable building the tests. Change-Id: I652a852d040fcd3d974002382735610c8621c413 Reviewed-on: http://gerrit.cloudera.org:8080/15924 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/fs/dir_util-test.cc M src/kudu/util/logging.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 10 files changed, 43 insertions(+), 455 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413 Gerrit-Change-Number: 15924 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413 Gerrit-Change-Number: 15924 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 15:08:21 + Gerrit-HasComments: No
[kudu-CR] ksck: remove --verbose from description
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15965 ) Change subject: ksck: remove --verbose from description .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9925b0e5a0c8716cb75e45e22501625bdb9c4e47 Gerrit-Change-Number: 15965 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 May 2020 13:08:00 + Gerrit-HasComments: No
[kudu-CR] ksck: remove --verbose from description
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15965 Change subject: ksck: remove --verbose from description .. ksck: remove --verbose from description The flag was removed a while ago as a part of a refactor. Change-Id: I9925b0e5a0c8716cb75e45e22501625bdb9c4e47 --- M src/kudu/tools/tool_action_cluster.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/15965/1 -- To view, visit http://gerrit.cloudera.org:8080/15965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9925b0e5a0c8716cb75e45e22501625bdb9c4e47 Gerrit-Change-Number: 15965 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
