[kudu-CR] [tserver] validator for --scanner max wait ms
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16655 ) Change subject: [tserver] validator for --scanner_max_wait_ms .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16655/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16655/2/src/kudu/tserver/tablet_service.cc@204 PS2, Line 204: at least up to $2 nit: "to at least $2", otherwise this may read as though the user should increase by an additional heartbeat interval. http://gerrit.cloudera.org:8080/#/c/16655/2/src/kudu/tserver/tablet_service.cc@210 PS2, Line 210: return true; Is this to say that it's not actually that critical an issue? Will snapshot scans with the latest timestamp _mostly_ pass even if improperly set? My concern is that a warning is indeed not severe enough to spur action on the operator, though I do understand why a soft validation is desirable, assuming the service runs ok in a lot of cases even if improperly set. -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 Gerrit-Change-Number: 16655 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Oct 2020 06:29:27 + Gerrit-HasComments: Yes
[kudu-CR] [tserver] validator for --scanner max wait ms
Alexey Serbin has removed a vote on this change. Change subject: [tserver] validator for --scanner_max_wait_ms .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 Gerrit-Change-Number: 16655 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tserver] validator for --scanner max wait ms
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16655 ) Change subject: [tserver] validator for --scanner_max_wait_ms .. Patch Set 2: Verified+1 unrelated test failure in ToolTest.TestHmsList -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 Gerrit-Change-Number: 16655 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Oct 2020 06:20:47 + Gerrit-HasComments: No
[kudu-CR] [tserver] validator for --scanner max wait ms
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16655 to look at the new patch set (#2). Change subject: [tserver] validator for --scanner_max_wait_ms .. [tserver] validator for --scanner_max_wait_ms This patch adds a group validator for the --scanner_max_wait_ms vs --raft_heartbeat_interval_ms flag's value. As of now, the validator outputs warning if --scanner_max_wait_ms is set too low compared with --raft_heartbeat_interval_ms. In addition, --scanner_max_wait_ms is now tagged as 'runtime' to reflect its de facto behavior. I also did a minor clean-up of the related code. I didn't add any test, but I verified that the warning is output upon kudu-tserver's startup as intended when --scanner_max_wait_ms is set too low compared with current setting for --raft_heartbeat_interval_ms. Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 --- M src/kudu/consensus/time_manager.cc M src/kudu/tserver/tablet_service.cc 2 files changed, 64 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/16655/2 -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 Gerrit-Change-Number: 16655 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tserver] validator for --scanner max wait ms
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16655 Change subject: [tserver] validator for --scanner_max_wait_ms .. [tserver] validator for --scanner_max_wait_ms This patch adds a group validator for the --scanner_max_wait_ms vs --raft_heartbeat_interval_ms flag's value. As of now, the validator output warning if --scanner_max_wait_ms is set too low compared with --raft_heartbeat_interval_ms. In addition, --scanner_max_wait_ms is now tagged as 'runtime' to reflect its de facto behavior. I also did a minor clean in the code around. I didn't add any test, but I verified that the warning is output upon kudu-tserver's startup as intended when --scanner_max_wait_ms is set too low compared with current setting for --raft_heartbeat_interval_ms. Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 --- M src/kudu/consensus/time_manager.cc M src/kudu/tserver/tablet_service.cc 2 files changed, 64 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/16655/1 -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 Gerrit-Change-Number: 16655 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/16648 )
Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by
the leader only
..
Patch Set 1:
(6 comments)
Just a quick first pass.
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc@147
PS1, Line 147:
reload_txn_status_tablet_pool_(reload_txn_status_tablet_pool),
: txn_coordinator_(meta_->table_type() &&
:*meta_->table_type() ==
TableTypePB::TXN_STATUS_TABLE ?
:
DCHECK_NOTNULL(txn_coordinator_factory)->Create(this) : nullptr),
: mark_dirty_clbk_(meta_->table_type() &&
:*meta_->table_type() ==
TableTypePB::TXN_STATUS_TABLE ?
:[this](const string& reason) {
:
this->TxnStatusReplicaStateChanged(this->tablet_id(), reason);
:} : std::move(cb)),
Maybe, at this point it's time to separate TxnStatusTabletReplica info a
sub-class of TabletReplica, and instantiating one ore another in
TSTabletManager::CreateAndRegisterTabletReplica() based on meta_->table_type()?
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc@302
PS1, Line 302: CHECK_OK(leader_cb());
Just curious: is this going to be called if leadership status hasn't changed
for a replica, i.e. if the former leader wins latest election round again?
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.h
File src/kudu/transactions/txn_status_manager.h:
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.h@87
PS1, Line 87: class ScopedLeaderSharedLock {
Would it make sense to extract the common part of the code from
CatalogManager::ScopedLeaderSharedLock and this class into some common class
(maybe, using template class approach) and re-use the common code in catalog
manager and here?
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc
File src/kudu/transactions/txn_status_manager.cc:
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@83
PS1, Line 83: constrution
nit: construction
Also, add a stop in the end of the sentence.
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tserver/ts_tablet_manager.cc@386
PS1, Line 386: disks
nit: data directories ?
http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tserver/ts_tablet_manager.cc@389
PS1, Line 389: RETURN_NOT_OK(ThreadPoolBuilder("txn-status-tablet-reload")
: .set_max_threads(max_reload_threads)
: .Build(&reload_txn_status_tablet_pool_));
Is it necessary to gracefully shutdown this pool along with other tablet pools
uses in TsTabletManager or it's OK to rely on its destructor's logic as is?
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 26 Oct 2020 23:14:43 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: persist commit MVCC op timestamp in txn metadata
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16569 ) Change subject: KUDU-2612: persist commit MVCC op timestamp in txn metadata .. Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/metadata.proto File src/kudu/tablet/metadata.proto: http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/metadata.proto@100 PS2, Line 100: When iterating through mutations at the latest snapshot (as in : // READ_LATEST or during compactions), this MVCC op timestamp must be : // applied and there must be a commit timestamp for the mutation to be : // considered committed. Maybe nice to point out this is to avoid dirty reads? http://gerrit.cloudera.org:8080/#/c/16569/1/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/16569/1/src/kudu/tablet/tablet_metadata.cc@817 PS1, Line 817: if we are bootstrapping > This happens when we are bootstrapping and replay a BEGIN_COMMIT op, since Ack http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/txn_participant-test.cc@614 PS2, Line 614: // One anchor should be gone and another should be registered in its place : // that lasts until we flush the finalized metadata. : ASSERT_EQ(2, tablet_replica_->log_anchor_registry()->GetAnchorCountForTests()); The comment doesn't seem to match the checking? Why not 'ASSERT_EQ(1, ...)' -- To view, visit http://gerrit.cloudera.org:8080/16569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2400fbb7e96ddba78544a9549965fc095e32ca3 Gerrit-Change-Number: 16569 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 23:07:38 + Gerrit-HasComments: Yes
[kudu-CR] Remove redundant code in TabletReplica
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16647 ) Change subject: Remove redundant code in TabletReplica .. Remove redundant code in TabletReplica Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6 Reviewed-on: http://gerrit.cloudera.org:8080/16647 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong Reviewed-by: Grant Henke --- M src/kudu/tablet/tablet_replica.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6 Gerrit-Change-Number: 16647 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [catalog manager] fix the typo in the comment for 'leader lock '
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16646 ) Change subject: [catalog manager] fix the typo in the comment for 'leader_lock_' .. [catalog manager] fix the typo in the comment for 'leader_lock_' Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce Reviewed-on: http://gerrit.cloudera.org:8080/16646 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong Reviewed-by: Grant Henke --- M src/kudu/master/catalog_manager.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce Gerrit-Change-Number: 16646 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: fix build on macOS
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. tablet: fix build on macOS This fixes the following error: ../../src/kudu/tablet/compaction-test.cc:1061:33: error: cannot initialize a parameter of type 'uint64_t *' (aka 'unsigned long long *') with an rvalue of type 'size_t *' (aka 'unsigned long *') ASSERT_OK(rs->CountLiveRows(&rs_live_rows)); ^ Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Reviewed-on: http://gerrit.cloudera.org:8080/16650 Reviewed-by: Alexey Serbin Reviewed-by: Attila Bukor Tested-by: Attila Bukor --- M src/kudu/tablet/compaction-test.cc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Attila Bukor: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: fix build on macOS
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 19:45:49 + Gerrit-HasComments: No
[kudu-CR] tablet: fix build on macOS
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 19:42:01 + Gerrit-HasComments: No
[kudu-CR] tablet: fix build on macOS
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc@1058 PS1, Line 1058: uin > nit: does it make sense to update this to be uint64_t as well? Done -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 19:39:54 + Gerrit-HasComments: Yes
[kudu-CR] tablet: fix build on macOS
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16650 to look at the new patch set (#2). Change subject: tablet: fix build on macOS .. tablet: fix build on macOS This fixes the following error: ../../src/kudu/tablet/compaction-test.cc:1061:33: error: cannot initialize a parameter of type 'uint64_t *' (aka 'unsigned long long *') with an rvalue of type 'size_t *' (aka 'unsigned long *') ASSERT_OK(rs->CountLiveRows(&rs_live_rows)); ^ Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 --- M src/kudu/tablet/compaction-test.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/16650/2 -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: fix build on macOS
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc@1058 PS1, Line 1058: int nit: does it make sense to update this to be uint64_t as well? -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 19:37:52 + Gerrit-HasComments: Yes
[kudu-CR] tablet: fix build on macOS
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 1: Verified+1 verified manually on Mac. -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 19:37:24 + Gerrit-HasComments: No
[kudu-CR] tablet: fix build on macOS
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 19:32:28 + Gerrit-HasComments: No
[kudu-CR] tablet: fix build on macOS
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16650 Change subject: tablet: fix build on macOS .. tablet: fix build on macOS This fixes the following error: ../../src/kudu/tablet/compaction-test.cc:1061:33: error: cannot initialize a parameter of type 'uint64_t *' (aka 'unsigned long long *') with an rvalue of type 'size_t *' (aka 'unsigned long *') ASSERT_OK(rs->CountLiveRows(&rs_live_rows)); ^ Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 --- M src/kudu/tablet/compaction-test.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/16650/1 -- To view, visit http://gerrit.cloudera.org:8080/16650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0 Gerrit-Change-Number: 16650 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] Fix order of clearing and printing openssl error
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16631 ) Change subject: Fix order of clearing and printing openssl error .. Fix order of clearing and printing openssl error When verifying the certificate chain fails with an error other than self-signed certificate, we try to get the subject and issuer to print in the error message. Unfortunately X509NameToString(), the method doing the conversion, also checks that there are no leftover OpenSSL errors, so it fails immediately on call. This commit changes the behavior to clear the errors *before* calling X509NameToString(). I ran into this problem while debugging test failures on a host where the OpenSSL was provided by CryptoComply SafeLogic: F1020 12:06:13.327023 25579 openssl_util.h:210] Check failed: ERR_peek_error() == 0 (67567722 vs. 0) Expected no pending OpenSSL errors on std::string kudu::security::X509NameToString(X509_NAME*) entry, but had: error:0407006A:rsa routines:RSA_padding_check_PKCS1_type_1:block type is not 01:rsa_pk1.c:102 error:04067072:rsa routines:RSA_EAY_PUBLIC_DECRYPT:padding check failed:rsa_eay.c:786 error:0D0C5006:asn1 encoding routines:ASN1_item_verify:EVP lib:a_verify.c:218 Unfortunately, I couldn't reproduce it in other OpenSSL versions and distributions, so I can't add a regression test, at least for now. Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Reviewed-on: http://gerrit.cloudera.org:8080/16631 Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M src/kudu/security/tls_context.cc 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] Fix order of clearing and printing openssl error
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16631 ) Change subject: Fix order of clearing and printing openssl error .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 26 Oct 2020 13:35:42 + Gerrit-HasComments: No
[kudu-CR] [catalog manager] fix the typo in the comment for 'leader lock '
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16646 ) Change subject: [catalog manager] fix the typo in the comment for 'leader_lock_' .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce Gerrit-Change-Number: 16646 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 13:34:15 + Gerrit-HasComments: No
[kudu-CR] Remove redundant code in TabletReplica
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16647 ) Change subject: Remove redundant code in TabletReplica .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6 Gerrit-Change-Number: 16647 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Oct 2020 13:34:41 + Gerrit-HasComments: No
