[kudu-CR] KUDU-1926: disable TLS/SSL session renegotiation
Hello Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17204 to look at the new patch set (#2). Change subject: KUDU-1926: disable TLS/SSL session renegotiation .. KUDU-1926: disable TLS/SSL session renegotiation This patch disables TLS ciphers renegotiation for TLSv1.2 and prior. In case of OpenSSL version 1.1.0h and newer, we are using SSL_OP_NO_RENEGOTIATION option to all renegotiation. In case of OpenSSL version prior to 1.1.0a, the undocumented SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is used. See [1], [2] and [3] for more context. The moot point is the version interval between 1.1.0a and 1.1.0g: the SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is already gone, but SSL_OP_NO_RENEGOTIATION is not yet present. [1] https://www.openssl.org/docs/man1.1.0/man3/SSL_set_options.html [2] https://github.com/openssl/openssl/blob/f9398cc2b31858ddaaea3f5cfec2fce7f9b90347/CHANGES#L1038-L1049 [3] https://github.com/openssl/openssl/issues/4739 Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 --- M src/kudu/security/tls_context.cc 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/17204/2 -- To view, visit http://gerrit.cloudera.org:8080/17204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 Gerrit-Change-Number: 17204 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3142: Remove the deprecated kudu-mapreduce modules
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17202 ) Change subject: KUDU-3142: Remove the deprecated kudu-mapreduce modules .. Patch Set 1: Code-Review+2 I hope we don't have any ITBLL map-reduce-based test running as a Jenkins job? :) -- To view, visit http://gerrit.cloudera.org:8080/17202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d0b1ca71e436bd5ad03101e9d02e9116a1ed2fa Gerrit-Change-Number: 17202 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Mar 2021 05:04:15 + Gerrit-HasComments: No
[kudu-CR] [threadpool] fix race in ThreadPoolToken::Submit()
Alexey Serbin has removed a vote on this change. Change subject: [threadpool] fix race in ThreadPoolToken::Submit() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I2b17e4b2b634624fbc51e8ee05749a56f6609f62 Gerrit-Change-Number: 17205 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [threadpool] fix race in ThreadPoolToken::Submit()
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17205 ) Change subject: [threadpool] fix race in ThreadPoolToken::Submit() .. Patch Set 1: Verified+1 unrelated test failure in TabletHistoryGcITest.TestUndoDeltaBlockGc -- To view, visit http://gerrit.cloudera.org:8080/17205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b17e4b2b634624fbc51e8ee05749a56f6609f62 Gerrit-Change-Number: 17205 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Mar 2021 04:55:27 + Gerrit-HasComments: No
[kudu-CR] KUDU-1926: disable TLS/SSL session renegotiation
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17204 ) Change subject: KUDU-1926: disable TLS/SSL session renegotiation .. Patch Set 1: > Unrelated TSAN warning while running Params/ScanYourWritesParamTest.Test/1 I posted a separate patch to fix the race reported by TSAN: https://gerrit.cloudera.org/#/c/17205/ -- To view, visit http://gerrit.cloudera.org:8080/17204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 Gerrit-Change-Number: 17204 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Mar 2021 04:04:04 + Gerrit-HasComments: No
[kudu-CR] [threadpool] fix race in ThreadPoolToken::Submit()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17205 Change subject: [threadpool] fix race in ThreadPoolToken::Submit() .. [threadpool] fix race in ThreadPoolToken::Submit() This patch fixes a race between calling ThreadPoolToken::Submit() and destructing the token concurrently from another thread. The patch moves the update of the thread pool token's queue length metric under the lock used in the ThreadPool::DoSubmit() method. The motivation for this patch was seeing the following TSAN report while running Params/ScanYourWritesParamTest.Test/1: WARNING: ThreadSanitizer: data race (pid=18290) Write of size 8 at 0x7b2c0002b0e8 by main thread: #0 operator delete(void*) #1 std::__1::default_delete::operator()(kudu::ThreadPoolToken*) #2 std::__1::unique_ptr >::reset(kudu::ThreadPoolToken*) #3 std::__1::unique_ptr >::~unique_ptr() #4 kudu::consensus::RaftConsensus::~RaftConsensus() src/kudu/consensus/raft_consensus.cc:210:1 #5 ... #6 std::__1::__shared_count::__release_shared() #7 std::__1::__shared_weak_count::__release_shared() #8 std::__1::shared_ptr::~shared_ptr() #9 kudu::tablet::TabletReplica::~TabletReplica() src/kudu/tablet/tablet_replica.cc:195:1 . Previous read of size 8 at 0x7b2c0002b0e8 by thread T125: #0 scoped_refptr::operator kudu::Histogram* scoped_refptr::*() const #1 kudu::ThreadPool::DoSubmit(std::__1::function, kudu::ThreadPoolToken*) src/kudu/util/threadpool.cc:523:7 #2 kudu::ThreadPoolToken::Submit(std::__1::function) src/kudu/util/threadpool.cc:124:17 #3 kudu::consensus::Peer::SignalRequest(bool) src/kudu/consensus/consensus_peers.cc:188:28 #4 kudu::consensus::Peer::Init()::$_0::operator()() src/kudu/consensus/consensus_peers.cc:161:14 #5 ... #6 ... #7 ... #8 ... #9 ... #10 ... #11 kudu::rpc::PeriodicTimer::Callback(long) . Change-Id: I2b17e4b2b634624fbc51e8ee05749a56f6609f62 --- M src/kudu/util/threadpool.cc 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/17205/1 -- To view, visit http://gerrit.cloudera.org:8080/17205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2b17e4b2b634624fbc51e8ee05749a56f6609f62 Gerrit-Change-Number: 17205 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-1926: disable TLS/SSL session renegotiation
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17204 ) Change subject: KUDU-1926: disable TLS/SSL session renegotiation .. Patch Set 1: Verified+1 Unrelated TSAN warning while running Params/ScanYourWritesParamTest.Test/1 -- To view, visit http://gerrit.cloudera.org:8080/17204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 Gerrit-Change-Number: 17204 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Mar 2021 00:50:02 + Gerrit-HasComments: No
[kudu-CR] KUDU-1926: disable TLS/SSL session renegotiation
Alexey Serbin has removed a vote on this change. Change subject: KUDU-1926: disable TLS/SSL session renegotiation .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 Gerrit-Change-Number: 17204 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1926: disable TLS/SSL session renegotiation
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17204 Change subject: KUDU-1926: disable TLS/SSL session renegotiation .. KUDU-1926: disable TLS/SSL session renegotiation This patch disables TLS ciphers renegotiation for TLSv1.2 and prior. In case of OpenSSL version 1.1.0h and newer, we are using SSL_OP_NO_RENEGOTIATION option to all renegotiation. In case of OpenSSL version prior to 1.1.0a, the undocumented SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is used. See [1], [2] and [3] for more context. The moot point is the version interval between 1.1.0a and 1.1.0g: the SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is already gone, but SSL_OP_NO_RENEGOTIATION is not yet present. [1] https://www.openssl.org/docs/man1.1.0/man3/SSL_set_options.html [2] https://github.com/openssl/openssl/blob/f9398cc2b31858ddaaea3f5cfec2fce7f9b90347/CHANGES#L1038-L1049 [3] https://github.com/openssl/openssl/issues/4739 Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 --- M src/kudu/security/tls_context.cc 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/17204/1 -- To view, visit http://gerrit.cloudera.org:8080/17204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1 Gerrit-Change-Number: 17204 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-2612: add ScopedPartitionLock
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add ScopedPartitionLock .. Patch Set 13: Reverted back to using a semaphore, with a slight modifications. Sleeping in the prepare thread did not sit well with me. -- To view, visit http://gerrit.cloudera.org:8080/17097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I158115739ce3e7cfb77bbcb854e834336c1256b1 Gerrit-Change-Number: 17097 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Mar 2021 22:15:22 + Gerrit-HasComments: No
[kudu-CR] KUDU-2612: acquire and release partition lock
Andrew Wong has uploaded a new patch set (#5) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/17159 ) Change subject: KUDU-2612: acquire and release partition lock .. KUDU-2612: acquire and release partition lock This patch plumbs partition locks into participant and write ops for transactional and non-transactional operations. For each transaction, we try to acquire the partition lock in the ParticipantOp prepare phase of BEGIN_TXN and release the lock when COMMIT_TXN or ABORT_TXN is applied. Moreover, we take the partition lock for non-transactional write ops as well to ensure we don’t have duplicate keys. If the partition lock cannot be acquired, the transaction (or write op) is aborted or retried. A flag is also introduced to disable this locking for tests that currently expect support for concurrent transactions. Change-Id: If26733cae16810f3b3afd1fd05dcb984e6366939 --- M src/kudu/client/batcher.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/txn_commit-itest.cc M src/kudu/integration-tests/txn_participant-itest.cc M src/kudu/integration-tests/txn_write_ops-itest.cc M src/kudu/tablet/ops/participant_op.cc M src/kudu/tablet/ops/participant_op.h M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/txn_participant-test.cc M src/kudu/tablet/txn_participant.cc M src/kudu/tablet/txn_participant.h M src/kudu/transactions/participant_rpc.cc 16 files changed, 471 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/17159/5 -- To view, visit http://gerrit.cloudera.org:8080/17159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If26733cae16810f3b3afd1fd05dcb984e6366939 Gerrit-Change-Number: 17159 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612: add ScopedPartitionLock
Andrew Wong has uploaded a new patch set (#13) to the change originally created
by Hao Hao. ( http://gerrit.cloudera.org:8080/17097 )
Change subject: KUDU-2612: add ScopedPartitionLock
..
KUDU-2612: add ScopedPartitionLock
This patch introduces a coarse-grained partition-level lock
ScopedPartitionLock to prevent dirty writes for multi-row transactions,
similar to the ScopedRowLock, but for locking the entire LockManager
instead of individual rows.
A partition lock can only be held by a single transaction at a time. A
given transaction can acquire the lock multiple times. To prevent
deadlocks, a wait-die scheme is used -- if a transaction requires a lock
held by another transaction:
1. Retry the op if the requesting transaction has a lower txn ID than
the current holder ("wait"),
2. Otherwise abort the requesting transaction immediately ("die").
A later patch will plumb this locking into participant ops and
transactional write ops.
Change-Id: I158115739ce3e7cfb77bbcb854e834336c1256b1
---
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/lock_manager.h
M src/kudu/tserver/tserver.proto
4 files changed, 534 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/17097/13
--
To view, visit http://gerrit.cloudera.org:8080/17097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I158115739ce3e7cfb77bbcb854e834336c1256b1
Gerrit-Change-Number: 17097
Gerrit-PatchSet: 13
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17203 ) Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi .. [thirdparty] Remove unnecessary clang usage for libcxxabi This patch removes the explicit usage of clang when compiling libcxxabi which was done in 458e6ce to handle the lack of gcc5+ on all supported platforms. We now require gcc7+ as of e432e63. Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 Reviewed-on: http://gerrit.cloudera.org:8080/17203 Reviewed-by: Alexey Serbin Tested-by: Grant Henke --- M thirdparty/build-definitions.sh 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Grant Henke: Verified -- To view, visit http://gerrit.cloudera.org:8080/17203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 Gerrit-Change-Number: 17203 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17203 ) Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 Gerrit-Change-Number: 17203 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 19:23:36 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi
Grant Henke has removed a vote on this change. Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 Gerrit-Change-Number: 17203 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3142: Remove the deprecated kudu-mapreduce modules
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17202 ) Change subject: KUDU-3142: Remove the deprecated kudu-mapreduce modules .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d0b1ca71e436bd5ad03101e9d02e9116a1ed2fa Gerrit-Change-Number: 17202 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 18:01:18 + Gerrit-HasComments: No
[kudu-CR] KUDU-3142: Remove the deprecated kudu-mapreduce modules
Grant Henke has removed a vote on this change. Change subject: KUDU-3142: Remove the deprecated kudu-mapreduce modules .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I6d0b1ca71e436bd5ad03101e9d02e9116a1ed2fa Gerrit-Change-Number: 17202 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17203 ) Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17203/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17203/1//COMMIT_MSG@11 PS1, Line 11: We now require gcc7+ as of e432e63 Good point! -- To view, visit http://gerrit.cloudera.org:8080/17203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 Gerrit-Change-Number: 17203 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 17:49:51 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17203 Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi .. [thirdparty] Remove unnecessary clang usage for libcxxabi This patch removes the explicit usage of clang when compiling libcxxabi which was done in 458e6ce to handle the lack of gcc5+ on all supported platforms. We now require gcc7+ as of e432e63. Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 --- M thirdparty/build-definitions.sh 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/17203/1 -- To view, visit http://gerrit.cloudera.org:8080/17203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27 Gerrit-Change-Number: 17203 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] KUDU-3142: Remove the deprecated kudu-mapreduce modules
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17202 Change subject: KUDU-3142: Remove the deprecated kudu-mapreduce modules .. KUDU-3142: Remove the deprecated kudu-mapreduce modules The kudu-mapreduce integration has not been improved in a couple of years even though there are known outstanding issues and feature gaps. This patch removes the outdated kudu-mapreduce module and the related/supporting kudu-client-tools module. This removal helps reduce the public API surface area and removes code we are no longer improving/updating. Similar functionality and capabilities now exist via Spark, Hive, Impala, and NiFi integrations. Users that still need this functioanlity are welcome to use any published Kudu 1.14.0 and earlier Jar. Change-Id: I6d0b1ca71e436bd5ad03101e9d02e9116a1ed2fa --- M java/gradle/dependencies.gradle D java/kudu-client-tools/build.gradle D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java D java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java D java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java D java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java D java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java D java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java D java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java D java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java D java/kudu-client-tools/src/test/resources/log4j2.properties D java/kudu-mapreduce/build.gradle D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputCommitter.java D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java D java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/TableReducer.java D java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java D java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java D java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java D java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java D java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java D java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java D java/kudu-mapreduce/src/test/resources/log4j2.properties M java/kudu-spark-tools/build.gradle R java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/BigLinkedListCommon.java M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala M java/settings.gradle 39 files changed, 7 insertions(+), 6,023 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/17202/1 -- To view, visit http://gerrit.cloudera.org:8080/17202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6d0b1ca71e436bd5ad03101e9d02e9116a1ed2fa Gerrit-Change-Number: 17202 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] [security] enhance tls handshake test
Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/17198 )
Change subject: [security] enhance tls_handshake test
..
[security] enhance tls_handshake test
This patch adds extra verification step into the TestHandshakeSequence
scenario of TestTlsHandshake. That's to assert that both parties can
send and receive application data using OpenSSL API (i.e. SSL_Read() and
SSL_Write() function) once TlsHandshake::Continue() returns Status::OK.
In addition, the newly introduced utility methods in TestTlsHandshake
are useful for a follow-up changelist as well.
In addition, I cleaned up code in {client,server}_negotiation.cc
and in tls_context.cc.
Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Reviewed-on: http://gerrit.cloudera.org:8080/17198
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke
Reviewed-by: Attila Bukor
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.h
5 files changed, 98 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Gerrit-Change-Number: 17198
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] turn off TLS session cache
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17197 ) Change subject: [security] turn off TLS session cache .. [security] turn off TLS session cache As of now, a Kudu RPC connection cannot be re-established based on TLS session. Every connection attempt leads to negotiating a new connection from scratch since the client should have been calling SSL_set_session() explicitly to use a TLS session to re-establish previously used connection. Disabling the TLS session cache on both sides helps to spare a bit of memory and CPU needed to maintain the cache otherwise. Change-Id: I471b2c9dd3a406bb3604d86d28b5977289af2b09 Reviewed-on: http://gerrit.cloudera.org:8080/17197 Tested-by: Alexey Serbin Reviewed-by: Grant Henke Reviewed-by: Attila Bukor --- M src/kudu/security/tls_context.cc 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Verified Grant Henke: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I471b2c9dd3a406bb3604d86d28b5977289af2b09 Gerrit-Change-Number: 17197 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] small re-factoring on TlsHandshake
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17193 ) Change subject: [security] small re-factoring on TlsHandshake .. [security] small re-factoring on TlsHandshake A follow-up patch needs to know what side the TlsHandshake is running at. This changelist introduces that piece of information into the TlsHandshake class and also does other related re-factoring in the related code. Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e Reviewed-on: http://gerrit.cloudera.org:8080/17193 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke Reviewed-by: Attila Bukor --- M src/kudu/rpc/client_negotiation.cc M src/kudu/rpc/server_negotiation.cc M src/kudu/security/tls_context.cc M src/kudu/security/tls_context.h M src/kudu/security/tls_handshake-test.cc M src/kudu/security/tls_handshake.cc M src/kudu/security/tls_handshake.h M src/kudu/security/tls_socket-test.cc 8 files changed, 84 insertions(+), 63 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e Gerrit-Change-Number: 17193 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [security] move SslTypeTraits::kFreeFunc to openssl util.h
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17196 ) Change subject: [security] move SslTypeTraits::kFreeFunc to openssl_util.h .. [security] move SslTypeTraits::kFreeFunc to openssl_util.h This patch moves SslTypeTraits::kFreeFunc definition from the openssl_util_bio.h to openssl_util.h header file. The rationale for this update is that ssl_make_unique(BIO_new(...)) construct can be used separately from utility functions defined in openssl_util_bio.h, exactly like it's done in a follow-up patch. With that, inclusion of openssl_util_bio.h isn't necessary once openssl_util.h is already included. Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca Reviewed-on: http://gerrit.cloudera.org:8080/17196 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M src/kudu/security/openssl_util.h M src/kudu/security/openssl_util_bio.h 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca Gerrit-Change-Number: 17196 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] enhance tls handshake test
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17198 ) Change subject: [security] enhance tls_handshake test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743 Gerrit-Change-Number: 17198 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 16:01:28 + Gerrit-HasComments: No
[kudu-CR] [security] turn off TLS session cache
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17197 ) Change subject: [security] turn off TLS session cache .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I471b2c9dd3a406bb3604d86d28b5977289af2b09 Gerrit-Change-Number: 17197 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 15:09:06 + Gerrit-HasComments: No
[kudu-CR] [security] small re-factoring on TlsHandshake
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 ) Change subject: [security] small re-factoring on TlsHandshake .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e Gerrit-Change-Number: 17193 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Mar 2021 15:02:49 + Gerrit-HasComments: No
[kudu-CR] [security] enhance tls handshake test
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17198 ) Change subject: [security] enhance tls_handshake test .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743 Gerrit-Change-Number: 17198 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 13:58:35 + Gerrit-HasComments: No
[kudu-CR] [security] turn off TLS session cache
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17197 ) Change subject: [security] turn off TLS session cache .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I471b2c9dd3a406bb3604d86d28b5977289af2b09 Gerrit-Change-Number: 17197 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 13:45:20 + Gerrit-HasComments: No
[kudu-CR] [security] small re-factoring on TlsHandshake
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 ) Change subject: [security] small re-factoring on TlsHandshake .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e Gerrit-Change-Number: 17193 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Mar 2021 13:34:32 + Gerrit-HasComments: No
[kudu-CR] [security] move SslTypeTraits::kFreeFunc to openssl util.h
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17196 ) Change subject: [security] move SslTypeTraits::kFreeFunc to openssl_util.h .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca Gerrit-Change-Number: 17196 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Mar 2021 13:26:00 + Gerrit-HasComments: No
