[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu
Mladen Kovacevic has uploaded a new change for review. http://gerrit.cloudera.org:8080/4107 Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Update contributing doc page with apache/kudu instead of apache/incubator-kudu Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 --- M docs/contributing.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/1 -- To view, visit http://gerrit.cloudera.org:8080/4107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic
[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu
Mladen Kovacevic has uploaded a new patch set (#2). Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Update contributing doc page with apache/kudu instead of apache/incubator-kudu Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 --- M docs/contributing.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/2 -- To view, visit http://gerrit.cloudera.org:8080/4107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4107 to look at the new patch set (#3). Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Update contributing doc page with apache/kudu instead of apache/incubator-kudu Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 --- M docs/contributing.adoc M docs/developing.adoc M docs/installation.adoc M docs/release_notes.adoc 4 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/3 -- To view, visit http://gerrit.cloudera.org:8080/4107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu
Mladen Kovacevic has posted comments on this change. Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Patch Set 3: > There's a bunch of similar git clone links that use incubator-kudu > instead of kudu in installation.adoc. Could you fix those too? > Thanks! Sure, did a quick grep, and found some changes in developing, installation and release_notes. -- To view, visit http://gerrit.cloudera.org:8080/4107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] Replace incubator-kudu links with kudu in docs
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4107 to look at the new patch set (#4). Change subject: Replace incubator-kudu links with kudu in docs .. Replace incubator-kudu links with kudu in docs A number of docs were referring to the old incubator link: https://github.com/apache/incubator-kudu As opposed to the new, non-incubator link. https://github.com/apache/kudu We modify several of the documentation files to ensure that the links are consistent, and up-to-date with the apache/kudu url. Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 --- M RELEASING.adoc M docs/contributing.adoc M docs/developing.adoc M docs/installation.adoc M docs/release_notes.adoc 5 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/4 -- To view, visit http://gerrit.cloudera.org:8080/4107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Will Berkeley
[kudu-CR] Replace incubator-kudu links with kudu in docs
Mladen Kovacevic has posted comments on this change. Change subject: Replace incubator-kudu links with kudu in docs .. Patch Set 4: (3 comments) Alex and Will, thanks for the comments. Let me know if anything else is needed here. http://gerrit.cloudera.org:8080/#/c/4107/3//COMMIT_MSG Commit Message: Line 7: Replace incubator-kudu links with kudu in docs > Could you re-format the commit message a bit to follow the git guideline: Done http://gerrit.cloudera.org:8080/#/c/4107/3/docs/contributing.adoc File docs/contributing.adoc: Line 52: git clone https://github.com/apache/kudu > now that the repo name is kudu, I think this can be simplified to Done http://gerrit.cloudera.org:8080/#/c/4107/3/docs/installation.adoc File docs/installation.adoc: Line 242: $ git clone https://github.com/apache/kudu > same with all these; the kudu at the end can be left off. Done -- To view, visit http://gerrit.cloudera.org:8080/4107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] kudu-spark pom.xml has malformed artifactId
Mladen Kovacevic has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4628
Change subject: kudu-spark pom.xml has malformed artifactId
..
kudu-spark pom.xml has malformed artifactId
The pom.xml file in the kudu-spark directory has a malformed artifactId
that yields the following warning when building:
'artifactId' contains an expression but should be a constant.
@ org.apache.kudu:kudu-spark_${scala.binary.version}:[unknown-version]
It seems like maven doesn't like having an expression in there, and even
if we put the properties to appear before the artifactId, it still
complains.
Adding a hardcoded value to match the intended scala.binary.version
value.
Change-Id: I9b2a466dc0204aada28f8e72ba6f0a05fbb6fd05
---
M java/kudu-spark/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/4628/1
--
To view, visit http://gerrit.cloudera.org:8080/4628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b2a466dc0204aada28f8e72ba6f0a05fbb6fd05
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic
[kudu-CR] Running kudu-spark tests alone fail finding build dir
Mladen Kovacevic has uploaded a new change for review. http://gerrit.cloudera.org:8080/4630 Change subject: Running kudu-spark tests alone fail finding build dir .. Running kudu-spark tests alone fail finding build dir When running kudu-spark tests alone using 'mvn test', you end up with a failure as follows: 03:03:30.930 [WARN - main] (TestUtils.java:108) Unable to find build dir! myUrl=file:/Users/mladen/.m2/repository/org/apache/kudu/kudu-client/1.1.0-SNAPSHOT/kudu-client-1.1.0-SNAPSHOT-tests.jar Essentially, the kudu-client jar is typically installed by maven, and placed in your local machine's .m2 repository. The build dir lookup logic in TestUtils assumes that the TestUtils class is in your kudu source code git repo. However, it won't be when it has been installed by maven. The fix here is to have kudu-spark find the location of its own scala test files, and set the system property appropriately that will end up overriding the lookup logic done in the kudu-client package. Hence, it should find the binaries for kudu-master, etc without a problem. These changes also modify TestUtils.java slightly, to publicly make available helper functions and constants so that we're not duplicating code. This also makes it easier to adopt this strategy in other test cases. Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala 2 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/4630/1 -- To view, visit http://gerrit.cloudera.org:8080/4630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic
[kudu-CR] Running kudu-spark tests alone fail finding build dir
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4630 to look at the new patch set (#2). Change subject: Running kudu-spark tests alone fail finding build dir .. Running kudu-spark tests alone fail finding build dir When running kudu-spark tests alone using 'mvn test', you end up with a failure as follows: 03:03:30.930 [WARN - main] (TestUtils.java:108) Unable to find build dir! myUrl=file:/Users/mladen/.m2/repository/org/apache/kudu/kudu-client/1.1.0-SNAPSHOT/kudu-client-1.1.0-SNAPSHOT-tests.jar Essentially, the kudu-client jar is typically installed by maven, and placed in your local machine's .m2 repository. The build dir lookup logic in TestUtils assumes that the TestUtils class is in your kudu source code git repo. However, it won't be when it has been installed by maven. The fix here is to have kudu-spark find the location of its own scala test files, and set the system property appropriately that will end up overriding the lookup logic done in the kudu-client package. Hence, it should find the binaries for kudu-master, etc without a problem. These changes also modify TestUtils.java slightly, to publicly make available helper functions and constants so that we're not duplicating code. This also makes it easier to adopt this strategy in other test cases. Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala 2 files changed, 46 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/4630/2 -- To view, visit http://gerrit.cloudera.org:8080/4630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] Running kudu-spark tests alone fail finding build dir
Mladen Kovacevic has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: So this is interesting. If I go under java/kudu-spark and from there run "mvn clean package -DskipTests", I can see it download the kudu-client to pop into .m2. In this case, I actually modified kudu-client, so it would even fail to build kudu-spark. I'd need to go under kudu-client, run "mvn install -DskipTests", then *my* version of kudu-client is put into .m2 and so re-running the build in kudu-spark directory works. I just wanted to make sure that once you pull down the image, if you go straight into kudu-spark, the build and running the testcases should just work. Today they don't. -- To view, visit http://gerrit.cloudera.org:8080/4630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] Running kudu-spark tests alone fail finding build dir
Mladen Kovacevic has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: It seems a little 'hackish' anyway looking for the base kudu-client test class's location, the going up the chain until you hit '.git'. Just thought I'd make it more containable just within the kudu-spark section was the intention. Maybe its just a documentation change that's needed to explain how we're supposed to build and run tests smoothly? I'd be happy to change this commit to better documentation. I'm just not sure what to write just yet. -- To view, visit http://gerrit.cloudera.org:8080/4630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] kudu-spark pom.xml has malformed artifactId
Mladen Kovacevic has posted comments on this change. Change subject: kudu-spark pom.xml has malformed artifactId .. Patch Set 1: I see. Annoying, but I suppose it'll save changing it in two places in the pom file. -- To view, visit http://gerrit.cloudera.org:8080/4628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b2a466dc0204aada28f8e72ba6f0a05fbb6fd05 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] kudu-spark pom.xml has malformed artifactId
Mladen Kovacevic has abandoned this change. Change subject: kudu-spark pom.xml has malformed artifactId .. Abandoned Taking Dan's advice and leaving this in even with the warning, since its how the community typically does it. -- To view, visit http://gerrit.cloudera.org:8080/4628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9b2a466dc0204aada28f8e72ba6f0a05fbb6fd05 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Will Berkeley
[kudu-CR] Running kudu-spark tests alone fail finding build dir
Mladen Kovacevic has abandoned this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Abandoned After some back and forth offline, best to just leave this alone. The way to specify kudu binary directory is already documented in the java README.md which users can refer to. -- To view, visit http://gerrit.cloudera.org:8080/4630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mladen Kovacevic Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mladen Kovacevic Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
