[kudu-CR] [Tool] Limit table copying speed
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. [Tool] Limit table copying speed Migrating data to another Kudu cluster using the 'kudu table copy' CLI command when the data is very large may cause memory and/or network bandwidth perssure. To reduce the effect on other services, it is better to limit the copying speed. This patch introduces two parameter: --table_copy_throttler_bytes_per_sec and --table_copy_throttler_burst_factor to limit the table copying speed. Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Reviewed-on: http://gerrit.cloudera.org:8080/21527 Reviewed-by: Zoltan Chovan Reviewed-by: Abhishek Chennaka Tested-by: Yifan Zhang Reviewed-by: Yifan Zhang --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/table_scanner.cc M src/kudu/tools/table_scanner.h M src/kudu/tools/tool_action_table.cc 4 files changed, 81 insertions(+), 0 deletions(-) Approvals: Zoltan Chovan: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved Yifan Zhang: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Gerrit-Change-Number: 21527 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [Tool] Limit table copying speed
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Gerrit-Change-Number: 21527 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Fri, 19 Jul 2024 12:00:01 + Gerrit-HasComments: No
[kudu-CR] [Tool] Limit table copying speed
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. Patch Set 5: Verified+1 Unrelated test failures. -- To view, visit http://gerrit.cloudera.org:8080/21527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Gerrit-Change-Number: 21527 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Fri, 19 Jul 2024 11:59:52 + Gerrit-HasComments: No
[kudu-CR] [Tool] Limit table copying speed
Yifan Zhang has removed a vote on this change. Change subject: [Tool] Limit table copying speed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Gerrit-Change-Number: 21527 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [gitignore] ignore .qt, .qtc clangd, .vscode dirs
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21522 ) Change subject: [gitignore] ignore .qt, .qtc_clangd, .vscode dirs .. [gitignore] ignore .qt, .qtc_clangd, .vscode dirs Change-Id: Ie26322cfa69fbdf2241fcd7e9094ec49cb487b1c Reviewed-on: http://gerrit.cloudera.org:8080/21522 Tested-by: Kudu Jenkins Reviewed-by: Marton Greber Reviewed-by: Yifan Zhang --- M .gitignore 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Kudu Jenkins: Verified Marton Greber: Looks good to me, approved Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie26322cfa69fbdf2241fcd7e9094ec49cb487b1c Gerrit-Change-Number: 21522 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [gitignore] ignore .qt, .qtc clangd, .vscode dirs
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21522 ) Change subject: [gitignore] ignore .qt, .qtc_clangd, .vscode dirs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie26322cfa69fbdf2241fcd7e9094ec49cb487b1c Gerrit-Change-Number: 21522 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 17 Jun 2024 02:38:06 + Gerrit-HasComments: No
[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 7: Code-Review+1 Overall LGTM. Other than some comments in PS3 are not resolved yet. -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 14 Jun 2024 11:52:09 + Gerrit-HasComments: No
[kudu-CR] KUDU-3567 Fix reource leak in AsyncKuduScanner
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21512 Change subject: KUDU-3567 Fix reource leak in AsyncKuduScanner .. KUDU-3567 Fix reource leak in AsyncKuduScanner To avoid resource leak in AsyncKuduScanner, we should reuse the HashedWheelTimer instance from the corresponding AsyncKuduClient object in AsyncKuduScanner. Change-Id: Id675868fd86110633e147f71bceb092ac92ac038 --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/21512/1 -- To view, visit http://gerrit.cloudera.org:8080/21512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id675868fd86110633e147f71bceb092ac92ac038 Gerrit-Change-Number: 21512 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang
[kudu-CR] [master] fix race in auto leader rebalancing
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21417 ) Change subject: [master] fix race in auto leader rebalancing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccd66d00280d22b37386230874937e5260f07f3b Gerrit-Change-Number: 21417 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 10 May 2024 09:07:07 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3518: Fix the unexpected scan predicate
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21314 ) Change subject: KUDU-3518: Fix the unexpected scan predicate .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1 Gerrit-Change-Number: 21314 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Wed, 17 Apr 2024 03:30:12 + Gerrit-HasComments: No
[kudu-CR] KUDU-3518: Fix the unexpected scan predicate
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21244 ) Change subject: KUDU-3518: Fix the unexpected scan predicate .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG@13 PS3, Line 13: NON-NULL predicates on primary columns implicitly : added by ScanSpec::LiftPrimaryKeyBounds() > Abhishek and I have looked at a reproduction scenario, but it was built usi I got it, thanks! -- To view, visit http://gerrit.cloudera.org:8080/21244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1 Gerrit-Change-Number: 21244 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Tue, 16 Apr 2024 23:46:08 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 Unify the 'rdb' directory name
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I398bfd4a6a91d95f825362fc55c3b6c7dfe5c724 Gerrit-Change-Number: 21298 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 16 Apr 2024 10:11:31 + Gerrit-HasComments: No
[kudu-CR] KUDU-3518: Fix the unexpected scan predicate
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21244 ) Change subject: KUDU-3518: Fix the unexpected scan predicate .. Patch Set 3: Code-Review+1 (1 comment) This change looks good to me. Just worry about whether this is the real cause. Would be better if a reproducing test could be added as well. http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG@13 PS3, Line 13: NON-NULL predicates on primary columns implicitly : added by ScanSpec::LiftPrimaryKeyBounds() Yes, this function does add implicit NON_NULL predicates. But I'm still not sure whether the 'Unable to open scanner' error described in KUDU-3518 is related to this predicates addition at DRS level scan. -- To view, visit http://gerrit.cloudera.org:8080/21244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1 Gerrit-Change-Number: 21244 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Tue, 16 Apr 2024 10:10:02 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 Fix the crash bug when run binaries on older CPU machines
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15 PS1, Line 15: WITH_SNAPPY nit: Should this be 'PORTABLE'? http://gerrit.cloudera.org:8080/#/c/21287/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/21287/1/thirdparty/build-definitions.sh@1201 PS1, Line 1201: -DPORTABLE=ON \ Considering that this change rocksdb's default behavior and this may cause performance degradation, what about introducing another Kudu building option to set this option when building rocksdb? -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 15 Apr 2024 09:03:03 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 Unify the 'rdb' directory name
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I398bfd4a6a91d95f825362fc55c3b6c7dfe5c724 Gerrit-Change-Number: 21298 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 15 Apr 2024 08:27:17 + Gerrit-HasComments: No
[kudu-CR] [tablet] one less memory allocation in CBTree::count()
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Gerrit-Change-Number: 21276 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 10 Apr 2024 13:01:04 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3564: Fix IN list predicate pruning
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21253 ) Change subject: KUDU-3564: Fix IN list predicate pruning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033 Gerrit-Change-Number: 21253 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Sun, 07 Apr 2024 15:52:21 + Gerrit-HasComments: No
[kudu-CR] KUDU-3564: Fix IN list predicate pruning
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21243 ) Change subject: KUDU-3564: Fix IN list predicate pruning .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21243/2/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: http://gerrit.cloudera.org:8080/#/c/21243/2/src/kudu/common/scan_spec-test.cc@1010 PS2, Line 1010: SetExclusiveUpperBound(, upp > Should this be SetUpperBound(, upper_bound) instead? Done -- To view, visit http://gerrit.cloudera.org:8080/21243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Sun, 07 Apr 2024 06:09:18 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3564: Fix IN list predicate pruning
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21243 to look at the new patch set (#3). Change subject: KUDU-3564: Fix IN list predicate pruning .. KUDU-3564: Fix IN list predicate pruning This patch fixes IN list predicate pruning with a range specific hash schema by modifying the content of 'PartitionMayContainRow' method. We now get the right hash schema based on specific partition's lower bound key. This is a follow-up to 607d9d0. Change-Id: I964b1ccfb85602741843ab555cdee53343217033 --- M src/kudu/common/column_predicate.cc M src/kudu/common/partition.cc M src/kudu/common/scan_spec-test.cc 3 files changed, 93 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/21243/3 -- To view, visit http://gerrit.cloudera.org:8080/21243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [WIP] KUDU-3518: Fix unexpected new predicate
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21244 ) Change subject: [WIP] KUDU-3518: Fix unexpected new predicate .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21244/1//COMMIT_MSG Commit Message: PS1: > I haven't looked closely yet, but one thing that stood out was the absence +1 -- To view, visit http://gerrit.cloudera.org:8080/21244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1 Gerrit-Change-Number: 21244 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Sun, 07 Apr 2024 03:28:27 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3564: Fix IN list predicate pruning
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21243 to look at the new patch set (#2). Change subject: KUDU-3564: Fix IN list predicate pruning .. KUDU-3564: Fix IN list predicate pruning This patch fixes IN list predicate pruning with a range specific hash schema by modifying the content of 'PartitionMayContainRow' method. We now get the right hash schema based on specific partition's lower bound key. This is a follow-up to 607d9d0. Change-Id: I964b1ccfb85602741843ab555cdee53343217033 --- M src/kudu/common/column_predicate.cc M src/kudu/common/partition.cc M src/kudu/common/scan_spec-test.cc 3 files changed, 93 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/21243/2 -- To view, visit http://gerrit.cloudera.org:8080/21243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Alexey Serbin
[kudu-CR] KUDU-3564: Fix IN list predicate pruning
Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/21243 )
Change subject: KUDU-3564: Fix IN list predicate pruning
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc
File src/kudu/common/scan_spec-test.cc:
http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@102
PS1, Line 102: [colu
> nit: could use structured binding here?
Done
http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@105
PS1, Line 105: [colu
> ditto
Done
http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@110
PS1, Line 110: [col_names, num_buckets]
> nit: could use structural binding instead for this 'for()' cycle as well?
Done
http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@998
PS1, Line 998:
: // Set lower and upper bound for 'spec' to imitate a scan
request from client that
: // has start_primary_key and stop_primary_key.
: KuduPartialRow lower_bound(_);
: CHECK_OK(lower_bound.SetInt8("a", -128));
: CHECK_OK(lower_bound.SetInt8("b",
> What is this for?
The DCHECK in 'column_predicate.cc' was hit when running queries to reproduce
the bug. Setting lower and upper bounds for 'spec' is to hit the DCHECK.
--
To view, visit http://gerrit.cloudera.org:8080/21243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Gerrit-Change-Number: 21243
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Yifan Zhang
Gerrit-Comment-Date: Sun, 07 Apr 2024 03:14:40 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3564: Fix IN list predicate pruning
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21243 Change subject: KUDU-3564: Fix IN list predicate pruning .. KUDU-3564: Fix IN list predicate pruning This patch fixes IN list predicate pruning with a range specific hash schema by modifying the content of 'PartitionMayContainRow' method. We now get the right hash schema based on specific partition's lower bound key. This is a follow-up to 607d9d0. Change-Id: I964b1ccfb85602741843ab555cdee53343217033 --- M src/kudu/common/column_predicate.cc M src/kudu/common/partition.cc M src/kudu/common/scan_spec-test.cc 3 files changed, 86 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/21243/1 -- To view, visit http://gerrit.cloudera.org:8080/21243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. [Java] KUDU-3498 Scanner keeps alive in periodically Kudu caches the scanner in the tablet server for continuing reading. It will be expired if the idle time is over the defined scanner ttl time. Sometimes the client reads a batch of data, if the data is every large, it takes a long time to handle it. Then the client reads the next batch using the same scanner, the scanner will be expired even if it has sent a keep alive request. This patch adds support for keeping a scanner alive periodically. It uses a timer to send keep alive requests background. So, it will never be expired when the scanner is in using. Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Reviewed-on: http://gerrit.cloudera.org:8080/20761 Reviewed-by: Yifan Zhang Tested-by: Yifan Zhang --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java 3 files changed, 205 insertions(+), 1 deletion(-) Approvals: Yifan Zhang: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 10: Verified+1 Unrelated test failures in SubprocessServerTest.LargePayloadSize(RELEASE), MaintenanceManagerTest.TestNewOpsDontGetScheduledDuringUnregister(TSAN), CatalogManagerConfigurations/MasterStressTest.Test/3(TSAN). -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 26 Mar 2024 12:23:01 + Gerrit-HasComments: No
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has removed a vote on this change. Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 26 Mar 2024 11:49:21 + Gerrit-HasComments: No
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Thu, 21 Mar 2024 14:27:46 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3486 Periodically send tombstoned replica report to delete it.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21176 ) Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 21176 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Thu, 21 Mar 2024 05:09:37 + Gerrit-HasComments: No
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20761/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20761/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@430 PS8, Line 430: int row_count = 0; We have a checkstyle error here: [ant:checkstyle] [WARN] /home/jenkins-slave/workspace/kudu-master/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:430:11: Local variable name 'row_count' must match pattern '^[a-z]([a-z0-9][a-zA-Z0-9]*)?$'. [LocalVariableName] -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 02 Feb 2024 07:46:30 + Gerrit-HasComments: Yes
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20761/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20761/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@970 PS7, Line 970:* @param scanner the scanner to keep alive. nit: Do we have this parameter for the method? http://gerrit.cloudera.org:8080/#/c/20761/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20761/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@434 PS7, Line 434: scanner.nextRows(); nit: We should also verify that we can read all rows inserted without 'scanner not found' error occurs. http://gerrit.cloudera.org:8080/#/c/20761/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@474 PS7, Line 474: /* :* Test keeping a scanner alive periodically beyond scanner ttl. :*/ nit: Update this comment. -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 30 Jan 2024 08:26:38 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 28: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20715/27/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/20715/27/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@312 PS27, Line 312: return tabletServers.get(uuid); > For now it returns null if uuid is null, which I think it should return. Th That makes sense. Thanks for your clarification. -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 28 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Thu, 18 Jan 2024 08:36:06 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/20715/27/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20715/27/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@291 PS27, Line 291: bounded nit: bound http://gerrit.cloudera.org:8080/#/c/20715/27/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/20715/27/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@312 PS27, Line 312: return tabletServers.get(uuid); nit: Should we also handle the case where uuid is null? -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 27 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Sun, 14 Jan 2024 06:50:39 + Gerrit-HasComments: Yes
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@481 PS3, Line 481: client.stopKeepAlivePeriodically(); Should we also call stopKeepAlivePeriodically in the close() function? http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@967 PS3, Line 967: be nit: can be http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java@112 PS3, Line 112: be nit: can be http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@424 PS3, Line 424: scanner.startKeepAlivePeriodically(SHORT_SCANNER_TTL_MS / 10); Could we also verify that the KeepAlive task has been stopped automatically? http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@461 PS3, Line 461: assertTrue(scanner.startKeepAlivePeriodically(SHORT_SCANNER_TTL_MS / 10)); : assertTrue(scanner.stopKeepAlivePeriodically()); Could you add a comment why we do this? -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Sun, 14 Jan 2024 06:25:56 + Gerrit-HasComments: Yes
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs] Simplify the data directory inheritance hierarchy This patch doesn't introduce functional changes, but only simplify the inheritance hierarchy of class Dir to reduce the complex when extend the Dir class, for example, when adding a sub-class of Dir to contain a RocksDB instance, see http://gerrit.cloudera.org:8080/18569. Because there are not sufficient reasons, so the DataDir sub-class is removed and the implementation functions are moved to the super class Dir. Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Reviewed-on: http://gerrit.cloudera.org:8080/20833 Tested-by: Yingchun Lai Reviewed-by: Ádám Bakai Reviewed-by: Yifan Zhang --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/data_dirs.h M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/fs_manager.h 5 files changed, 19 insertions(+), 38 deletions(-) Approvals: Yingchun Lai: Verified Ádám Bakai: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Ádám Bakai
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Fri, 05 Jan 2024 02:16:36 + Gerrit-HasComments: No
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 02 Jan 2024 09:18:20 + Gerrit-HasComments: No
[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 18: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@657 PS11, Line 657: LocatedTablet targetTablet = null; > Actually the error thread is not the main thread so the assert mostly not w nit: Maybe we can catch the exception and check its error message does not contain 'scanner not found'. -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 18 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 22 Dec 2023 12:36:08 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .. KUDU-3486 Periodically send tombstoned replica report to delete it. A tombstoned tablet replica might never be deleted since the delete-type deletion could only occur when the tablet is deleted. And the requests will only be sent to the voters, not including the tombstoned ones. The data of tombstone replica is deleted, but metadata is persisted in memory, which will occupy a lot of memory, especially for the tablets with big SchemaPB. Tombstoned replicas can be deleted while processing heartbeats. So making the tservers periodically send some reports with tombstoned replicas will delete the useless tombstoned replicas. See KUDU-3486 for details. Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Reviewed-on: http://gerrit.cloudera.org:8080/20600 Tested-by: Kudu Jenkins Reviewed-by: Yifan Zhang --- M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/tserver/heartbeater.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 4 files changed, 104 insertions(+), 10 deletions(-) Approvals: Kudu Jenkins: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 27 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20720/6/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/20720/6/src/kudu/tablet/tablet.cc@2030 PS6, Line 2030: : shared_ptr mer nit: Make these closer to where they are used. -- To view, visit http://gerrit.cloudera.org:8080/20720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c2f20230aa089baf34f418a59b6c97f7351217 Gerrit-Change-Number: 20720 Gerrit-PatchSet: 7 Gerrit-Owner: Ashwani Raina Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 19 Dec 2023 11:44:38 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .. Patch Set 26: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 26 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Mon, 18 Dec 2023 11:45:18 + Gerrit-HasComments: No
[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f Gerrit-Change-Number: 20739 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 14 Dec 2023 09:58:35 + Gerrit-HasComments: No
[kudu-CR] KUDU-3524 Fix core of sending keep-alive requests periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix core of sending keep-alive requests periodically .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc@107 PS4, Line 107: } nit: The indentation is incorrect. -- To view, visit http://gerrit.cloudera.org:8080/20739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f Gerrit-Change-Number: 20739 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 14 Dec 2023 03:53:37 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3524 Fix core of sending keep-alive requests periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix core of sending keep-alive requests periodically .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20739/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20739/3//COMMIT_MSG@10 PS3, Line 10: will core > Could you please add a unit test to reproduce this? And make sure the fix w +1 http://gerrit.cloudera.org:8080/#/c/20739/3/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20739/3/src/kudu/client/scanner-internal.cc@104 PS3, Line 104: delete this; Should we also log some error messages? See the implementation of 'CloseCallback' for an example. -- To view, visit http://gerrit.cloudera.org:8080/20739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f Gerrit-Change-Number: 20739 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Sat, 09 Dec 2023 02:40:37 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .. Patch Set 22: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20600/22/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: http://gerrit.cloudera.org:8080/#/c/20600/22/src/kudu/tserver/heartbeater.cc@116 PS22, Line 116: please set this interval less than the flag " : "metadata_for_deleted_table_and_tablet_reserved_secs of master. nit: Add 'if enable_metadata_cleanup_for_deleted_tables_and_tablets is set true'. -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 22 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Sat, 09 Dec 2023 01:56:33 + Gerrit-HasComments: Yes
[kudu-CR] more strict check for [un]setenv() return code
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9 Gerrit-Change-Number: 20744 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 05 Dec 2023 04:09:05 + Gerrit-HasComments: No
[kudu-CR] more strict check for [un]setenv() return code
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc@519 PS1, Line 519: g_kinit_ctx = new KinitContext; Is this change needed? -- To view, visit http://gerrit.cloudera.org:8080/20744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9 Gerrit-Change-Number: 20744 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Mon, 04 Dec 2023 08:11:16 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.
Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/20600 )
Change subject: KUDU-3486 Periodically send tombstoned replica report to delete
it.
..
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:
http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/heartbeater.cc@110
PS20, Line 110:
DEFINE_int32(tserver_send_tombstoned_tablets_report_inteval_secs, 21600,
: "Time interval in seconds of sending a incremental
tablets report "
: "to delete the tombstoned replicas whose tablets
had already been "
: "deleted. Turn off this by setting it to a value
less than 0.");
nit: Also need to mention that if this interval is set to less than the
heartbeat interval, the tablets report will only be sent at the heartbeat
interval.
http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:
http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc@1794
PS20, Line 1794: for (const auto& entry : tablet_map_) {
: if (entry.second->data_state() ==
tablet::TABLET_DATA_TOMBSTONED) {
: to_report.push_back(entry.second);
: }
: }
> After the replica gets tombstoned, there might be very long time before its
'the tombstoned replica will only be reported in the next heartbeat.'
Right. So that means tombstoned should not be removed from 'dirty_tablets_'
until they are deleted. And we need to process these tombstoned tablets every
heartbeat request.
Compared with the current approach, I'm good with iterating all the tablets
every 6 hours.
--
To view, visit http://gerrit.cloudera.org:8080/20600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b
Gerrit-Change-Number: 20600
Gerrit-PatchSet: 20
Gerrit-Owner: Song Jiacheng
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang
Gerrit-Comment-Date: Thu, 30 Nov 2023 04:16:20 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.
Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/20600 )
Change subject: KUDU-3486 Periodically send tombstoned replica report to delete
it.
..
Patch Set 20: Code-Review+1
(1 comment)
Thanks for fixing this issue! The changes overall look good to me.
http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:
http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc@1794
PS20, Line 1794: for (const auto& entry : tablet_map_) {
: if (entry.second->data_state() ==
tablet::TABLET_DATA_TOMBSTONED) {
: to_report.push_back(entry.second);
: }
: }
nit: To avoid iterating all tablets on a tablet server, maybe we can call
'MarkTabletDirty' when a tablet's state turns to 'TOMBSTONED'? Then only dirty
tablets should be processed here.
--
To view, visit http://gerrit.cloudera.org:8080/20600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b
Gerrit-Change-Number: 20600
Gerrit-PatchSet: 20
Gerrit-Owner: Song Jiacheng
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang
Gerrit-Comment-Date: Thu, 23 Nov 2023 03:11:28 +
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] update lz4 up to 1.9.4 version
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20722 ) Change subject: [thirdparty] update lz4 up to 1.9.4 version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6af15b88d34e70474f655a4045970253f257e38 Gerrit-Change-Number: 20722 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 22 Nov 2023 06:37:18 + Gerrit-HasComments: No
[kudu-CR] KUDU-3486 Master periodically request for full reports.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Master periodically request for full reports. .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/20600/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20600/18//COMMIT_MSG@19 PS18, Line 19: making the tservers periodically send : full report Full reports from all tablet servers could cause huge network overhead. Maybe, just making tablet servers periodically send reports of tombstoned replicas is enough? Another thought: master should know which replica is tombstoned since the 'tombstoned' request is sent by the master. So could the master also send the 'delete' request to tombstoned replicas when processing drop table/partition requests from clients? -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 18 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 14 Nov 2023 10:02:46 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20680/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/20680/1/src/kudu/util/env_posix.cc@1869 PS1, Line 1869: // See issue: https://issues.apache.org/jira/browse/KUDU-3523. nit: Maybe replace this link with: https://man7.org/linux/man-pages/man2/statfs.2.html? -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Sun, 12 Nov 2023 05:57:39 + Gerrit-HasComments: Yes
[kudu-CR] [util] fix compilation warning
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20671 ) Change subject: [util] fix compilation warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a Gerrit-Change-Number: 20671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 07 Nov 2023 02:44:57 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [build] Make uncompress symbols local in exported libkudu client.so
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20665 ) Change subject: [build] Make uncompress symbols local in exported libkudu_client.so .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I5033eef9dee6711f302d877cfb81a066b65f0319 Gerrit-Change-Number: 20665 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 07 Nov 2023 02:35:10 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 08:33:19 + Gerrit-HasComments: No
[kudu-CR] Minor refactoring on kudu-tool-test (take 2)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20655 ) Change subject: Minor refactoring on kudu-tool-test (take 2) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86d2120aa689473495ec8d4604caee1123060663 Gerrit-Change-Number: 20655 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 06 Nov 2023 03:50:41 + Gerrit-HasComments: No
[kudu-CR] Fix the missing parameterized unit test
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20656 ) Change subject: Fix the missing parameterized unit test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06947846a401183d00e00bf43d7cf4d86002232 Gerrit-Change-Number: 20656 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Mon, 06 Nov 2023 03:37:25 + Gerrit-HasComments: No
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Fri, 27 Oct 2023 06:21:41 + Gerrit-HasComments: No
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 16 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Thu, 26 Oct 2023 06:27:35 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3483 Fix flushing data in batch when table schema changed
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20622 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 20622 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 26 Oct 2023 06:16:46 + Gerrit-HasComments: No
[kudu-CR] [tablet] fix compilation warnings
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warnings .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I481c5bb3e83575c3bfe24a31ff077bd528f17e48 Gerrit-Change-Number: 20619 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 25 Oct 2023 05:05:47 + Gerrit-HasComments: No
[kudu-CR] [tablet] fix compilation warning
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I481c5bb3e83575c3bfe24a31ff077bd528f17e48 Gerrit-Change-Number: 20619 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 25 Oct 2023 03:15:05 + Gerrit-HasComments: No
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 16 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 24 Oct 2023 07:50:23 + Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5 Gerrit-Change-Number: 20504 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Wed, 18 Oct 2023 02:24:37 + Gerrit-HasComments: No
[kudu-CR] [style] clean-up on virtual & override specifiers
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20578 ) Change subject: [style] clean-up on virtual & override specifiers .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id04a71fd3f1afe45e5aad8a92030e6f8f344fcf5 Gerrit-Change-Number: 20578 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 18 Oct 2023 01:19:42 + Gerrit-HasComments: No
[kudu-CR] [style] clean-up on virtual & override specifiers
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20578 ) Change subject: [style] clean-up on virtual & override specifiers .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20578/3/src/kudu/gutil/port.h File src/kudu/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/20578/3/src/kudu/gutil/port.h@517 PS3, Line 517: // Annotate a method indicating that subclasses must not override it, nit: 'virtual' should be reserved. http://gerrit.cloudera.org:8080/#/c/20578/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/20578/3/src/kudu/util/metrics.cc@906 PS3, Line 906: // method and not adding this empty override here. nit: The 'virtual' here seems should not be removed. http://gerrit.cloudera.org:8080/#/c/20578/3/src/kudu/util/net/socket.h File src/kudu/util/net/socket.h: http://gerrit.cloudera.org:8080/#/c/20578/3/src/kudu/util/net/socket.h@107 PS3, Line 107: // It is so that tests can override. nit: The 'virtual' here should not be removed. -- To view, visit http://gerrit.cloudera.org:8080/20578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id04a71fd3f1afe45e5aad8a92030e6f8f344fcf5 Gerrit-Change-Number: 20578 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 17 Oct 2023 06:44:35 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66 PS2, Line 66: > Some comments have been added to the declaration of 'max_malformed_types_' nit: Could we move the definition for class NativeMetadataLBMCorruptor to .h file? http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc@195 PS5, Line 195: // NOLINT(clang-analyzer-core.NonNullParamChecker) nit: Is this for avoiding lint-checking errors? Just curious why is it not needed before? http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc@467 PS5, Line 467: NativeMetadataLBMCorruptor:: I see some methods of the class NativeMetadataLBMCorruptor are spread over methods of the base class LBMCorruptor. Should we put methods of the same class together? -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5 Gerrit-Change-Number: 20504 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Mon, 16 Oct 2023 07:18:48 + Gerrit-HasComments: Yes
[kudu-CR] [tablet] a small clean up on 'disable compaction'
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20577 ) Change subject: [tablet] a small clean up on 'disable_compaction' .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40 Gerrit-Change-Number: 20577 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Mon, 16 Oct 2023 03:22:08 + Gerrit-HasComments: No
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/20282/14/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/14/src/kudu/client/client-test.cc@3093 PS14, Line 3093: // Set fault tolerance false to enable the scanner expired. : ASSERT_OK(scanner.data_->mutable_configuration()->SetFaultTolerant(false)); Do we need to SetFaultTolerant every iteration in this loop? http://gerrit.cloudera.org:8080/#/c/20282/14/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/14/src/kudu/client/client.h@2954 PS14, Line 2954: It has the same function with KeepAlive(). I think this sentence is not true. Could you remove it and rephrase the words about this method? http://gerrit.cloudera.org:8080/#/c/20282/14/src/kudu/client/client.h@2965 PS14, Line 2965: Of course, when scanner has read all datas, it is : /// also called. And when the scanner is destroyed, it is also called. We don't have to show the internals of function calls in the comment. Do we always need to call 'KeepAlivePeriodically' and 'StopKeepAliveTimer' in pairs? Or 'StopKeepAliveTimer' is only needed for some special cases, and what these cases are? I think this information should be included in the comment. -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 14 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Fri, 13 Oct 2023 12:47:49 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h File src/kudu/fs/log_block_manager-test-util.h: http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h@177 PS2, Line 177: // Use DataDirManager to access the Dir objects conveniently. : DataDirManager* dd_manager_; Seems this object is not so necessary to be introduced in the base class(at least in this patch's scope). Is it possible to include it only in a specific derived class? If not, maybe just include these changes in the relevant patch? http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66 PS2, Line 66: max_malformed_types_ = 7; nit: Could we initialize max_malformed_types_ in the .h file? It may be easier to find out why it should be 7. http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@233 PS2, Line 233: RETURN_NOT_OK(metadata_writer->Close()); : return Status::OK(); nit: Replace these with 'return metadata_writer->Close()'? Same as other places. -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5 Gerrit-Change-Number: 20504 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Sat, 07 Oct 2023 11:33:14 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 13: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20282/13/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/13/src/kudu/client/client.h@2962 PS13, Line 2962: /// Stop keeping the current remote scanner alive periodically. nit: Could you add more description for the usage of this method? Maybe add a document about when and how to use it. -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Sat, 07 Oct 2023 07:17:39 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3447] Limit tablets copying speed
Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/19479 )
Change subject: [KUDU-3447] Limit tablets copying speed
..
Patch Set 10:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tools/kudu-tool-test.cc@9384
PS10, Line 9384: ASSERT_STR_CONTAINS(stderr, "Time spent Tablet copy
throttler");
I don't think we should add a new test just to verify the output message or
log. Maybe we can collect the number of bytes downloaded and the time used, and
to verify the rate is within the limit?
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tools/tool_action_local_replica.cc@1386
PS10, Line 1386: .AddOptionalParameter("tablet_copy_throttler_bytes_per_sec")
:
.AddOptionalParameter("tablet_copy_throttler_burst_factor")
nit: It's necessary to mention these two parameters in the commit message.
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tserver/tablet_copy_client.h
File src/kudu/tserver/tablet_copy_client.h:
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tserver/tablet_copy_client.h@320
PS10, Line 320: std::shared_ptr throttler_;
Can we make it a 'std::unique_ptr'?
Maybe use it like this:
std::unique_ptr throttler_ = nullptr;
if (FLAGS_tablet_copy_throttler_bytes_per_sec > 0)
throttler.reset(new Throttler()).
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tserver/tablet_copy_client.cc
File src/kudu/tserver/tablet_copy_client.cc:
http://gerrit.cloudera.org:8080/#/c/19479/10/src/kudu/tserver/tablet_copy_client.cc@83
PS10, Line 83: DEFINE_int64(tablet_copy_throttler_bytes_per_sec, 0,
: "Limit tablet copy speed.");
: DEFINE_int64(tablet_copy_throttler_burst_factor, 0,
: "Burst factor for tablet copy throttling. The
maximum rate the throttler "
: "allows within a token refill period (100ms) equals
burst factor multiply "
: "base rate.");
Are these definitions necessary here? They are already defined in
tool_action_local_replica.cc
--
To view, visit http://gerrit.cloudera.org:8080/19479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4834bfb0718a2b6b1d946975287a11f6be1fe3
Gerrit-Change-Number: 19479
Gerrit-PatchSet: 10
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Ashwani Raina
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang
Gerrit-Reviewer: Yingchun Lai
Gerrit-Comment-Date: Wed, 27 Sep 2023 12:33:07 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically
..
Patch Set 10: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc@3036
PS10, Line 3036: // It is expired.
: if (s.IsNotFound()) {
: has_expired_scan = true;
: break;
: }
nit: I see in PS4, you use ASSERT_TRUE(s.IsNotFound) here. Why is this changed?
Could we just sleep more time to make sure there must be a NotFound error?
http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc@3049
PS10, Line 3049: time
nit: timer
http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/scanner-internal.h
File src/kudu/client/scanner-internal.h:
http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/scanner-internal.h@307
PS10, Line 307: It used to
This is used to
--
To view, visit http://gerrit.cloudera.org:8080/20282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 10
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang
Gerrit-Reviewer: Yingchun Lai
Gerrit-Reviewer: Yuqi Du
Gerrit-Comment-Date: Wed, 27 Sep 2023 05:20:48 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc@3090 PS8, Line 3090: // Set fault tolerance false to enable the scanner expired. : ASSERT_OK(scanner.data_->mutable_configuration()->SetFaultTolerant(false)); Why do we need to set fault tolerant false here? Does it affect whether the scanner expires? http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc@3108 PS8, Line 3108: TestStopKeepAlivePeriodically Seems this test is for testing the functionality of the StopKeepAlivePeriodically() method. Could you also add a test that verifies the keep alive timer can automatically stop if all the required data has been retrieved from tablet servers? http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc@3121 PS8, Line 3121: // Start the keepalive timer. This comment does not match the actual behavior in the following code. http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client.h@2963 PS8, Line 2963: StopKeepAlivePeriodically nit: What about renaming it to 'StopKeepAliveTimer'? -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 26 Sep 2023 03:44:41 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update website for 1.17.0 release in index.md
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20450 ) Change subject: Update website for 1.17.0 release in index.md .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: If4c39152e27b5bd2996aefef34118c718ac5c5e3 Gerrit-Change-Number: 20450 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 05 Sep 2023 03:10:17 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [client] fix doxygen warnings
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20446 ) Change subject: [client] fix doxygen warnings .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I440d4f79ccd1b7e4f852cdf423727245e84e8d56 Gerrit-Change-Number: 20446 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 04 Sep 2023 10:06:28 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] Enable building 'kudu test' CLI tool by default
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20398 ) Change subject: [tools] Enable building 'kudu test' CLI tool by default .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20398 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 23 Aug 2023 01:25:48 + Gerrit-HasComments: No
[kudu-CR] [tools] Enable building 'kudu test' CLI tool by default
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable building 'kudu test' CLI tool by default .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 22 Aug 2023 12:09:37 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3502: disable http2 support in libcurl
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20341 ) Change subject: KUDU-3502: disable http2 support in libcurl .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d Gerrit-Change-Number: 20341 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 10 Aug 2023 16:00:13 + Gerrit-HasComments: No
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20339 to look at the new patch set (#2). Change subject: KUDU-3502: disable http2 support in libcurl .. KUDU-3502: disable http2 support in libcurl This patch adds '--without-nghttp2' option when building curl. The http2 feature is not needed for Kudu tests or other cases, so it make senses to remove it to avoid linker errors. Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/20339/2 -- To view, visit http://gerrit.cloudera.org:8080/20339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d Gerrit-Change-Number: 20339 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20339 Change subject: KUDU-3502: disable http2 support in libcurl .. KUDU-3502: disable http2 support in libcurl This patch adds '--without-nghttp2' option when building curl. The http2 feature is not needed for Kudu tests or other cases so it make senses to remote it to avoid linker errors. Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/20339/1 -- To view, visit http://gerrit.cloudera.org:8080/20339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d Gerrit-Change-Number: 20339 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client-test.cc@2987 PS3, Line 2987: 3 nit: Is it enough to sleep a bit over FLAGS_scanner_ttl_ms? http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client.h@2952 PS3, Line 2952: KeepAliveInPeriodically nit: Rename it to KeepAlivePeriodically. Same as other places. http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/scanner-internal.cc@104 PS3, Line 104: keep_alive_interval_ms nit: Is it worth making this a member variable with a default value of KuduScanner? Also, I noticed that the Java client has 'keepAlivePeriodMs' setting in KuduScannerIterator. And keepKuduScannerAlive is called in KuduScannerIterator#hasNext. Could we implement this in Cpp client the same way Java client does? -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Thu, 10 Aug 2023 06:45:35 + Gerrit-HasComments: Yes
[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DKUDU CLI TOOL NO TESTS=0
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 10 Aug 2023 03:07:08 + Gerrit-HasComments: No
[kudu-CR] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@14 PS2, Line 14: send sent http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@14 PS2, Line 14: requests request http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@16 PS2, Line 16: supports to keep scanner alive in periodically adds support for keeping a scanner alive periodically http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@17 PS2, Line 17: So, it will never : be expired. Why do we need to keep a scanner never expired? If a scan task is finished, it should be removed since a scanner keeps resources on the server. http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client-test.cc@2979 PS2, Line 2979: ASSERT_EQ(batch.NumRows(), 9); Is it always true? If so, could you also elaborate more on why the first batch always contains exactly 9 rows? http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client.h@2951 PS2, Line 2951: in periodicly periodically -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Wed, 09 Aug 2023 03:08:20 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20335 ) Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd Gerrit-Change-Number: 20335 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 09 Aug 2023 01:45:19 + Gerrit-HasComments: No
[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DNO TESTS=1
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14 PS1, Line 14: This patch enable to build 'kudu test' CLI tool even if : -DNO_TESTS=1. I'm wondering if in some cases this 'test' feature is not so necessary. E.g. for production environment deployment. Then there is nothing wrong with the existing behavior of '-DNO_TESTS'. Maybe we can add another option for enabling the 'kudu test'? -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 08 Aug 2023 12:45:20 + Gerrit-HasComments: Yes
[kudu-CR] [clock] fix HybridClockTest.TimeSourceAutoSelection
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20324 ) Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd Gerrit-Change-Number: 20324 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 08 Aug 2023 01:29:05 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20293 ) Change subject: [docs] Update 1.17.0 release notes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I451fba2192a567a72b8e067ede3ab40823c8b36c Gerrit-Change-Number: 20293 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 01 Aug 2023 12:49:48 + Gerrit-HasComments: No
[kudu-CR] [java client] Make row errors more readable
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [java client] Make row errors more readable .. [java client] Make row errors more readable Flushing data in AUTO_FLUSH_BACKGROUND mode sometimes may fail. It's possible get the error details by calling KuduSession.getPendingErrors(), but it doesn't present the information in a human-readable form. Here is an example: " Row error for primary key=[-128, 0, 0, 12], tablet=null, server=ff9a26c5fcde45f5b74c3da11a7fc89d, status=Already present: key already present (error 0) " This patch makes the row errors more readable for debugging. Here is an example after using this patch: " Row error for row=(int32 key=12, int32 column1_i=2, int32 column2_i=3, string column3_s="a string", bool column4_b=true), tablet=null, server=ba360521df2844b8a9035c7c505d30d8, status=Already present: key already present (error 0) " Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Reviewed-on: http://gerrit.cloudera.org:8080/20163 Reviewed-by: Yifan Zhang Tested-by: Yifan Zhang --- M java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java 2 files changed, 85 insertions(+), 1 deletion(-) Approvals: Yifan Zhang: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [java client] Make row errors more readable
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [java client] Make row errors more readable .. Patch Set 6: Verified+1 Code-Review+2 Unrelated test failure in org.apache.kudu.client.TestAsyncKuduSession(TSAN mode). -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 01 Aug 2023 07:41:15 + Gerrit-HasComments: No
[kudu-CR] [java client] Make row errors more readable
Yifan Zhang has removed a vote on this change. Change subject: [java client] Make row errors more readable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [common] minor optimization on ComputeHashBuckets
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20288 ) Change subject: [common] minor optimization on ComputeHashBuckets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecd9a739f408646c0dab74727f919e4f6ce3ce7e Gerrit-Change-Number: 20288 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 01 Aug 2023 02:00:39 + Gerrit-HasComments: No
[kudu-CR] [common] fix compilation warning
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20287 ) Change subject: [common] fix compilation warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bc8cd869988f69c35a98872cefc072321d6ef3f Gerrit-Change-Number: 20287 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 01 Aug 2023 01:55:00 + Gerrit-HasComments: No
[kudu-CR] [tserver] KUDU-1827: tserver decommission
Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18441 )
Change subject: [tserver] KUDU-1827: tserver decommission
..
Patch Set 12:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/master/auto_rebalancer-test.cc@285
PS12, Line 285: Status ChangeTServerState(const string& uuid,
TServerStateChangePB::StateChange change) {
If I don't miss something, what is this method used for?
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/kudu-tool-test.cc@8400
PS12, Line 8400: }
Maybe we also need to check there is no replica on the decommissioned tablet
server.
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/tool_action_tserver.cc
File src/kudu/tools/tool_action_tserver.cc:
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/tool_action_tserver.cc@460
PS12, Line 460: RETURN_NOT_OK(IsDecommissioningInProgress(context,
));
:
: if (decommissioningInProgress) {
: return Status::IllegalState("Decommissioning already in
progress");
: }
:
If `decommissioningInProgress` is true, the method will return a non-OK status,
right?
http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/tool_action_tserver.cc@495
PS12, Line 495: /* max_moves_per_server = */ 5,
: /* max_staleness_interval_sec = */ 300,
: /* max_run_time_sec = */ 0,
Can these parameters also be configurable?
--
To view, visit http://gerrit.cloudera.org:8080/18441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15c52b653c20b2a3a45fbf8934f19f6bd1a9caea
Gerrit-Change-Number: 18441
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Chovan
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang
Gerrit-Reviewer: Zoltan Chovan
Gerrit-Comment-Date: Mon, 31 Jul 2023 15:01:07 +
Gerrit-HasComments: Yes
[kudu-CR] [cmake] clean up on targets when using NO TESTS=1
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20281 ) Change subject: [cmake] clean up on targets when using NO_TESTS=1 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6de4f9498bef9b2102ea6507a35ad78b08d4c27a Gerrit-Change-Number: 20281 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 31 Jul 2023 12:42:10 + Gerrit-HasComments: No
[kudu-CR] [java client] Make row errors more readable
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [java client] Make row errors more readable .. Patch Set 5: Code-Review+1 The lint failure report by Jenkins may be related to this change. -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Mon, 31 Jul 2023 12:41:42 + Gerrit-HasComments: No
[kudu-CR] [ut] Add '--log cleanup interval sec' flag and speedup an unit test
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19915 ) Change subject: [ut] Add '--log_cleanup_interval_sec' flag and speedup an unit test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19915/3/src/kudu/integration-tests/log-rolling-itest.cc File src/kudu/integration-tests/log-rolling-itest.cc: http://gerrit.cloudera.org:8080/#/c/19915/3/src/kudu/integration-tests/log-rolling-itest.cc@68 PS3, Line 68: coredump nit: crash -- To view, visit http://gerrit.cloudera.org:8080/19915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2be9f88c5d47bc889a4711f5aa2143b8288ba60 Gerrit-Change-Number: 19915 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Fri, 28 Jul 2023 07:49:34 + Gerrit-HasComments: Yes
[kudu-CR] [Client] Make row errors more readable
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [Client] Make row errors more readable .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java: http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java@173 PS3, Line 173: 1 nit: Could these constant values be defined as final variables? -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 28 Jul 2023 07:23:27 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.17.x) [server] KUDU-1945 Auto incrementing column UPSERT support
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20227 ) Change subject: [server] KUDU-1945 Auto_incrementing column UPSERT support .. Patch Set 2: All test failures seem related to a configure error in protobuf: configure: error: in `/home/jenkins-slave/workspace/kudu-branch-1.17.x/0/thirdparty/build/protobuf-3.14.0': -- To view, visit http://gerrit.cloudera.org:8080/20227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ib5cc4d80f77c165452572948f68c76fc70394d47 Gerrit-Change-Number: 20227 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 21 Jul 2023 01:52:44 + Gerrit-HasComments: No
[kudu-CR] KUDU-3492 upgrade Netty to 4.1.98.Final
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20236 ) Change subject: KUDU-3492 upgrade Netty to 4.1.98.Final .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20c5c1d9260b1089cc2713fcf8559eb80c2c67c4 Gerrit-Change-Number: 20236 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 21 Jul 2023 01:55:55 + Gerrit-HasComments: No
