[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15919 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. [C++ client] doxygenized C++ client API in columnar_scan_batch.h This patch documents the missing parameters for APIs in columnar_scan_batch.h to satisfy the warnings from doxygen. Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08 Reviewed-on: http://gerrit.cloudera.org:8080/15918 Reviewed-by: Grant Henke Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin (cherry picked from commit 7d1f3fbb40984b6917e6e76f252bf6a0924fd70d) Reviewed-on: http://gerrit.cloudera.org:8080/15919 --- M src/kudu/client/columnar_scan_batch.h 1 file changed, 28 insertions(+), 13 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08 Gerrit-Change-Number: 15919 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15919 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08 Gerrit-Change-Number: 15919 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 May 2020 23:18:09 + Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15919 Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. [C++ client] doxygenized C++ client API in columnar_scan_batch.h This patch documents the missing parameters for APIs in columnar_scan_batch.h to satisfy the warnings from doxygen. Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08 Reviewed-on: http://gerrit.cloudera.org:8080/15918 Reviewed-by: Grant Henke Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin (cherry picked from commit 7d1f3fbb40984b6917e6e76f252bf6a0924fd70d) --- M src/kudu/client/columnar_scan_batch.h 1 file changed, 28 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/15919/1 -- To view, visit http://gerrit.cloudera.org:8080/15919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08 Gerrit-Change-Number: 15919 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao