[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6863 to review the following change. Change subject: [util] updated output from TryRunLsof() .. [util] updated output from TryRunLsof() TryRunLsof() should not conclude it's called because of an error binding to the specified address: in some use-cases it might not be the case. The output is updated to remove the statement about a failure to bind to the specified address, leaving just the output from lsof. This is a pure cosmetic fix to improve error message readability in the context of KUDU-2005. Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Reviewed-on: http://gerrit.cloudera.org:8080/6852 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins (cherry picked from commit ae7cfa04a64e8f9a494db36c4f20e11cea311845) --- M src/kudu/util/net/net_util.cc 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/6863/1 -- To view, visit http://gerrit.cloudera.org:8080/6863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6863 to look at the new patch set (#2). Change subject: [util] updated output from TryRunLsof() .. [util] updated output from TryRunLsof() TryRunLsof() should not conclude it's called because of an error binding to the specified address: in some use-cases it might not be the case. The output is updated to remove the statement about a failure to bind to the specified address, leaving just the output from lsof. This is a pure cosmetic fix to improve error message readability in the context of KUDU-2005. Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Reviewed-on: http://gerrit.cloudera.org:8080/6852 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins (cherry picked from commit ae7cfa04a64e8f9a494db36c4f20e11cea311845) --- M src/kudu/util/net/net_util.cc 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/6863/2 -- To view, visit http://gerrit.cloudera.org:8080/6863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()
Todd Lipcon has posted comments on this change. Change subject: [util] updated output from TryRunLsof() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()
Alexey Serbin has submitted this change and it was merged. Change subject: [util] updated output from TryRunLsof() .. [util] updated output from TryRunLsof() TryRunLsof() should not conclude it's called because of an error binding to the specified address: in some use-cases it might not be the case. The output is updated to remove the statement about a failure to bind to the specified address, leaving just the output from lsof. This is a pure cosmetic fix to improve error message readability in the context of KUDU-2005. Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Reviewed-on: http://gerrit.cloudera.org:8080/6852 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins (cherry picked from commit ae7cfa04a64e8f9a494db36c4f20e11cea311845) Reviewed-on: http://gerrit.cloudera.org:8080/6863 Reviewed-by: Todd Lipcon --- M src/kudu/util/net/net_util.cc 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
