[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver
Hello Will Berkeley, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6861 to review the following change. Change subject: KUDU-2005: actionable error messages from webserver .. KUDU-2005: actionable error messages from webserver As it turned out, squeasel outputs only errors via the log_message callback. Let's output them with ERROR severity into Kudu log (they were output as INFO messages prior to this patch). Also, if the embedded squeasel webserver fails to start, add the last error message from it (if any) into the RuntimeError status message returned from Webserver::Start(). Change-Id: Ia2315f7ee88c8835a36e5174cb25132967429a77 Reviewed-on: http://gerrit.cloudera.org:8080/6848 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley (cherry picked from commit 83885a47a77a7206414987d07d5945525e66) --- M src/kudu/server/webserver-test.cc M src/kudu/server/webserver.cc M src/kudu/server/webserver.h 3 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/6861/1 -- To view, visit http://gerrit.cloudera.org:8080/6861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2315f7ee88c8835a36e5174cb25132967429a77 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2005: actionable error messages from webserver .. KUDU-2005: actionable error messages from webserver As it turned out, squeasel outputs only errors via the log_message callback. Let's output them with ERROR severity into Kudu log (they were output as INFO messages prior to this patch). Also, if the embedded squeasel webserver fails to start, add the last error message from it (if any) into the RuntimeError status message returned from Webserver::Start(). Change-Id: Ia2315f7ee88c8835a36e5174cb25132967429a77 Reviewed-on: http://gerrit.cloudera.org:8080/6848 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley (cherry picked from commit 83885a47a77a7206414987d07d5945525e66) Reviewed-on: http://gerrit.cloudera.org:8080/6861 --- M src/kudu/server/webserver-test.cc M src/kudu/server/webserver.cc M src/kudu/server/webserver.h 3 files changed, 25 insertions(+), 6 deletions(-) Approvals: Will Berkeley: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2315f7ee88c8835a36e5174cb25132967429a77 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver
Will Berkeley has posted comments on this change. Change subject: KUDU-2005: actionable error messages from webserver .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2315f7ee88c8835a36e5174cb25132967429a77 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
