[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15918 )

Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..

[C++ client] doxygenized C++ client API in columnar_scan_batch.h

This patch documents the missing parameters for APIs in columnar_scan_batch.h
to satisfy the warnings from doxygen.

Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Reviewed-on: http://gerrit.cloudera.org:8080/15918
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/client/columnar_scan_batch.h
1 file changed, 28 insertions(+), 13 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15918 )

Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 14 May 2020 23:15:17 +
Gerrit-HasComments: No


[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15918 )

Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 14 May 2020 22:49:31 +
Gerrit-HasComments: No


[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15918


Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..

[C++ client] doxygenized C++ client API in columnar_scan_batch.h

This patch documents the missing parameters for APIs in columnar_scan_batch.h
to satisfy the warnings from doxygen.

Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
---
M src/kudu/client/columnar_scan_batch.h
1 file changed, 28 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/15918/1
--
To view, visit http://gerrit.cloudera.org:8080/15918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao