[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 02:59:37 + Gerrit-HasComments: No
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has removed a vote on this change. Change subject: [DOCS] Fixed a link in non-covering partition doc .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. [DOCS] Fixed a link in non-covering partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Reviewed-on: http://gerrit.cloudera.org:8080/10891 Reviewed-by: Alexey Serbin Reviewed-by: Andrew Wong Tested-by: Andrew Wong --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 02:45:34 + Gerrit-HasComments: No
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10891 to look at the new patch set (#3). Change subject: [DOCS] Fixed a link in non-covering partition doc .. [DOCS] Fixed a link in non-covering partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/10891/3 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc@469 PS2, Line 469: in > nit: I'm not sure, but to my taste it sounds better if replacing 'in' with Done -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 02:29:22 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc@469 PS2, Line 469: in nit: I'm not sure, but to my taste it sounds better if replacing 'in' with 'if using'/'when using'/'of'. But take it with a grain of salt since I'm not a native speaker. -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 01:57:22 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 09 Jul 2018 23:43:48 + Gerrit-HasComments: No
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10891/1//COMMIT_MSG@7 PS1, Line 7: coverting > nit: covering Done -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 09 Jul 2018 23:38:30 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10891 to look at the new patch set (#2). Change subject: [DOCS] Fixed a link in non-covering partition doc .. [DOCS] Fixed a link in non-covering partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/10891/2 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy