[kudu-CR] [backup] Ensure the last metadata is restored
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. [backup] Ensure the last metadata is restored When creating a table, ensure the last metadata is restored instead of the first. This is the first step to allow table alterations. Follow on patches will take care of metadata validation and alteration handling. Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Reviewed-on: http://gerrit.cloudera.org:8080/13132 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo Reviewed-by: Mike Percy --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 2 files changed, 11 insertions(+), 4 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, but someone else must approve Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR] [backup] Ensure the last metadata is restored
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 01 May 2019 21:35:20 + Gerrit-HasComments: No
[kudu-CR] [backup] Ensure the last metadata is restored
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: This is true, but the functionality is more correct. I broke it out so I could work on POCing multiple things that need it at the same time. The column alterations patch that is up uses it. Do you mind leaving it as is? -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 30 Apr 2019 00:41:37 + Gerrit-HasComments: No
[kudu-CR] [backup] Ensure the last metadata is restored
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 29 Apr 2019 22:18:51 + Gerrit-HasComments: No
[kudu-CR] [backup] Ensure the last metadata is restored
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: The logic looks OK to me, but AFAICT the test will pass with or without the patch so I wonder if this CR makes sense as a standalone patch. Maybe it should be merged into something that needs it. However if you want to keep it separate because it's easier to organize your follow-on work then that's fine. -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 29 Apr 2019 22:13:32 + Gerrit-HasComments: No
[kudu-CR] [backup] Ensure the last metadata is restored
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@9 PS1, Line 9: metdata > metadata Done http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@12 PS1, Line 12: metdata > metadata Done http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@12 PS1, Line 12: This is the first step to allow table alterations. Follow on patches will take care of metdata validation and alteration > Wrapping got weird here. Done -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 29 Apr 2019 14:18:26 + Gerrit-HasComments: Yes
[kudu-CR] [backup] Ensure the last metadata is restored
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13132 to look at the new patch set (#2). Change subject: [backup] Ensure the last metadata is restored .. [backup] Ensure the last metadata is restored When creating a table, ensure the last metadata is restored instead of the first. This is the first step to allow table alterations. Follow on patches will take care of metadata validation and alteration handling. Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 2 files changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13132/2 -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR] [backup] Ensure the last metadata is restored
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@9 PS1, Line 9: metdata metadata http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@12 PS1, Line 12: metdata metadata http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@12 PS1, Line 12: This is the first step to allow table alterations. Follow on patches will take care of metdata validation and alteration Wrapping got weird here. -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 26 Apr 2019 21:29:01 + Gerrit-HasComments: Yes
[kudu-CR] [backup] Ensure the last metadata is restored
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13132 Change subject: [backup] Ensure the last metadata is restored .. [backup] Ensure the last metadata is restored When creating a table, ensure the last metdata is restored instead of the first. This is the first step to allow table alterations. Follow on patches will take care of metdata validation and alteration handling. Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 2 files changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13132/1 -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
