[kudu-CR] [build] Fix codegen build on MacOS Monterey
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18461/3/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18461/3/src/kudu/codegen/CMakeLists.txt@72 PS3, Line 72: CMAKE_OSX_SYSROOT > With this change now the compilation is broken on my macOS laptop More information from my laptop, just in case it helps to narrow down the issue: -- Using CMAKE_OSX_SYSROOT: /Applications/Xcode.12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk tents/Developer/Platforms/MacOSX.platform/Developer/SDKs total 0 drwxr-xr-x 5 root wheel 160 Feb 28 2021 . drwxr-xr-x 6 root wheel 192 Jan 8 2021 .. drwxr-xr-x 5 root wheel 160 Nov 30 2020 DriverKit20.2.sdk drwxr-xr-x 7 root wheel 224 Nov 30 2020 MacOSX.sdk lrwxr-xr-x 1 root wheel 10 Feb 28 2021 MacOSX11.1.sdk -> MacOSX.sdk And indeed, there isn't cstdint file in there: MacBook-Pro:codegen[attila-sysroot-fix]$ find /Applications/Xcode.12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -iname cstdint MacBook-Pro:codegen[attila-sysroot-fix]$ -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Mon, 02 May 2022 20:39:05 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18461/3/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18461/3/src/kudu/codegen/CMakeLists.txt@72 PS3, Line 72: CMAKE_OSX_SYSROOT With this change now the compilation is broken on my macOS laptop src/kudu/codegen/precompiled.cc:36:10: fatal error: 'cstdint' file not found #include ^ Maybe, I missed something in the process of installing Xcode? -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Mon, 02 May 2022 19:16:38 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18461/2//COMMIT_MSG Commit Message: PS2: > Does it make sense to rebase this patch on top of current HEAD of the maste Yep, good idea, thanks. -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Mon, 02 May 2022 16:39:33 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18461/2//COMMIT_MSG Commit Message: PS2: Does it make sense to rebase this patch on top of current HEAD of the master branch (i.e. before upgrading glog to 0.6.0)? -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 16:50:15 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 1: Could someone double check if this works on older Macs too? -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 12:16:54 + Gerrit-HasComments: No
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Hello Zoltan Chovan, Alexey Serbin, Andrew Wong, Khazar Mammadli, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/18461 to review the following change. Change subject: [build] Fix codegen build on MacOS Monterey .. [build] Fix codegen build on MacOS Monterey 0e2c28864c27727c9723db7f319a5d7ebcbeead7 changed -cxx-isystem to /Library/Developer/CommandLineTools/usr/include/c++/v1 when building codegen on MacOS, which no longer seems to work on MacOS Monterey. This commit changes this to CMAKE_OSX_SYSROOT, which CMake sets to the SDK location, and should work across MacOS versions. Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/18461/1 -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Zoltan Chovan
