[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged.

Change subject: [build] disable tcmalloc for OS X builds
..


[build] disable tcmalloc for OS X builds

As a workaround for KUDU-1998, tcmalloc is disabled for OS X builds.

Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Reviewed-on: http://gerrit.cloudera.org:8080/6821
Reviewed-by: Will Berkeley 
Reviewed-by: Adar Dembo 
Tested-by: Alexey Serbin 
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Will Berkeley: Looks good to me, but someone else must approve
  Alexey Serbin: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: [build] disable tcmalloc for OS X builds
..


Patch Set 1: Verified+1

Unrelated flake of MasterStressTest

-- 
To view, visit http://gerrit.cloudera.org:8080/6821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: [build] disable tcmalloc for OS X builds
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6821/1/CMakeLists.txt
File CMakeLists.txt:

Line 892: ## As a workaround for KUDU-1998, tcmalloc is disabled in OS X builds.
> That's quite the hammer.
Nevermind, Todd doesn't have anything in the works, and a potential switch to 
jemalloc (possibly the best approach) isn't happening right now.


-- 
To view, visit http://gerrit.cloudera.org:8080/6821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change.

Change subject: [build] disable tcmalloc for OS X builds
..


Patch Set 1: Code-Review+1

Checked on my OS X machine that this fixes the problem.

-- 
To view, visit http://gerrit.cloudera.org:8080/6821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: [build] disable tcmalloc for OS X builds
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6821/1/CMakeLists.txt
File CMakeLists.txt:

Line 892: ## As a workaround for KUDU-1998, tcmalloc is disabled in OS X builds.
That's quite the hammer.

Can you sync with Todd about this? He may already have a patch in the works to 
fix this more delicately. If not, I think he can give you some pointers on 
other approaches.


-- 
To view, visit http://gerrit.cloudera.org:8080/6821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6821

Change subject: [build] disable tcmalloc for OS X builds
..

[build] disable tcmalloc for OS X builds

As a workaround for KUDU-1998, tcmalloc is disabled for OS X builds.

Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/6821/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin