[kudu-CR] [consensus] fix on RequestForPeer clean-up

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9487 )

Change subject: [consensus] fix on RequestForPeer clean-up
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Gerrit-Change-Number: 9487
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:55:21 +
Gerrit-HasComments: No

[kudu-CR] [consensus] fix on RequestForPeer clean-up

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9487 )

Change subject: [consensus] fix on RequestForPeer clean-up
..

[consensus] fix on RequestForPeer clean-up

The consensus queue can switch to the non-leader mode when exiting
from the RequestForPeer() method scope, so it's necessary to check
for that condition in the scoped clean-up object before updating
information on the peer's health.

The issue was found while running the raft_consensus_stress-itest
for the 3-2-3 re-replication scheme, so I don't think any additional
test is needed to cover this change.

Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Reviewed-on: http://gerrit.cloudera.org:8080/9487
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mike Percy: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Gerrit-Change-Number: 9487
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [consensus] fix on RequestForPeer clean-up

[Alexey Serbin (Code Review)]

Hello Mike Percy, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9487

to look at the new patch set (#2).

Change subject: [consensus] fix on RequestForPeer clean-up
..

[consensus] fix on RequestForPeer clean-up

The consensus queue can switch to the non-leader mode when exiting
from the RequestForPeer() method scope, so it's necessary to check
for that condition in the scoped clean-up object before updating
information on the peer's health.

The issue was found while running the raft_consensus_stress-itest
for the 3-2-3 re-replication scheme, so I don't think any additional
test is needed to cover this change.

Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/9487/2
--
To view, visit http://gerrit.cloudera.org:8080/9487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Gerrit-Change-Number: 9487
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [consensus] fix on RequestForPeer clean-up

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9487 )

Change subject: [consensus] fix on RequestForPeer clean-up
..


Patch Set 1: Verified+1

Unrelated flake in org.apache.kudu.spark.kudu.KuduContextTest


--
To view, visit http://gerrit.cloudera.org:8080/9487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Gerrit-Change-Number: 9487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 05 Mar 2018 00:04:45 +
Gerrit-HasComments: No

[kudu-CR] [consensus] fix on RequestForPeer clean-up

[Alexey Serbin (Code Review)]

Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/9487 )

Change subject: [consensus] fix on RequestForPeer clean-up
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Gerrit-Change-Number: 9487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [consensus] fix on RequestForPeer clean-up

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9487


Change subject: [consensus] fix on RequestForPeer clean-up
..

[consensus] fix on RequestForPeer clean-up

The consensus queue can switch to the non-leader mode when exiting
from the RequestForPeer() method scope, so it's necessary to check
for that condition in the scoped clean-up object before updating
information on the peer's health.

The issue was found while running the raft_consensus_stress-itest
for the 3-2-3 re-replication scheme, so I don't think any additional
test is needed to cover this change.

Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/9487/1
--
To view, visit http://gerrit.cloudera.org:8080/9487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71b3b47bbf9b5011bd11534287f6ae8f760addd5
Gerrit-Change-Number: 9487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin