[kudu-CR] [examples] Make java-example up-to-date
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19418 ) Change subject: [examples] Make java-example up-to-date .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/19418/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19418/2//COMMIT_MSG@11 PS2, Line 11: Osx nit: since some 10.x version they started officially calling it macOS $ sw_vers ProductName:macOS ProductVersion: 11.7 BuildVersion: 20G817 http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc File examples/java/java-example/README.adoc: http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@39 PS2, Line 39: This means that the exact version and architecture jar file can not : be found in the maven repo It means the maven repository does not contain a JAR file with the exact architecture and version. http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@40 PS2, Line 40: be worked around by I guess here the essence of the workaround should be outlined, i.e. building the required JAR locally and running with local the local repository? The required practical steps could be presented right below in a form of bulleted/numbered list or something like that, but having them in a sentence, separated by commas is also OK. http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@41 PS2, Line 41: dir directory http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@41 PS2, Line 41: set setting http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/pom.xml File examples/java/java-example/pom.xml: http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/pom.xml@31 PS2, Line 31: 1.16.0 nit: you could separate this into its own changelist since the up-to-date version in the examples and arch-related workaround for Apple M1 chips are orthogonal. -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Wed, 18 Jan 2023 04:56:05 + Gerrit-HasComments: Yes
[kudu-CR] [examples] Make java-example up-to-date
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19418 ) Change subject: [examples] Make java-example up-to-date .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc File examples/java/java-example/README.adoc: http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@39 PS2, Line 39: error occurs. This means that the exact version and architecture jar file can not nit: maybe specifically call out aarch64 in parentheses? -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 17 Jan 2023 17:40:14 + Gerrit-HasComments: Yes
[kudu-CR] [examples] Make java-example up-to-date
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19418 to look at the new patch set (#2). Change subject: [examples] Make java-example up-to-date .. [examples] Make java-example up-to-date The latest version of kudu-binary on maven is 1.16.0 [1], so pom.xml is updated to that version. Besides that, kudu-binary is only built for Linux-x86_64 and Osx-x86_64 at the moment, which means it doesn't work out of the box for Mac ARM64 users. A short workaround was added to make the example work for those users, too. This is a possible workaround for KUDU-3431. 1. https://repo1.maven.org/maven2/org/apache/kudu/kudu-binary/1.16.0/ Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 --- M examples/java/java-example/README.adoc M examples/java/java-example/pom.xml 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/19418/2 -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai
[kudu-CR] [examples] Make java-example up-to-date
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19418 ) Change subject: [examples] Make java-example up-to-date .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19418/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19418/1//COMMIT_MSG@12 PS1, Line 12: A short workaround > Probably, you want to mention https://issues.apache.org/jira/browse/KUDU-34 Thank you. It's not intended for that issue, but it definitely has some overlap. -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Mon, 16 Jan 2023 14:02:52 + Gerrit-HasComments: Yes
[kudu-CR] [examples] Make java-example up-to-date
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19418 ) Change subject: [examples] Make java-example up-to-date .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19418/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19418/1//COMMIT_MSG@12 PS1, Line 12: A short workaround Probably, you want to mention https://issues.apache.org/jira/browse/KUDU-3431 since this looks relevant for the issue that the workaround is intended for? Also, you might update that JIRA to mention there is a workaround for the issue, so people might be unblocked in using kudu-binary packages for development on M1 chip macs. http://gerrit.cloudera.org:8080/#/c/19418/1//COMMIT_MSG@13 PS1, Line 13: the example work for those users,too. nit: add a space after the comma -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Jan 2023 22:04:48 + Gerrit-HasComments: Yes
[kudu-CR] [examples] Make java-example up-to-date
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19418 Change subject: [examples] Make java-example up-to-date .. [examples] Make java-example up-to-date The latest version of kudu-binary on maven is 1.16.0 [1], so pom.xml is updated to that version. Besides that, kudu-binary is only built for Linux-x86_64 and Osx-x86_64 at the moment, which means it doesn't work out of the box for Mac ARM64 users. A short workaround was added to make the example work for those users,too. 1. https://repo1.maven.org/maven2/org/apache/kudu/kudu-binary/1.16.0/ Change-Id: Ibb109ede46b81aabe1defa118af3a421f284cbdb Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 --- M examples/java/java-example/README.adoc M examples/java/java-example/pom.xml 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/19418/1 -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai