[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs] Simplify the data directory inheritance hierarchy This patch doesn't introduce functional changes, but only simplify the inheritance hierarchy of class Dir to reduce the complex when extend the Dir class, for example, when adding a sub-class of Dir to contain a RocksDB instance, see http://gerrit.cloudera.org:8080/18569. Because there are not sufficient reasons, so the DataDir sub-class is removed and the implementation functions are moved to the super class Dir. Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Reviewed-on: http://gerrit.cloudera.org:8080/20833 Tested-by: Yingchun Lai Reviewed-by: Ádám Bakai Reviewed-by: Yifan Zhang --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/data_dirs.h M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/fs_manager.h 5 files changed, 19 insertions(+), 38 deletions(-) Approvals: Yingchun Lai: Verified Ádám Bakai: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Ádám Bakai
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Fri, 05 Jan 2024 02:16:36 + Gerrit-HasComments: No
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 02 Jan 2024 11:29:58 + Gerrit-HasComments: No
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 02 Jan 2024 09:18:20 + Gerrit-HasComments: No
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20833/3/src/kudu/fs/dir_manager.h File src/kudu/fs/dir_manager.h: http://gerrit.cloudera.org:8080/#/c/20833/3/src/kudu/fs/dir_manager.h@156 PS3, Line 156: available_space_cache_secs How about implementing this function here, just like available_bytes()? As this function is so much simple. -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Wed, 27 Dec 2023 02:11:45 + Gerrit-HasComments: Yes
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Verified+1 Remove un-related failed test ConcurrentRebalancersTest.TwoConcurrentRebalancers/1. -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 26 Dec 2023 03:19:18 + Gerrit-HasComments: No
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Yingchun Lai has removed a vote on this change. Change subject: [fs] Simplify the data directory inheritance hierarchy .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20833 to look at the new patch set (#3). Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs] Simplify the data directory inheritance hierarchy This patch doesn't introduce functional changes, but only simplify the inheritance hierarchy of class Dir to reduce the complex when extend the Dir class, for example, when adding a sub-class of Dir to contain a RocksDB instance, see http://gerrit.cloudera.org:8080/18569. Because there are not sufficient reasons, so the DataDir sub-class is removed and the implementation functions are moved to the super class Dir. Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/data_dirs.h M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/fs_manager.h 5 files changed, 19 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/20833/3 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Simplify the data directory inheritance hierarchy
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20833 to look at the new patch set (#2). Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs] Simplify the data directory inheritance hierarchy This patch doesn't introduce functional changes, but only simplify the inheritance hierarchy of class Dir to reduce the complex when extend the Dir class, for example, when adding a sub-class of Dir to contain a RocksDB instance, see http://gerrit.cloudera.org:8080/18569. Because there are not sufficient reasons, so the DataDir sub-class is removed and the implementation functions are moved to the super class Dir. Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/data_dirs.h M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/fs_manager.h 5 files changed, 19 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/20833/2 -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120)
