[kudu-CR] [gradle] Add rerunTests property
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. [gradle] Add rerunTests property Gradle keeps track of changes and will skip tasks that are up-to-date when possible. This is great for incremental build speed, but can work against you if you want to rerun tests multiple times. Gradle does have a —rerun-tasks flag that will make sure the tests are run. However, it will also rerun all the tasks in the build tree. This patch adds a rerunTests property that will tell gradle the tests need to be rerun when passed. Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Reviewed-on: http://gerrit.cloudera.org:8080/11035 Reviewed-by: Adar Dembo Tested-by: Grant Henke --- M java/gradle/tests.gradle 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Grant Henke: Verified -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Gerrit-Change-Number: 11035 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [gradle] Add rerunTests property
Grant Henke has removed a vote on this change. Change subject: [gradle] Add rerunTests property .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Gerrit-Change-Number: 11035 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [gradle] Add rerunTests property
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Gerrit-Change-Number: 11035 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 21:36:54 + Gerrit-HasComments: No
[kudu-CR] [gradle] Add rerunTests property
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. Patch Set 1: This is slightly different. Maybe I need a better name for the property. I am working on reproducing the flaky test locally, when I run `gradle test` if I have already run the tests gradle will do nothing and say the task is up-to-date. With this it will just rerun test test task without rerunning everything else (like it would if I used --rerun-tasks). -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Gerrit-Change-Number: 11035 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 18:21:31 + Gerrit-HasComments: No
[kudu-CR] [gradle] Add rerunTests property
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. Patch Set 1: (1 comment) So I had a sneaking suspicion that Java test retrying might be broken due to the sheer number of Java flakes that have cropped up in recent pre-commit builds (and not just the backup-related ones). Does this address that? I don't think it does: rerunTests needs to be explicitly set on the command line, and it isn't right now, right? http://gerrit.cloudera.org:8080/#/c/11035/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11035/1//COMMIT_MSG@9 PS1, Line 9: [gradle] Add rerunTests property Duplicate -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Gerrit-Change-Number: 11035 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 18:17:30 + Gerrit-HasComments: Yes
[kudu-CR] [gradle] Add rerunTests property
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11035 Change subject: [gradle] Add rerunTests property .. [gradle] Add rerunTests property [gradle] Add rerunTests property Gradle keeps track of changes and will skip tasks that are up-to-date when possible. This is great for incremental build speed, but can work against you if you want to rerun tests multiple times. Gradle does have a —rerun-tasks flag that will make sure the tests are run. However, it will also rerun all the tasks in the build tree. This patch adds a rerunTests property that will tell gradle the tests need to be rerun when passed. Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c --- M java/gradle/tests.gradle 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/11035/1 -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I88eebdc34c5b9763b87879eade3dc9b42d3caf1c Gerrit-Change-Number: 11035 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
