[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode

2018-01-05 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8837 )

Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
..


Patch Set 3:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@9
PS3, Line 9: propagate
nit: propagated


http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: cliemt
typo


http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: for
nit: the java


http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: it
nit: "this" or "timestamp propagation for this mode"


http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@11
PS3, Line 11: propagate
nit:propagated


http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:

http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS3, Line 534: propagated the
the propagated


http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:

http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS3, Line 92: single
single client?


http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@141
PS3, Line 141: client.getLastPropagatedTimestamp()
do we have a client.hasLastPropagatedTimestamp() that does this internally? if 
not could we add it?



--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 22:11:54 +
Gerrit-HasComments: Yes

[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode

2018-01-05 Thread Hao Hao (Code Review) 
Hello David Ribeiro Alves, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8837

to look at the new patch set (#3).

Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
..

[java client] update propagate TS for AUTO_FLUSH_SYNC flush mode

Commit be6b81057 updated propagate timestamp for all write modes except
AUTO_FLUSH_SYNC for java cliemt. This patch adds it and updates
TestHybridTime to ensure propagate timestamp is updated for all flush
modes.

Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
3 files changed, 28 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8837/3
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode

2018-01-05 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8837 )

Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:

http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS2, Line 534:   // Add a callback to update propagated timestamp returned 
from server.
> nit: missing "the"
Done


http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:

http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS2, Line 92: single operations
> operation?
Done



--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 21:39:05 +
Gerrit-HasComments: Yes