[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18428 ) Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG@7 PS6, Line 7: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc nit:How about "[master_log] Correction for the value of `table_rows_limit`" http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc@3649 PS6, Line 3649: FLAGS_table_write_limit_ratio nit: How about adding this flag to the log? Seems it's not always 1, just in case we need this info to find out why write ops are rejected. -- To view, visit http://gerrit.cloudera.org:8080/18428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa Gerrit-Change-Number: 18428 Gerrit-PatchSet: 6 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 29 Apr 2022 11:54:42 + Gerrit-HasComments: Yes
[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18428 to look at the new patch set (#5). Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc .. [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc Fix a variable table_rows_limit, it used by a log in master, it maybe not correct before. The variable table_rows_limit, when table_disk_size_limit and table_row_count_limit all setted, and has reached the table_disk_size_limit, variable table_rows_limit is -1(default) before. Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa --- M src/kudu/master/catalog_manager.cc 1 file changed, 5 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/5 -- To view, visit http://gerrit.cloudera.org:8080/18428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa Gerrit-Change-Number: 18428 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18428 to look at the new patch set (#3). Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc .. [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc Fix a variable table_rows_limit, it used by a log in master, it maybe not correct before. The variable table_rows_limit, when table_disk_size_limit and table_row_count_limit all setted, and has reached the table_disk_size_limit, variable table_rows_limit is -1(default) before. Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa --- M src/kudu/master/catalog_manager.cc 1 file changed, 5 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/3 -- To view, visit http://gerrit.cloudera.org:8080/18428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa Gerrit-Change-Number: 18428 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Kudu Jenkins (120)
