[kudu-CR] [python] Ignore pytest cache and environment files
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9491 ) Change subject: [python] Ignore pytest cache and environment files .. [python] Ignore pytest cache and environment files Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Reviewed-on: http://gerrit.cloudera.org:8080/9491 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M python/.gitignore 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] Ignore pytest cache and environment files
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9491 ) Change subject: [python] Ignore pytest cache and environment files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore File python/.gitignore: http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@31 PS1, Line 31: .pytest_cache/ > Interesting. Are you using Python 3? I am testing with both python2 and python3. It looks like both generate this. Perhaps it's a difference pytest version. -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 18:09:48 + Gerrit-HasComments: Yes
[kudu-CR] [python] Ignore pytest cache and environment files
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9491 ) Change subject: [python] Ignore pytest cache and environment files .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore File python/.gitignore: http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@31 PS1, Line 31: .pytest_cache/ > I ran `python setup.py test` and this was generated. It could definitely be Interesting. Are you using Python 3? http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@49 PS1, Line 49: # Environments > When working with PyCharm (the Jetbrains IDE) the venv directory can be cre Makes sense, thanks. -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 17:53:54 + Gerrit-HasComments: Yes
[kudu-CR] [python] Ignore pytest cache and environment files
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9491 ) Change subject: [python] Ignore pytest cache and environment files .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore File python/.gitignore: http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@31 PS1, Line 31: .pytest_cache/ > What tool generates these? Can't say I've seen them when I tested Python ch I ran `python setup.py test` and this was generated. It could definitely be a situation where I am doing something in a "non standard" way. I am far from a python expert and it doesn't look like we have any development oriented docs around building and testing the python client. I will look to add some, but will need so review from someone more educated on python than me. http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@49 PS1, Line 49: # Environments > Hmm, how do these get created? In my experience, you run "virtualenv foo" a When working with PyCharm (the Jetbrains IDE) the venv directory can be created. However I pulled in the others from githubs gitignore project, expecting it wasn't totally standard. (https://github.com/github/gitignore/blob/master/Python.gitignore) -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 17:47:23 + Gerrit-HasComments: Yes
[kudu-CR] [python] Ignore pytest cache and environment files
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9491 ) Change subject: [python] Ignore pytest cache and environment files .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore File python/.gitignore: http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@31 PS1, Line 31: .pytest_cache/ What tool generates these? Can't say I've seen them when I tested Python changes locally. http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@49 PS1, Line 49: # Environments Hmm, how do these get created? In my experience, you run "virtualenv foo" and "foo" is the virtualenv directory, so there's no standard name. Are these standard names for some other tool? -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 17:36:51 + Gerrit-HasComments: Yes
[kudu-CR] [python] Ignore pytest cache and environment files
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9491 Change subject: [python] Ignore pytest cache and environment files .. [python] Ignore pytest cache and environment files Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d --- M python/.gitignore 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9491/1 -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke