[kudu-CR] [security] handle a few unexpected authn token conditions
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18271 ) Change subject: [security] handle a few unexpected authn token conditions .. [security] handle a few unexpected authn token conditions This patch addresses a few unexpected error conditions in the server-side negotiation code when authenticating a client with its authn token. I didn't add any tests since there is no mock for the corresponding client side and implementing it from scratch just to verify these two simple cases looked like an overkill. Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Reviewed-on: http://gerrit.cloudera.org:8080/18271 Tested-by: Alexey Serbin Reviewed-by: Attila Bukor Reviewed-by: Andrew Wong --- M src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 8 deletions(-) Approvals: Alexey Serbin: Verified Attila Bukor: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Gerrit-Change-Number: 18271 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] handle a few unexpected authn token conditions
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18271 ) Change subject: [security] handle a few unexpected authn token conditions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Gerrit-Change-Number: 18271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Feb 2022 22:10:43 + Gerrit-HasComments: No
[kudu-CR] [security] handle a few unexpected authn token conditions
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18271 ) Change subject: [security] handle a few unexpected authn token conditions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Gerrit-Change-Number: 18271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Feb 2022 13:31:07 + Gerrit-HasComments: No
[kudu-CR] [security] handle a few unexpected authn token conditions
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18271 ) Change subject: [security] handle a few unexpected authn token conditions .. Patch Set 1: Verified+1 unrelated test failures in TabletHistoryGcITest.TestSnapshotScanBeforeAHM and ClientTest.ClearCacheAndConcurrentWorkload -- To view, visit http://gerrit.cloudera.org:8080/18271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Gerrit-Change-Number: 18271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 24 Feb 2022 15:51:55 + Gerrit-HasComments: No
[kudu-CR] [security] handle a few unexpected authn token conditions
Alexey Serbin has removed a vote on this change. Change subject: [security] handle a few unexpected authn token conditions .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Gerrit-Change-Number: 18271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] handle a few unexpected authn token conditions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18271 Change subject: [security] handle a few unexpected authn token conditions .. [security] handle a few unexpected authn token conditions This patch addresses a few unexpected error conditions in the server-side negotiation code when authenticating a client with its authn token. I didn't add any tests since there is no mock for the corresponding client side and implementing it from scratch just to verify these two simple cases looked like an overkill. Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 --- M src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18271/1 -- To view, visit http://gerrit.cloudera.org:8080/18271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901 Gerrit-Change-Number: 18271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
