[kudu-CR] [test][master] KUDU-3249 Recover dead master at the same HostPort

2021-03-15 Thread Bankim Bhavsar (Code Review) 
Bankim Bhavsar has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/17126 )

Change subject: [test][master] KUDU-3249 Recover dead master at the same 
HostPort
..

[test][master] KUDU-3249 Recover dead master at the same HostPort

This change uses the Add/Remove master primitives added
earlier to simulate recovery for a dead master at the same HostPort
but different uuid.

Test only code change but involves bunch of refactoring to re-use
parts of existing test.

Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Reviewed-on: http://gerrit.cloudera.org:8080/17126
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong 
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 328 insertions(+), 163 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/17126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Gerrit-Change-Number: 17126
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [test][master] KUDU-3249 Recover dead master at the same HostPort

2021-03-12 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17126 )

Change subject: [test][master] KUDU-3249 Recover dead master at the same 
HostPort
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/17126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Gerrit-Change-Number: 17126
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Mar 2021 19:21:54 +
Gerrit-HasComments: No

[kudu-CR] [test][master] KUDU-3249 Recover dead master at the same HostPort

2021-03-10 Thread Bankim Bhavsar (Code Review) 
Hello Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/17126

to look at the new patch set (#2).

Change subject: [test][master] KUDU-3249 Recover dead master at the same 
HostPort
..

[test][master] KUDU-3249 Recover dead master at the same HostPort

This change uses the Add/Remove master primitives added
earlier to simulate recovery for a dead master at the same HostPort
but different uuid.

Test only code change but involves bunch of refactoring to re-use
parts of existing test.

Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 328 insertions(+), 163 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/17126/2
--
To view, visit http://gerrit.cloudera.org:8080/17126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Gerrit-Change-Number: 17126
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [test][master] KUDU-3249 Recover dead master at the same HostPort

2021-03-10 Thread Bankim Bhavsar (Code Review) 
Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17126 )

Change subject: [test][master] KUDU-3249 Recover dead master at the same 
HostPort
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc
File src/kudu/master/dynamic_multi_master-test.cc:

http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@643
PS1, Line 643: ASSERT_OK(CreateTable(cluster_.get(), kTableName));
> nit: this was surprising to see. Is it supposed to be here? It's not mentio
Done


http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@662
PS1, Line 662: Before removing the master set the output parameters as the 
master being removed
 : // will not be tracked by ExternalMiniCluster.
> nit: these values don't change though, so what's the importance of setting
Applies only to src_master_hp. Moving the comment there.


http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@701
PS1, Line 701: consensus::
> nit: given how frequently this is used, add a "using" declaration
Done


http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@1079
PS1, Line 1079: Please follow the next steps which includes system catalog "
  :  "tablet copy"
> nit: missing a $0 somewhere?
good catch!



--
To view, visit http://gerrit.cloudera.org:8080/17126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Gerrit-Change-Number: 17126
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Mar 2021 02:55:21 +
Gerrit-HasComments: Yes

[kudu-CR] [test][master] KUDU-3249 Recover dead master at the same HostPort

2021-03-02 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17126 )

Change subject: [test][master] KUDU-3249 Recover dead master at the same 
HostPort
..


Patch Set 1: Code-Review+1

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc
File src/kudu/master/dynamic_multi_master-test.cc:

http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@643
PS1, Line 643: ASSERT_OK(CreateTable(cluster_.get(), kTableName));
nit: this was surprising to see. Is it supposed to be here? It's not mentioned 
in the method comment, and there's no other context comment nearby explaining 
why it's important.

Also, consider putting it in the tests themselves rather in this helper method.


http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@662
PS1, Line 662: Before removing the master set the output parameters as the 
master being removed
 : // will not be tracked by ExternalMiniCluster.
nit: these values don't change though, so what's the importance of setting them 
here?


http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@701
PS1, Line 701: consensus::
nit: given how frequently this is used, add a "using" declaration


http://gerrit.cloudera.org:8080/#/c/17126/1/src/kudu/master/dynamic_multi_master-test.cc@1079
PS1, Line 1079: Please follow the next steps which includes system catalog "
  :  "tablet copy"
nit: missing a $0 somewhere?



--
To view, visit http://gerrit.cloudera.org:8080/17126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Gerrit-Change-Number: 17126
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Mar 2021 19:42:27 +
Gerrit-HasComments: Yes

[kudu-CR] [test][master] KUDU-3249 Recover dead master at the same HostPort

2021-02-25 Thread Bankim Bhavsar (Code Review) 
Bankim Bhavsar has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17126


Change subject: [test][master] KUDU-3249 Recover dead master at the same 
HostPort
..

[test][master] KUDU-3249 Recover dead master at the same HostPort

This change uses the Add/Remove master primitives added
earlier to simulate recovery for a dead master at the same HostPort
but different uuid.

Test only code change but involves bunch of refactoring to re-use
parts of existing test.

Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 308 insertions(+), 144 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/17126/1
--
To view, visit http://gerrit.cloudera.org:8080/17126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac65201fd39ede5e918025ca7cf6a852a92d6eec
Gerrit-Change-Number: 17126
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar