[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 02 Feb 2024 14:46:56 + Gerrit-HasComments: No
[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I took a quick look at KUDU-3549, and a natural first step was to check whether we have a proper test coverage for handling StringGauge in when dumping metrics in Prometheus format. The result was this patch, adding a couple new sub-scenarios into MetricsTest.StringGaugePrometheusTest. While this didn't lead to discovering the root case of the reported issue, the new sub-scenarios are still useful since they provide extra coverage for the related functionality. I also took the liberty of cleaning up the code a bit. Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Reviewed-on: http://gerrit.cloudera.org:8080/20984 Reviewed-by: Yingchun Lai Tested-by: Alexey Serbin --- M src/kudu/util/metrics-test.cc 1 file changed, 43 insertions(+), 33 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Alexey Serbin has removed a vote on this change. Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 02 Feb 2024 06:15:00 + Gerrit-HasComments: No
[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20984 Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I took a quick look at KUDU-3549, and a natural first step was to check whether we have a proper test coverage for handling StringGauge in when dumping metrics in Prometheus format. The result was this patch, adding a couple new sub-scenarios into MetricsTest.StringGaugePrometheusTest. While this didn't lead to discovering the root case of the reported issue, the new sub-scenarios are still useful since they provide extra coverage for the related functionality. I also took the liberty of cleaning up the code a bit. Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 --- M src/kudu/util/metrics-test.cc 1 file changed, 43 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/20984/1 -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
