[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..


[tests] InvalidTokenDuringSeparateWorkloads test

Introduced new AuthnTokenExpireITest.InvalidTokenDuringSeparateWorkloads
test to cover authn token re-acquiring for both read-only and write-only
workloads.

This is to stay clear from the implementation details of the
TestWorkload class: it uses the same client object for both the read and
the write operations, while the authn token is stored as a shared piece
of data in the client object.

Also, renamed AuthnTokenExpireITest.InvalidTokenDuringWorkload test
into AuthnTokenExpireITest.InvalidTokenDuringMixedWorkload.

Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Reviewed-on: http://gerrit.cloudera.org:8080/7025
Reviewed-by: Todd Lipcon 
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 68 insertions(+), 3 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Alexey Serbin (Code Review)]

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7025

to look at the new patch set (#3).

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..

[tests] InvalidTokenDuringSeparateWorkloads test

Introduced new AuthnTokenExpireITest.InvalidTokenDuringSeparateWorkloads
test to cover authn token re-acquiring for both read-only and write-only
workloads.

This is to stay clear from the implementation details of the
TestWorkload class: it uses the same client object for both the read and
the write operations, while the authn token is stored as a shared piece
of data in the client object.

Also, renamed AuthnTokenExpireITest.InvalidTokenDuringWorkload test
into AuthnTokenExpireITest.InvalidTokenDuringMixedWorkload.

Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 68 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7025/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..


Patch Set 2: Code-Review+2

carrying over Todd's +2

-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Alexey Serbin (Code Review)]

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7025

to look at the new patch set (#2).

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..

[tests] InvalidTokenDuringSeparateWorkloads test

Introduced new AuthnTokenExpireITest.InvalidTokenDuringSeparateWorkloads
test to cover authn token re-acquiring for both read-only and write-only
workloads.

This is to stay clear from the implementation details of the
TestWorkload class: it uses the same client object for both the read and
the write operations, while the authn token is stored as a shared piece
of data in the client object.

Also, renamed AuthnTokenExpireITest.InvalidTokenDuringWorkload test
into AuthnTokenExpireITest.InvalidTokenDuringMixedWorkload.

Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 66 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7025/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7025

Change subject: [tests] InvalidTokenDuringSeparateWorkloads test
..

[tests] InvalidTokenDuringSeparateWorkloads test

Introduced new AuthnTokenExpireITest.InvalidTokenDuringSeparateWorkloads
test to cover authn token re-acquiring for both read-only and write-only
workloads.

This is to stay clear from the implementation details of the
TestWorkload class: it uses the same client object for both the read and
the write operations, while the authn token is stored as a shared piece
of data in the client object.

Also, renamed AuthnTokenExpireITest.InvalidTokenDuringWorkload test
into AuthnTokenExpireITest.InvalidTokenDuringMixedWorkload.

Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 66 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7025/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7982dfd8456791e57663fc05664e40ff205c42a2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin