[kudu-CR] Add alter external catalogs flag to table rename tool
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Add alter_external_catalogs flag to table rename tool It's going to be necessary to be able to alter the Kudu catalog independently of the HMS in order to repair and upgrade tables when the HMS integration is turned on. A follow-up commit will include a test that exercises this flag when the HMS integration is enabled. Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Reviewed-on: http://gerrit.cloudera.org:8080/11017 Reviewed-by: Hao Hao Tested-by: Dan Burkert --- M src/kudu/client/client.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 27 insertions(+), 17 deletions(-) Approvals: Hao Hao: Looks good to me, approved Dan Burkert: Verified -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add alter external catalogs flag to table rename tool
Dan Burkert has removed a vote on this change. Change subject: Add alter_external_catalogs flag to table rename tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add alter external catalogs flag to table rename tool
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 3: Verified+1 unrelated flake -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 23:54:15 + Gerrit-HasComments: No
[kudu-CR] Add alter external catalogs flag to table rename tool
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 22:25:45 + Gerrit-HasComments: No
[kudu-CR] Add alter external catalogs flag to table rename tool
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11017/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11017/2/src/kudu/client/client.h@61 PS2, Line 61: class KuduTableAlterer; > nit: this can be moved to L71. Done -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 22:15:02 + Gerrit-HasComments: Yes
[kudu-CR] Add alter external catalogs flag to table rename tool
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11017 to look at the new patch set (#3). Change subject: Add alter_external_catalogs flag to table rename tool .. Add alter_external_catalogs flag to table rename tool It's going to be necessary to be able to alter the Kudu catalog independently of the HMS in order to repair and upgrade tables when the HMS integration is turned on. A follow-up commit will include a test that exercises this flag when the HMS integration is enabled. Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 --- M src/kudu/client/client.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 27 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11017/3 -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add alter external catalogs flag to table rename tool
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11017/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11017/2/src/kudu/client/client.h@61 PS2, Line 61: class KuduClient; nit: this can be moved to L71. -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 21:18:29 + Gerrit-HasComments: Yes
[kudu-CR] Add alter external catalogs flag to table rename tool
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 04:33:39 + Gerrit-HasComments: No
[kudu-CR] Add alter external catalogs flag to table rename tool
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11017 to look at the new patch set (#2). Change subject: Add alter_external_catalogs flag to table rename tool .. Add alter_external_catalogs flag to table rename tool It's going to be necessary to be able to alter the Kudu catalog independently of the HMS in order to repair and upgrade tables when the HMS integration is turned on. A follow-up commit will include a test that exercises this flag when the HMS integration is enabled. Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 --- M src/kudu/client/client.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 26 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11017/2 -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add alter external catalogs flag to table rename tool
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h@68 PS1, Line 68: } // namespace tools > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 00:23:49 + Gerrit-HasComments: Yes
[kudu-CR] Add alter external catalogs flag to table rename tool
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h@68 PS1, Line 68: Status AlterKuduTableOnly(client::KuduClient* kudu_client, > It would be a lot cleaner to have a method in tool_action_common that sets +1 -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 23:01:03 + Gerrit-HasComments: Yes
[kudu-CR] Add alter external catalogs flag to table rename tool
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h@68 PS1, Line 68: Status AlterKuduTableOnly(client::KuduClient* kudu_client, It would be a lot cleaner to have a method in tool_action_common that sets the option on a KuduTableAlterer, then only one method needs to be a friend here. -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 22:20:50 + Gerrit-HasComments: Yes
[kudu-CR] Add alter external catalogs flag to table rename tool
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11017 to review the following change. Change subject: Add alter_external_catalogs flag to table rename tool .. Add alter_external_catalogs flag to table rename tool It's going to be necessary to be able to alter the Kudu catalog independently of the HMS in order to repair and upgrade tables when the HMS integration is turned on. A follow-up commit will include a test that exercises this flag when the HMS integration is enabled. Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 --- M src/kudu/client/client.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 3 files changed, 30 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11017/1 -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Hao Hao
