[kudu-CR] Add helper macro for tool invocations

2018-09-13 Thread Will Berkeley (Code Review) 
Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11411 )

Change subject: Add helper macro for tool invocations
..

Add helper macro for tool invocations

Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:

../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: 
process exited with non-zero status 1

This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:

../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited 
with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: 
--never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER

Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Reviewed-on: http://gerrit.cloudera.org:8080/11411
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley

[kudu-CR] Add helper macro for tool invocations

2018-09-13 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11411 )

Change subject: Add helper macro for tool invocations
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 13 Sep 2018 17:27:18 +
Gerrit-HasComments: No

[kudu-CR] Add helper macro for tool invocations

2018-09-13 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11411 )

Change subject: Add helper macro for tool invocations
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc@140
PS3, Line 140: "kudu",
> I think this should be
Done



--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 13 Sep 2018 17:26:27 +
Gerrit-HasComments: Yes

[kudu-CR] Add helper macro for tool invocations

2018-09-13 Thread Will Berkeley (Code Review) 
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11411

to look at the new patch set (#4).

Change subject: Add helper macro for tool invocations
..

Add helper macro for tool invocations

Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:

../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: 
process exited with non-zero status 1

This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:

../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited 
with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: 
--never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER

Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/4
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley

[kudu-CR] Add helper macro for tool invocations

2018-09-11 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11411 )

Change subject: Add helper macro for tool invocations
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc@140
PS3, Line 140: "kudu",
I think this should be

ASSERT_TOOL_OK("cluster", "ksck", master_addrs);

right?



--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 12 Sep 2018 04:08:11 +
Gerrit-HasComments: Yes

[kudu-CR] Add helper macro for tool invocations

2018-09-11 Thread Will Berkeley (Code Review) 
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11411

to look at the new patch set (#3).

Change subject: Add helper macro for tool invocations
..

Add helper macro for tool invocations

Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:

../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: 
process exited with non-zero status 1

This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:

../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited 
with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: 
--never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER

Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/3
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley