[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged.

Change subject: Document Impala and Spark integration known issues & limitations
..


Document Impala and Spark integration known issues & limitations

Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Reviewed-on: http://gerrit.cloudera.org:8080/4443
Tested-by: Dan Burkert 
Reviewed-by: Jean-Daniel Cryans 
---
M docs/developing.adoc
M docs/kudu_impala_integration.adoc
2 files changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Verified
  Jean-Daniel Cryans: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-23 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4443

to look at the new patch set (#4).

Change subject: Document Impala and Spark integration known issues & limitations
..

Document Impala and Spark integration known issues & limitations

Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
---
M docs/developing.adoc
M docs/kudu_impala_integration.adoc
2 files changed, 36 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4443/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4443/3/docs/developing.adoc
File docs/developing.adoc:

PS3, Line 167: Impala
Impala?


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 3: Code-Review+1

I would add +2 if I knew the area better :)  But this looks good to me!

-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4443/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

Line 1104: - Impala can not create Kudu tables with bounded range partitions, 
and can not
> No, Kudu itself doesn't support that.
Thank you for the clarification!  For some reason, I was under impression I can 
do that using native Kudu interface -- I could not do that using the Impala SQL 
shell, but I haven't tried that using native Kudu client yet.


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4443/2/docs/developing.adoc
File docs/developing.adoc:

Line 163: - `NULL`, `NOT NULL`, `<>`, and `OR` predicates are not pushed to 
Kudu, and
> What about 'LIKE', 'IN' and 'BETWEEN' predicates?  Can they be pushed to Ku
Done, except for BETWEEN predicates since we do push those down.


http://gerrit.cloudera.org:8080/#/c/4443/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

Line 1104: - Impala can not create Kudu tables with bounded range partitions, 
and can not
> Is it possible to add hash partitions for already existing Kudu table in Im
No, Kudu itself doesn't support that.


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-20 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4443

to look at the new patch set (#3).

Change subject: Document Impala and Spark integration known issues & limitations
..

Document Impala and Spark integration known issues & limitations

Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
---
M docs/developing.adoc
M docs/kudu_impala_integration.adoc
2 files changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4443/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4443/2/docs/developing.adoc
File docs/developing.adoc:

Line 163: - `NULL`, `NOT NULL`, `<>`, and `OR` predicates are not pushed to 
Kudu, and
What about 'LIKE', 'IN' and 'BETWEEN' predicates?  Can they be pushed to Kudu 
now?  Or those are not supported by SparkSQL itself?


http://gerrit.cloudera.org:8080/#/c/4443/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

Line 1104: - Impala can not create Kudu tables with bounded range partitions, 
and can not
Is it possible to add hash partitions for already existing Kudu table in Impala?


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4443/1/docs/developing.adoc
File docs/developing.adoc:

PS1, Line 159: The column name can be altered in Kudu
> unless the column is part of the primary key
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4443

to look at the new patch set (#2).

Change subject: Document Impala and Spark integration known issues & limitations
..

Document Impala and Spark integration known issues & limitations

Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
---
M docs/developing.adoc
M docs/kudu_impala_integration.adoc
2 files changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4443/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 1:

(1 comment)

Is there a note anywhere mentioning that the Spark integration is for Spark 
1.6, not 2.0? We should say somewhere in the docs since it's come up a couple 
of times in Slack, unless we set up 1.6 and 2.0 Spark builds before the next 
release.

http://gerrit.cloudera.org:8080/#/c/4443/1/docs/developing.adoc
File docs/developing.adoc:

PS1, Line 159: The column name can be altered in Kudu
unless the column is part of the primary key


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes


[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-16 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Dinesh Bhat, Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4443

to review the following change.

Change subject: Document Impala and Spark integration known issues & limitations
..

Document Impala and Spark integration known issues & limitations

Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
---
M docs/developing.adoc
M docs/kudu_impala_integration.adoc
2 files changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4443/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans