[kudu-CR] Fix bug in incorrect response rebuilding on tablet boostrap

2016-12-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5489

to look at the new patch set (#2).

Change subject: Fix bug in incorrect response rebuilding on tablet boostrap
..

Fix bug in incorrect response rebuilding on tablet boostrap

This fixes the bug described in: https://gerrit.cloudera.org/#/c/5417/
... and enables the test disabled in that patch.

Along the way this also performs some cleanup of tablet boostrap.

I ran raft_consensus-itest's TestChurnyElections_WithDuplicateKeys
on dist-test for 5000 loops with the following config:

KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py \
--disable-sharding loop -n 5000 -- bin/raft_consensus-itest \
--gtest_filter=*TestChurnyElections_WithDuplicateKeys*

Prior to this patch the test would fail 41/5000:
http://dist-test.cloudera.org//job?job_id=david.alves.1481625306.4016

After this patch the test passes 5000/5000:
http://dist-test.cloudera.org//job?job_id=david.alves.1481626183.5192

Change-Id: I1219ed5f7835e93cd7f3b128cedd650fc3384482
---
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/row_op.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/tablet_server-test.cc
4 files changed, 102 insertions(+), 98 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/5489/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1219ed5f7835e93cd7f3b128cedd650fc3384482
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] Fix bug in incorrect response rebuilding on tablet boostrap

2016-12-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5489

Change subject: Fix bug in incorrect response rebuilding on tablet boostrap
..

Fix bug in incorrect response rebuilding on tablet boostrap

This fixes the bug described in: https://gerrit.cloudera.org/#/c/5417/
... and enables the test disabled in that patch.

Along the way this also performs some cleanup of tablet boostrap.

I ran raft_consensus-itest's TestChurnyElections_WithDuplicateKeys
on dist-test for 5000 loops with the following config:

KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py \
--disable-sharding loop -n 5000 -- bin/raft_consensus-itest \
--gtest_filter=*TestChurnyElections_WithDuplicateKeys*

Prior to this patch the test would fail 41/5000:
http://dist-test.cloudera.org//job?job_id=david.alves.1481625306.4016

After this patch the test passes 5000/5000:
http://dist-test.cloudera.org//job?job_id=david.alves.1481626183.5192

Change-Id: I1219ed5f7835e93cd7f3b128cedd650fc3384482
---
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/row_op.h
M src/kudu/tablet/tablet_bootstrap.cc
3 files changed, 101 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/5489/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1219ed5f7835e93cd7f3b128cedd650fc3384482
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves