[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Todd Lipcon has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Fix flaky test TestRecoverFromOpIdOverflow (again) The previous attempt to fix this in commit f0580499dc50e8a47ff6251301cdc15b9b79edcb had a flaw, but this test really does fix the primary source of the flakiness. What appears to have happened in the previous attempt is the dist-test passed and then I made a couple additional tweaks before committing it which actually broke it again. The only "real" code change (the aforementioned fix) is on lines L367-L371, however while I was in this test I also "modernized" it a bit by making it inherit from ExternalMiniClusterITestBase which resulted in a net-negative line count in this patch. I ran the current version of this patch on dist-test in DEBUG mode with 8 cpu stress threads, and 199/200 passed (there is a nearly 50% failure rate with 8 stress threads without this fix). The one that failed actually timed out (with no logs, so I have no idea what went wrong) but it is likely some unrelated (infrastructure?) issue. This was the dist-test job: http://dist-test.cloudera.org/job?job_id=mpercy.1495321732.3266 Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Reviewed-on: http://gerrit.cloudera.org:8080/6943 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 23 insertions(+), 48 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Mike Percy has uploaded a new patch set (#3). Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Fix flaky test TestRecoverFromOpIdOverflow (again) The previous attempt to fix this in commit f0580499dc50e8a47ff6251301cdc15b9b79edcb had a flaw, but this test really does fix the primary source of the flakiness. What appears to have happened in the previous attempt is the dist-test passed and then I made a couple additional tweaks before committing it which actually broke it again. The only "real" code change (the aforementioned fix) is on lines L367-L371, however while I was in this test I also "modernized" it a bit by making it inherit from ExternalMiniClusterITestBase which resulted in a net-negative line count in this patch. I ran the current version of this patch on dist-test in DEBUG mode with 8 cpu stress threads, and 199/200 passed (there is a nearly 50% failure rate with 8 stress threads without this fix). The one that failed actually timed out (with no logs, so I have no idea what went wrong) but it is likely some unrelated (infrastructure?) issue. This was the dist-test job: http://dist-test.cloudera.org/job?job_id=mpercy.1495321732.3266 Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 23 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/6943/3 -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6943/2/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: PS2, Line 75: const int kOneReplica = 1; > Don't think this adds much value. If the goal was to make the parameter to Done -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Todd Lipcon has posted comments on this change.
Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again)
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6943/2/src/kudu/integration-tests/ts_recovery-itest.cc
File src/kudu/integration-tests/ts_recovery-itest.cc:
PS2, Line 75: const int kOneReplica = 1;
Don't think this adds much value. If the goal was to make the parameter to
StartCluster more obvious, I think it's better to just do:
StartCluster(extra_ts_flags, {}, /*replicas=*/ 1);
or something of that nature
--
To view, visit http://gerrit.cloudera.org:8080/6943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Patch Set 2: Verified+1 Overriding failure due to known flaky -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6943 to look at the new patch set (#2). Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Fix flaky test TestRecoverFromOpIdOverflow (again) The previous attempt to fix this in commit f0580499dc50e8a47ff6251301cdc15b9b79edcb had a flaw, but this test really does fix the primary source of the flakiness. What appears to have happened in the previous attempt is the dist-test passed and then I made a couple additional tweaks before committing it which actually broke it again. The only "real" code change (the aforementioned fix) is on lines L367-L371, however while I was in this test I also "modernized" it a bit by making it inherit from ExternalMiniClusterITestBase which resulted in a net-negative line count in this patch. I ran the current version of this patch on dist-test in DEBUG mode with 8 cpu stress threads, and 199/200 passed (there is a nearly 50% failure rate with 8 stress threads without this fix). The one that failed actually timed out (with no logs, so I have no idea what went wrong) but it is likely some unrelated (infrastructure?) issue. This was the dist-test job: http://dist-test.cloudera.org/job?job_id=mpercy.1495321732.3266 Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 30 insertions(+), 53 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/6943/2 -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow (again)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6943 to review the following change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) .. Fix flaky test TestRecoverFromOpIdOverflow (again) The previous attempt to fix this in commit f0580499dc50e8a47ff6251301cdc15b9b79edcb had a flaw, but this test really does fix the primary source of the flakiness. What appears to have happened in the previous attempt is the dist-test passed and then I made a couple additional tweaks before committing it which actually broke it again. The only "real" code change (the aforementioned fix) is on lines L367-L371, however while I was in this test I also "modernized" it a bit by making it inherit from ExternalMiniClusterITestBase which resulted in a net-negative line count in this patch. I ran the current version of this patch on dist-test in DEBUG mode with 8 cpu stress threads, and 199/200 passed (there is a nearly 50% failure rate with 8 stress threads without this fix). The one that failed actually timed out (with no logs, so I have no idea what went wrong) but it is likely some unrelated (infrastructure?) issue. This was the dist-test job: http://dist-test.cloudera.org/job?job_id=mpercy.1495321732.3266 Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 29 insertions(+), 53 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/6943/1 -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves
