[kudu-CR] Fix loop unroll pragma for GCC < 8

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15558 )

Change subject: Fix loop unroll pragma for GCC < 8
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:12:21 +
Gerrit-HasComments: No

[kudu-CR] Fix loop unroll pragma for GCC < 8

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15558 )

Change subject: Fix loop unroll pragma for GCC < 8
..

Fix loop unroll pragma for GCC < 8

The 'GCC unroll' pragma was only introduced in GCC 8. Add appropriate
preprocessor checks to avoid warnings on earlier gcc versions.

Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Reviewed-on: http://gerrit.cloudera.org:8080/15558
Tested-by: Todd Lipcon 
Reviewed-by: Adar Dembo 
---
M src/kudu/util/bitmap.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Fix loop unroll pragma for GCC < 8

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15558 )

Change subject: Fix loop unroll pragma for GCC < 8
..


Patch Set 1: Verified+1

java test failure


--
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Mar 2020 19:39:24 +
Gerrit-HasComments: No

[kudu-CR] Fix loop unroll pragma for GCC < 8

[Todd Lipcon (Code Review)]

Todd Lipcon has removed a vote on this change.

Change subject: Fix loop unroll pragma for GCC < 8
..


Removed -Verified by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix loop unroll pragma for GCC < 8

[Todd Lipcon (Code Review)]

Todd Lipcon has removed a vote on this change.

Change subject: Fix loop unroll pragma for GCC < 8
..


Removed -Verified by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix loop unroll pragma for GCC < 8

[Todd Lipcon (Code Review)]

Todd Lipcon has removed a vote on this change.

Change subject: Fix loop unroll pragma for GCC < 8
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix loop unroll pragma for GCC < 8

[Todd Lipcon (Code Review)]

Hello Adar Dembo,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/15558

to review the following change.


Change subject: Fix loop unroll pragma for GCC < 8
..

Fix loop unroll pragma for GCC < 8

The 'GCC unroll' pragma was only introduced in GCC 8. Add appropriate
preprocessor checks to avoid warnings on earlier gcc versions.

Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
---
M src/kudu/util/bitmap.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15558/1
--
To view, visit http://gerrit.cloudera.org:8080/15558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0278aba3a7e319a93cdefccc27b63a9e5450a12c
Gerrit-Change-Number: 15558
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo