[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16852 ) Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK This is a follow on to 0e2c288 which introduced version checks to handle the introduction of preadv/pwritev in the OSX 11 SDK. Instead of using a compile time macro to disable using the preadv/pwritev simulations, this patch reverts to using them all the time and adjusts the naming of the method to ensure there are no symbol issues. This is important so that a binary compiled using the OSX 11 SDK can run on a machine running OSX < 11. This scenario will frequently occur on Xcode 12 given the OSX 11 SDK is installed by default and chosen by default by CMake even though the machine is running OSX 10. Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Reviewed-on: http://gerrit.cloudera.org:8080/16852 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar Reviewed-by: Alexey Serbin --- M src/kudu/util/env_posix.cc 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16852 ) Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 18:43:24 + Gerrit-HasComments: No
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16852 ) Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 18:43:07 + Gerrit-HasComments: No
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16852 to look at the new patch set (#2). Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK This is a follow on to 0e2c288 which introduced version checks to handle the introduction of preadv/pwritev in the OSX 11 SDK. Instead of using a compile time macro to disable using the preadv/pwritev simulations, this patch reverts to using them all the time and adjusts the naming of the method to ensure there are no symbol issues. This is important so that a binary compiled using the OSX 11 SDK can run on a machine running OSX < 11. This scenario will frequently occur on Xcode 12 given the OSX 11 SDK is installed by default and chosen by default by CMake even though the machine is running OSX 10. Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 --- M src/kudu/util/env_posix.cc 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/16852/2 -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16852 ) Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Patch Set 1: Code-Review+1 (1 comment) I verified the broken tests are fixed with this patch with osx 10.5.7 and Xcode12. http://gerrit.cloudera.org:8080/#/c/16852/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16852/1//COMMIT_MSG@13 PS1, Line 13: using nit: use -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 04:13:02 + Gerrit-HasComments: Yes
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16852 ) Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16852/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16852/1//COMMIT_MSG@9 PS1, Line 9: 19c0f7b I'm not sure this is the correct git hash for the actual changelist: https://github.com/apache/kudu/commit/19c0f7b19b623bc91ebcd7b6451300dc45364b0b ? -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 23:57:21 + Gerrit-HasComments: Yes
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16852 ) Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 18:15:52 + Gerrit-HasComments: No
[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16852 Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK .. Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK This is a follow on to 19c0f7b which introduced version checks to handle the introduction of preadv/pwritev in the OSX 11 SDK. Instead of using a compile time macro to disable using the preadv/pwritev simulations, this patch reverts to using them all the time and adjusts the naming of the method to ensure there are no symbol issues. This is important so that a binary compiled using the OSX 11 SDK can run on a machine running OSX < 11. This scenario will frequently occur on Xcode 12 given the OSX 11 SDK is installed by default and chosen by default by CMake even though the machine is running OSX 10. Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 --- M src/kudu/util/env_posix.cc 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/16852/1 -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke