[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column Python 3 fails the test_table_column test because it is is attempting to cast a string to bytes without an encoding argument. In Python 3, this is a required parameter as bytes and strings are no longer synonymous. This patch utilizes the kudu.compat.frombytes method which was written for this purpose. Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Reviewed-on: http://gerrit.cloudera.org:8080/4543 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves --- M python/kudu/client.pyx M python/kudu/tests/test_client.py 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4543 to look at the new patch set (#3). Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column Python 3 fails the test_table_column test because it is is attempting to cast a string to bytes without an encoding argument. In Python 3, this is a required parameter as bytes and strings are no longer synonymous. This patch utilizes the kudu.compat.frombytes method which was written for this purpose. Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 --- M python/kudu/client.pyx M python/kudu/tests/test_client.py 2 files changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4543/3 -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4543/1/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: Line 45: assert col.name == name > given that column names should typically be human-readable (and are Strings Done -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4543 to look at the new patch set (#2). Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column Python 3 fails the test_table_column test because it is is attempting to cast a string to bytes without an encoding argument. In Python 3, this is a required parameter as bytes and strings are no longer synonymous. This patch utilizes the kudu.compat.frombytes method which was written for this purpose. Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 --- M python/kudu/client.pyx M python/kudu/tests/test_client.py 2 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4543/2 -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
Todd Lipcon has posted comments on this change. Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4543/1/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: Line 45: assert frombytes(col.name) == name given that column names should typically be human-readable (and are Strings in java rather than byte[]) should we have 'col.name' actually be a str rather than a bytes? -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4543 Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column Python 3 fails the test_table_column test because it is is attempting to cast a string to bytes without an encoding argument. In Python 3, this is a required parameter as bytes and strings are no longer synonymous. This patch utilizes the kudu.compat.frombytes method which was written for this purpose. Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 --- M python/kudu/tests/test_client.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4543/1 -- To view, visit http://gerrit.cloudera.org:8080/4543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell
