[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: KUDU-1753 continue scan if tablet is being deleted
..


KUDU-1753 continue scan if tablet is being deleted

Updated TabletServiceImpl::HandleContinueScanRequest() to continue
serving in-progress scan requests even if the tablet was deleted
in the middle.

This patch also enables the TestDeleteTableWhileScanInProgress
integration test from the DeleteTableTest suite.

This is intended to fix the following JIRA item:
KUDU-1753 Impala query fails: Unable to advance iterator:
  Illegal state: Tablet is not running

Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1
Reviewed-on: http://gerrit.cloudera.org:8080/5346
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 30 insertions(+), 16 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1753 continue scan if tablet is being deleted
..


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1753 continue scan if tablet is being deleted
..


Patch Set 6:

(2 comments)

lgtm, excepting nits. see my comment on the test patch though.

http://gerrit.cloudera.org:8080/#/c/5346/6/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:

PS6, Line 1686: PREDICT_FALSE(!s.ok() && !s.IsIllegalState())
nit: you only need to check !s.IsIllegalState()


PS6, Line 1686: if (PREDICT_FALSE(!s.ok() && !s.IsIllegalState())) {
how about you make this more explicit:

if (PREDICT_FALSE(!s.ok() || tablet_ref_error_code != TABLET_NOT_RUNNING) ?


-- 
To view, visit http://gerrit.cloudera.org:8080/5346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5346

to look at the new patch set (#6).

Change subject: KUDU-1753 continue scan if tablet is being deleted
..

KUDU-1753 continue scan if tablet is being deleted

Updated TabletServiceImpl::HandleContinueScanRequest() to continue
serving in-progress scan requests even if the tablet was deleted
in the middle.

This patch also enables the TestDeleteTableWhileScanInProgress
integration test from the DeleteTableTest suite.

This is intended to fix the following JIRA item:
KUDU-1753 Impala query fails: Unable to advance iterator:
  Illegal state: Tablet is not running

Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 28 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/5346/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mike Percy