[kudu-CR] KUDU-1757: add PartialRow.toString

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-1757: add PartialRow.toString
..


KUDU-1757: add PartialRow.toString

Operation.toString could fail if the operation's partial row had not had
its full primary key filled in yet. This adds a PartialRow.toString
method which can handle any unset columns, and changes
Operation.toString to use that. Also fixes a ByteBuffer usage bug in
PartialRow::appendCellValueDebugString

Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Reviewed-on: http://gerrit.cloudera.org:8080/5237
Reviewed-by: Jean-Daniel Cryans 
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
3 files changed, 92 insertions(+), 3 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 

[kudu-CR] KUDU-1757: add PartialRow.toString

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1757: add PartialRow.toString
..


Patch Set 9: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 
Gerrit-HasComments: No

[kudu-CR] KUDU-1757: add PartialRow.toString

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1757: add PartialRow.toString
..


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5237/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java:

Line 1: // Licensed to the Apache Software Foundation (ASF) under one
> Add license.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1757: add PartialRow.toString

[Dan Burkert (Code Review)]

Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5237

to look at the new patch set (#9).

Change subject: KUDU-1757: add PartialRow.toString
..

KUDU-1757: add PartialRow.toString

Operation.toString could fail if the operation's partial row had not had
its full primary key filled in yet. This adds a PartialRow.toString
method which can handle any unset columns, and changes
Operation.toString to use that. Also fixes a ByteBuffer usage bug in
PartialRow::appendCellValueDebugString

Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
3 files changed, 92 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5237/9
-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 

[kudu-CR] KUDU-1757: add PartialRow.toString

[Dan Burkert (Code Review)]

Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5237

to look at the new patch set (#8).

Change subject: KUDU-1757: add PartialRow.toString
..

KUDU-1757: add PartialRow.toString

Operation.toString could fail if the operation's partial row had not had
its full primary key filled in yet. This adds a PartialRow.toString
method which can handle any unset columns, and changes
Operation.toString to use that. Also fixes a ByteBuffer usage bug in
PartialRow::appendCellValueDebugString

Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
3 files changed, 93 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5237/8
-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 

[kudu-CR] KUDU-1757: add PartialRow.toString

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1757: add PartialRow.toString
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5237/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java:

Line 1: package org.apache.kudu.client;
Add license.


-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1757: add PartialRow.toString

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1757: add PartialRow.toString
..


Patch Set 6:

Hey Yanlong,

I tracked down the error to a bug I introduced recently.  I just pushed a new 
revision with the fix and a test.

-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng 
Gerrit-HasComments: No

[kudu-CR] KUDU-1757: add PartialRow.toString

[Dan Burkert (Code Review)]

Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5237

to look at the new patch set (#7).

Change subject: KUDU-1757: add PartialRow.toString
..

KUDU-1757: add PartialRow.toString

Operation.toString could fail if the operation's partial row had not had
its full primary key filled in yet. This adds a PartialRow.toString
method which can handle any unset columns, and changes
Operation.toString to use that. Also fixes a ByteBuffer usage bug in
PartialRow::appendCellValueDebugString

Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
3 files changed, 76 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5237/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Yanlong Zheng