[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: KUDU-1771. Java client "connection refused" errors logged as 
"connection reset"
..


KUDU-1771. Java client "connection refused" errors logged as
"connection reset"

This commit changes cleanup() to accepts a string input.
It allows a caller to customize its error message based
on the caller site context.

Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
Reviewed-on: http://gerrit.cloudera.org:8080/5680
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
1 file changed, 10 insertions(+), 8 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-12 Thread Jun He (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5680

to look at the new patch set (#2).

Change subject: KUDU-1771. Java client "connection refused" errors logged as 
"connection reset"
..

KUDU-1771. Java client "connection refused" errors logged as
"connection reset"

This commit changes cleanup() to accepts a string input.
It allows a caller to customize its error message based
on the caller site context.

Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
---
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
1 file changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/5680/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-12 Thread Jun He (Code Review)
Jun He has posted comments on this change.

Change subject: KUDU-1771. Java client "connection refused" errors logged as 
"connection reset"
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5680/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java:

PS1, Line 702: 
> Don't need this.
Done


PS1, Line 801: //
> Can you re-align the comments?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes


[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1771. Java client "connection refused" errors logged as 
"connection reset"
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5680/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java:

PS1, Line 702: 
Don't need this.


PS1, Line 801: //
Can you re-align the comments?


-- 
To view, visit http://gerrit.cloudera.org:8080/5680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes


[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-11 Thread Jun He (Code Review)
Jun He has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5680

Change subject: KUDU-1771. Java client "connection refused" errors logged as 
"connection reset"
..

KUDU-1771. Java client "connection refused" errors logged as
"connection reset"

This commit changes cleanup() to accepts a string input.
It allows a caller to customize its error message based
on the caller site context.

Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
---
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/5680/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9eb40f11757ae76bc430b3f513b96592068d6e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He