[kudu-CR] KUDU-1945 Fix TSAN warnings in client-test.cc

2023-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19427 )

Change subject: KUDU-1945 Fix TSAN warnings in client-test.cc
..

KUDU-1945 Fix TSAN warnings in client-test.cc

This patch addresses the TSAN warnings seen due to race conditions
in the test ClientTestAutoIncrementingColumn.ConcurrentWrites in
client-test.cc.

Without any modification 5/1024 failed:
http://dist-test.cloudera.org/job?job_id=root.1673953260.499709

With the proposed changes: 0/1024 failed:
http://dist-test.cloudera.org/job?job_id=root.1673952868.476619

Thanks to Marton for helping out with the dist-test.

Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
Reviewed-on: http://gerrit.cloudera.org:8080/19427
Reviewed-by: Marton Greber 
Reviewed-by: Attila Bukor 
Tested-by: Attila Bukor 
---
M src/kudu/client/client-test.cc
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Marton Greber: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
Gerrit-Change-Number: 19427
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber 


[kudu-CR] KUDU-1945 Fix TSAN warnings in client-test.cc

2023-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change.

Change subject: KUDU-1945 Fix TSAN warnings in client-test.cc
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
Gerrit-Change-Number: 19427
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber 


[kudu-CR] KUDU-1945 Fix TSAN warnings in client-test.cc

2023-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19427 )

Change subject: KUDU-1945 Fix TSAN warnings in client-test.cc
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
Gerrit-Change-Number: 19427
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber 
Gerrit-Comment-Date: Tue, 17 Jan 2023 17:46:42 +
Gerrit-HasComments: No


[kudu-CR] KUDU-1945 Fix TSAN warnings in client-test.cc

2023-01-17 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19427 )

Change subject: KUDU-1945 Fix TSAN warnings in client-test.cc
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/19427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
Gerrit-Change-Number: 19427
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber 
Gerrit-Comment-Date: Tue, 17 Jan 2023 17:32:39 +
Gerrit-HasComments: No


[kudu-CR] KUDU-1945 Fix TSAN warnings in client-test.cc

2023-01-17 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19427


Change subject: KUDU-1945 Fix TSAN warnings in client-test.cc
..

KUDU-1945 Fix TSAN warnings in client-test.cc

This patch addresses the TSAN warnings seen due to race conditions
in the test ClientTestAutoIncrementingColumn.ConcurrentWrites in
client-test.cc.

Without any modification 5/1024 failed:
http://dist-test.cloudera.org/job?job_id=root.1673953260.499709

With the proposed changes: 0/1024 failed:
http://dist-test.cloudera.org/job?job_id=root.1673952868.476619

Thanks to Marton for helping out with the dist-test.

Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
---
M src/kudu/client/client-test.cc
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/19427/1
--
To view, visit http://gerrit.cloudera.org:8080/19427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
Gerrit-Change-Number: 19427
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka