[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6534 to look at the new patch set (#4). Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. KUDU-1991. master: Retry background tasks even if TS UUID not registered Before this patch, if a master had just started up and got a message from a tablet server that would require some action in response (for example, deleting an evicted replica or replacing a replica in an under-replicated tablet) then if an affected tablet server had not registered with the master the task would fail and would not be retried. This patch causes the task to be retried even if the initial tablet server UUID lookup fails. This change is tested by AdminCliTest.TestUnsafeChangeConfigOnSingleFollower, which prior to this patch was flaky (7/200 tests failed on dist-test before the patch). After the changes to that test, it requires the above master fix to pass but is no longer flaky (200/200 passed on dist-test). Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d --- M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/master/catalog_manager.cc M src/kudu/tools/kudu-admin-test.cc 4 files changed, 102 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/6534/4 -- To view, visit http://gerrit.cloudera.org:8080/6534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered
Mike Percy has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6534/1//COMMIT_MSG Commit Message: PS1, Line 14: This patch causes the task to be retried even if the initial tablet : server UUID lookup fails. > Yeah I meant that this is edge triggered (always has been). I agree level t I agree that is a problem. This works around the steady-state case that may commonly happen at cluster startup time and I've filed KUDU-1991 to track this issue. I've also filed KUDU-1997 to track the edge-triggered vs. level-triggered issue separately so I think we should get this in now and prioritize KUDU-1997 separately. -- To view, visit http://gerrit.cloudera.org:8080/6534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered
Adar Dembo has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6534/1//COMMIT_MSG Commit Message: PS1, Line 14: This patch causes the task to be retried even if the initial tablet : server UUID lookup fails. > I agree that is a problem. This works around the steady-state case that may Works for me. -- To view, visit http://gerrit.cloudera.org:8080/6534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered
Mike Percy has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 4: Verified+1 Overriding Jenkins failure due to flaky test caused by KUDU-1736 -- To view, visit http://gerrit.cloudera.org:8080/6534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered
Mike Percy has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6534/1//COMMIT_MSG Commit Message: PS1, Line 14: This patch causes the task to be retried even if the initial tablet : server UUID lookup fails. > Works for me. Great. Thanks for the review. -- To view, visit http://gerrit.cloudera.org:8080/6534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. KUDU-1991. master: Retry background tasks even if TS UUID not registered Before this patch, if a master had just started up and got a message from a tablet server that would require some action in response (for example, deleting an evicted replica or replacing a replica in an under-replicated tablet) then if an affected tablet server had not registered with the master the task would fail and would not be retried. This patch causes the task to be retried even if the initial tablet server UUID lookup fails. This change is tested by AdminCliTest.TestUnsafeChangeConfigOnSingleFollower, which prior to this patch was flaky (7/200 tests failed on dist-test before the patch). After the changes to that test, it requires the above master fix to pass but is no longer flaky (200/200 passed on dist-test). Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Reviewed-on: http://gerrit.cloudera.org:8080/6534 Reviewed-by: Adar Dembo Tested-by: Mike Percy --- M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/master/catalog_manager.cc M src/kudu/tools/kudu-admin-test.cc 4 files changed, 102 insertions(+), 61 deletions(-) Approvals: Mike Percy: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot
