[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed prepare There is currently a bug where we don't decrement the number of running ops when an op->Prepare() fails. Although rare, when this bug is hit, it will decrease the number of simultaneous mm ops that can run until none can, causing the tserver to run OOM. Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Reviewed-on: http://gerrit.cloudera.org:8080/7610 Reviewed-by: Todd LipconTested-by: Kudu Jenkins --- M src/kudu/util/maintenance_manager.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare
Todd Lipcon has posted comments on this change. Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7610 to look at the new patch set (#3). Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed prepare There is currently a bug where we don't decrement the number of running ops when an op->Prepare() fails. Although rare, when this bug is hit, it will decrease the number of simultaneous mm ops that can run until none can, causing the tserver to run OOM. Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 --- M src/kudu/util/maintenance_manager.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/7610/3 -- To view, visit http://gerrit.cloudera.org:8080/7610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon