[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files

2017-08-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-2089: Failed java tests can orphan test-tmp files
..


KUDU-2089: Failed java tests can orphan test-tmp files

This changes the MiniKuduCluster code to add the paths to pathsToDelete
before calling configureAndStartProcess.

If configureAndStartProcess throws an exception, the test-tmp files will
be still deleted during shutdown.

Change-Id: I53c04987b6683dc959c319d384657c28b4671168
Reviewed-on: http://gerrit.cloudera.org:8080/7719
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53c04987b6683dc959c319d384657c28b4671168
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files

2017-08-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: KUDU-2089: Failed java tests can orphan test-tmp files
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c04987b6683dc959c319d384657c28b4671168
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files

2017-08-18 Thread Jun He (Code Review)
Jun He has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7719

Change subject: KUDU-2089: Failed java tests can orphan test-tmp files
..

KUDU-2089: Failed java tests can orphan test-tmp files

This changes the MiniKuduCluster code to add the paths to pathsToDelete
before calling configureAndStartProcess.

If configureAndStartProcess throws an exception, the test-tmp files will
be still deleted during shutdown.

Change-Id: I53c04987b6683dc959c319d384657c28b4671168
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/7719/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53c04987b6683dc959c319d384657c28b4671168
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He