[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-2098. Drop Spark 1 Support
..


KUDU-2098. Drop Spark 1 Support

Spark 2 has been available for over a year and the value of
shipping a seperate Spark 1 artifact is decreasing.
In the case where another Spark 1 release occurs or bug fixes
are needed, updates to the Kudu Spark 1 integration can still
exist via maintenance releases.

This allows us to clean up deprecated mehods that are used for
compatibility purposes and simplifies the build.

Here is the dev mailing list discussion for reference:
https://s.apache.org/PCfg

Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Reviewed-on: http://gerrit.cloudera.org:8080/7690
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
M java/README.md
M java/gradle/dependencies.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
R java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
D java/kudu-spark/src/main/spark1/org/apache/kudu/spark/kudu/package.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
M java/pom.xml
18 files changed, 85 insertions(+), 248 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7690/3//COMMIT_MSG
Commit Message:

Line 13: exist via maintenance relases.
> releases
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 3:

(1 comment)

one final nit, but otherwise LGTM

http://gerrit.cloudera.org:8080/#/c/7690/3//COMMIT_MSG
Commit Message:

PS3, Line 13: relases
releases


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

Line 30: 
kudu-${spark.version.label}-tools_${scala.binary.version}
> I suspect down the line we will need to support spark3 or Scala 2.12. If it
OK that's reasonable.


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7690/2//COMMIT_MSG
Commit Message:

Line 9: Spark 2 has been available for over a year and the value of
May want to throw a link to 
https://lists.apache.org/thread.html/1bcd0e048e7fe8d91f69c468d1577987215484395dd0540b7fa902cf@%3Cdev.kudu.apache.org%3E
 in here.


http://gerrit.cloudera.org:8080/#/c/7690/2/java/README.md
File java/README.md:

Line 54: $ mvn verify
Probably should call out that this requires Java 8, since it's 7 or 8 above.


http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

Line 30: 
kudu-${spark.version.label}-tools_${scala.binary.version}
I think we should hard code this now, IntelliJ has a big problem with 
properties in artifact names.


http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
File 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala:

Line 41:   ss)
keep the indent the same.


http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 23: 
kudu-${spark.version.label}_${scala.binary.version}
Same here.  I wouldn't be against getting rid of all of the interpolation of 
spark and scala versions in artifact IDs, but maybe we'll need it again?


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7690

to look at the new patch set (#2).

Change subject: KUDU-2098. Drop Spark 1 Support
..

KUDU-2098. Drop Spark 1 Support

Spark 2 has been available for over a year and the value of
shipping a seperate Spark 1 artifact is decreasing.
In the case where another Spark 1 release occurs or bug fixes
are needed, updates to the Kudu Spark 1 integration can still
exist via maintenance relases.

This allows us to clean up deprecated mehods that are used for
compatibility purposes and simplifies the build.

Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
---
M build-support/jenkins/build-and-test.sh
M java/README.md
M java/gradle/dependencies.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
R java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
D java/kudu-spark/src/main/spark1/org/apache/kudu/spark/kudu/package.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
M java/pom.xml
18 files changed, 83 insertions(+), 249 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7690/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 1:

Yeah, I think that makes sense.

-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 1:

So is the plan that this can merge after 1.5 branches?

-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-2098. Drop Spark 1 Support

[Grant Henke (Code Review)]

Grant Henke has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7690

Change subject: KUDU-2098. Drop Spark 1 Support
..

KUDU-2098. Drop Spark 1 Support

Spark 2 has been available for over a year and the value of
shipping a seperate Spark 1 artifact is decreasing.
In the case where another Spark 1 release occurs or bug fixes
are needed, updates to the Kudu Spark 1 integration can still
exist via maintenance relases.

This allows us to clean up deprecated mehods that are used for
compatibility purposes and simplifies the build.

Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
---
M build-support/jenkins/build-and-test.sh
M java/README.md
M java/gradle/dependencies.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
R java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
D java/kudu-spark/src/main/spark1/org/apache/kudu/spark/kudu/package.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
M java/pom.xml
18 files changed, 83 insertions(+), 243 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7690/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke