[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


KUDU-2104. Upgrade to Spark 2.2.0

Upgrades to Spark 2.2.0 and documents the Java 8
runtime requirement.

Also adjusts the Jenkins scripts to use Java 8 when
building and running.

Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Reviewed-on: http://gerrit.cloudera.org:8080/7720
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert 
---
M build-support/jenkins/build-and-test.sh
M docs/developing.adoc
M docs/release_notes.adoc
M java/README.md
M java/gradle/dependencies.gradle
M java/pom.xml
6 files changed, 14 insertions(+), 4 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


Patch Set 2:

I updated the patch to hopefully make the runtime requirements more clear. 

We are compatible now and I agree the decision to use new apis which may break 
combat should be carefully weighed. However, that likely shouldn't stop this 
change.

-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7720

to look at the new patch set (#3).

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..

KUDU-2104. Upgrade to Spark 2.2.0

Upgrades to Spark 2.2.0 and documents the Java 8
runtime requirement.

Also adjusts the Jenkins scripts to use Java 8 when
building and running.

Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
---
M build-support/jenkins/build-and-test.sh
M docs/developing.adoc
M docs/release_notes.adoc
M java/README.md
M java/gradle/dependencies.gradle
M java/pom.xml
6 files changed, 14 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/7720/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


Patch Set 2:

I guess that begs the question: are we still compatible with Spark 2.0 and 2.1? 
 I think we are at this point, but would we intentionally forgo using a newly 
introduced API just to remain backwards compat?

-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7720/2/docs/developing.adoc
File docs/developing.adoc:

Line 162: - The spark 2.x integration requires Java 8 at runtime as of Kudu 
1.5.0.
> It is, but if this patch is accepted Spark 2.2.0 will be the build default 
But if your 'spark2-submit' binary is Spark 2.1, you should still be able to 
run jobs including kudu-spark2_2.11 with JRE 7, right?


-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7720/2/docs/developing.adoc
File docs/developing.adoc:

Line 162: - The spark 2.x integration requires Java 8 at runtime as of Kudu 
1.5.0.
> I thought we determined that the jar should be compatible with Java 7 when 
It is, but if this patch is accepted Spark 2.2.0 will be the build default 
which requires Java 8.


-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7720/2/docs/developing.adoc
File docs/developing.adoc:

Line 162: - The spark 2.x integration requires Java 8 at runtime as of Kudu 
1.5.0.
I thought we determined that the jar should be compatible with Java 7 when used 
with Spark 2.1?


-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7720

to look at the new patch set (#2).

Change subject: KUDU-2104. Upgrade to Spark 2.2.0
..

KUDU-2104. Upgrade to Spark 2.2.0

Upgrades to Spark 2.2.0 and documents the Java 8
runtime requirement.

Also adjusts the Jenkins scripts to use Java 8 when
building and running.

Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
---
M build-support/jenkins/build-and-test.sh
M docs/developing.adoc
M docs/release_notes.adoc
M java/README.md
M java/gradle/dependencies.gradle
M java/pom.xml
6 files changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/7720/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3c179816f02fa8cc3e942e803851881dda0a014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins