[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. KUDU-2113 Segfault because of consensus conflict and missing tablet server Sometimes the master doesn't report all tablet servers. This can happen, for example, when the master is starting. When this happened and there was also a consensus conflict, it caused a segfault. This fixes the segfault and contains a regression test. Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Reviewed-on: http://gerrit.cloudera.org:8080/7864 Reviewed-by: Adar Dembo Tested-by: Will Berkeley --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 48 insertions(+), 15 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Will Berkeley: Verified -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Will Berkeley has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 3: Overriding Jenkins b/c failure was unrelated (though a legit bug, not a flake). -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Will Berkeley has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Will Berkeley has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 3: It's real and reproducible with the same seed. Filedhttps://issues.apache.org/jira/browse/KUDU-2119. -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Adar Dembo has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 3: Code-Review+2 Test failure looks unrelated but potentially real. Could you investigate and file a JIRA if it looks legit? -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7864 to look at the new patch set (#3). Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. KUDU-2113 Segfault because of consensus conflict and missing tablet server Sometimes the master doesn't report all tablet servers. This can happen, for example, when the master is starting. When this happened and there was also a consensus conflict, it caused a segfault. This fixes the segfault and contains a regression test. Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 48 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/7864/3 -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Will Berkeley has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7864/2//COMMIT_MSG Commit Message: PS2, Line 7: SEGV > Nit: pedantry, but "SEGV" isn't really a thing. It's either a "segmentation Done http://gerrit.cloudera.org:8080/#/c/7864/2/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: PS2, Line 293: FRIEND_TEST(KsckTest, TestMismatchedAssignments); : FRIEND_TEST(KsckTest, TestConsensusConflictExtraPeer); : FRIEND_TEST(KsckTest, TestConsensusConflictMissingPeer); : FRIEND_TEST(KsckTest, TestConsensusConflictDifferentLeader); : FRIEND_TEST(KsckTest, TestMasterNotReportingTabletServerWithConsensusConflict); > Nit: mind sorting this list alphabetically? Done -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
