[kudu-CR] KUDU-2184. arena: fix max buffer size to just less than 1MB
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8324 ) Change subject: KUDU-2184. arena: fix max buffer size to just less than 1MB .. KUDU-2184. arena: fix max buffer size to just less than 1MB eb5c7e2f0c73729a4486bc71512739b0788b1574 changed the max buffer size for arenas to 1MB to try to sync up with the max size of an exact free-list in tcmalloc. However it turns out that tcmalloc's max size class is sized at 8kb less than 1MB rather than exactly at 1MB. So, this patch adjusts the arena buffer size to match. I verified under a workload that the memz stats on a tablet server now show heavy usage of the 127-page size class whereas before they did not. Change-Id: I6549fefe8cd82e4e890aed339fea34a227f94a5b Reviewed-on: http://gerrit.cloudera.org:8080/8324 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves --- M src/kudu/util/memory/arena.cc M src/kudu/util/memory/arena.h 2 files changed, 15 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified David Ribeiro Alves: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6549fefe8cd82e4e890aed339fea34a227f94a5b Gerrit-Change-Number: 8324 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2184. arena: fix max buffer size to just less than 1MB
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8324 ) Change subject: KUDU-2184. arena: fix max buffer size to just less than 1MB .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6549fefe8cd82e4e890aed339fea34a227f94a5b Gerrit-Change-Number: 8324 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Oct 2017 17:22:40 + Gerrit-HasComments: No
[kudu-CR] KUDU-2184. arena: fix max buffer size to just less than 1MB
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8324 to review the following change. Change subject: KUDU-2184. arena: fix max buffer size to just less than 1MB .. KUDU-2184. arena: fix max buffer size to just less than 1MB eb5c7e2f0c73729a4486bc71512739b0788b1574 changed the max buffer size for arenas to 1MB to try to sync up with the max size of an exact free-list in tcmalloc. However it turns out that tcmalloc's max size class is sized at 8kb less than 1MB rather than exactly at 1MB. So, this patch adjusts the arena buffer size to match. I verified under a workload that the memz stats on a tablet server now show heavy usage of the 127-page size class whereas before they did not. Change-Id: I6549fefe8cd82e4e890aed339fea34a227f94a5b --- M src/kudu/util/memory/arena.cc M src/kudu/util/memory/arena.h 2 files changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/8324/1 -- To view, visit http://gerrit.cloudera.org:8080/8324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6549fefe8cd82e4e890aed339fea34a227f94a5b Gerrit-Change-Number: 8324 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves