[kudu-CR] KUDU-2275. Upgrade libunwind to 1.3-rc1
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9335 ) Change subject: KUDU-2275. Upgrade libunwind to 1.3-rc1 .. KUDU-2275. Upgrade libunwind to 1.3-rc1 Per KUDU-2275, the version of libunwind that we were previously using can occasionally crash during stack unwinding if it attempts to access a page which is mprotected to be non-readable. This could be due to incorrect interpretation of dwarf unwinding info or some other bug. As we are trying to collect stacks more aggressively now, it's important to upgrade. This new version uses a more robust mechanism for checking whether a page is valid to access before accessing it during unwinding. This also includes a patch from the libunwind git repo which fixes a potential issue with libunwind in ASAN builds. I didn't run into this issue yet myself, but seems like a straightforward and necessary fix. Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e Reviewed-on: http://gerrit.cloudera.org:8080/9335 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M src/kudu/util/file_cache-test.cc M thirdparty/download-thirdparty.sh A thirdparty/patches/libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch M thirdparty/vars.sh 4 files changed, 61 insertions(+), 4 deletions(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e Gerrit-Change-Number: 9335 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2275. Upgrade libunwind to 1.3-rc1
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9335 ) Change subject: KUDU-2275. Upgrade libunwind to 1.3-rc1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e Gerrit-Change-Number: 9335 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Feb 2018 20:29:28 + Gerrit-HasComments: No
[kudu-CR] KUDU-2275. Upgrade libunwind to 1.3-rc1
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9335 to look at the new patch set (#2). Change subject: KUDU-2275. Upgrade libunwind to 1.3-rc1 .. KUDU-2275. Upgrade libunwind to 1.3-rc1 Per KUDU-2275, the version of libunwind that we were previously using can occasionally crash during stack unwinding if it attempts to access a page which is mprotected to be non-readable. This could be due to incorrect interpretation of dwarf unwinding info or some other bug. As we are trying to collect stacks more aggressively now, it's important to upgrade. This new version uses a more robust mechanism for checking whether a page is valid to access before accessing it during unwinding. This also includes a patch from the libunwind git repo which fixes a potential issue with libunwind in ASAN builds. I didn't run into this issue yet myself, but seems like a straightforward and necessary fix. Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e --- M src/kudu/util/file_cache-test.cc M thirdparty/download-thirdparty.sh A thirdparty/patches/libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch M thirdparty/vars.sh 4 files changed, 61 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/9335/2 -- To view, visit http://gerrit.cloudera.org:8080/9335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e Gerrit-Change-Number: 9335 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2275. Upgrade libunwind to 1.3-rc1
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9335 to review the following change. Change subject: KUDU-2275. Upgrade libunwind to 1.3-rc1 .. KUDU-2275. Upgrade libunwind to 1.3-rc1 Per KUDU-2275, the version of libunwind that we were previously using can occasionally crash during stack unwinding if it attempts to access a page which is mprotected to be non-readable. This could be due to incorrect interpretation of dwarf unwinding info or some other bug. As we are trying to collect stacks more aggressively now, it's important to upgrade. This new version uses a more robust mechanism for checking whether a page is valid to access before accessing it during unwinding. This also includes a patch from the libunwind git repo which fixes a potential issue with libunwind in ASAN builds. I didn't run into this issue yet myself, but seems like a straightforward and necessary fix. Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e --- M thirdparty/download-thirdparty.sh A thirdparty/patches/libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch M thirdparty/vars.sh 3 files changed, 51 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/9335/1 -- To view, visit http://gerrit.cloudera.org:8080/9335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3f942a0d566e1b1e5ebe48f09362bf8aa3e1e33e Gerrit-Change-Number: 9335 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Will Berkeley
