[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-07 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 20:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14426/19//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14426/19//COMMIT_MSG@6
PS19, Line 6:
> Probably don't need p2, given this is first in the dependency chain.
Sorry, missed your comment before merging...



--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 20
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 08 Feb 2020 02:04:25 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-07 Thread Hao Hao (Code Review) 
Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..

KUDU-2971 p2: add basic protobuf msg

This commit adds some basic protobuf messages for communicating with a
subprocess. For example, EchoRequestPB and EchoResponsePB that simply
echoes the request as a response.

Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Reviewed-on: http://gerrit.cloudera.org:8080/14426
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong 
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess.proto
2 files changed, 74 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 20
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-07 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 19: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14426/19//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14426/19//COMMIT_MSG@6
PS19, Line 6:
Probably don't need p2, given this is first in the dependency chain.



--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 19
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 08 Feb 2020 01:25:39 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-04 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 14: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 14
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Feb 2020 20:27:52 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-27 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 12: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 28 Jan 2020 04:55:57 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-15 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 10: Verified+1

Unrelated flaky test.


--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Jan 2020 05:58:35 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-15 Thread Hao Hao (Code Review) 
Hao Hao has removed a vote on this change.

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-14 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 8: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2020 00:19:40 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-13 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 8: Verified+1

> Patch Set 8: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/20093/ : FAILURE

Unrelated flaky test KUDU-2694.


--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jan 2020 19:36:44 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-13 Thread Hao Hao (Code Review) 
Hao Hao has removed a vote on this change.

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-12 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14426 )

Change subject: KUDU-2971 p2: add basic protobuf msg
..


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14426/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14426/7//COMMIT_MSG@7
PS7, Line 7: KUDU-2971
> KUDU-2971
Done


http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto
File src/kudu/subprocess/subprocess.proto:

http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto@34
PS1, Line 34: }
> yeah but we use proto2 syntax, I thought proto3 would be necessary here. Ne
Ack


http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto
File src/kudu/subprocess/subprocess.proto:

http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto@17
PS4, Line 17:
> nit: does it make sense to add a small comment pointing to the fact that th
Done


http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto@25
PS4, Line 25: import "google/protobuf/any.proto";
: import "kudu/common/wire_protocol.proto";
:
: // EchoResponsePB simply echoes the data in EchoRequestPB as a 
response.
: message EchoRequestPB {
: 
> Do you mind adding a small comment for these (something like in the commit
Done



--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jan 2020 07:03:13 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-12 Thread Hao Hao (Code Review) 
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14426

to look at the new patch set (#8).

Change subject: KUDU-2971 p2: add basic protobuf msg
..

KUDU-2971 p2: add basic protobuf msg

This commit adds some basic protobuf messages for communicating with a
subprocess. For example, EchoRequestPB and EchoResponsePB that simply
echoes the request as a response.

Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess.proto
2 files changed, 74 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/14426/8
--
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)