[kudu-CR] KUDU-3292 Show non-default flags on WEB UI

2023-01-10 Thread Yingchun Lai (Code Review) 
Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19408 )

Change subject: KUDU-3292 Show non-default flags on WEB UI
..


Patch Set 4:

Sorry I didn't reply in the gerrit, but I replied in the jira, could you take a 
look at it? http://issues.apache.org/jira/browse/KUDU-3292


--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Zoltan Chovan 
Gerrit-Comment-Date: Tue, 10 Jan 2023 23:44:04 +
Gerrit-HasComments: No

[kudu-CR] KUDU-3292 Show non-default flags on WEB UI

2023-01-10 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19408 )

Change subject: KUDU-3292 Show non-default flags on WEB UI
..

KUDU-3292 Show non-default flags on WEB UI

Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Reviewed-on: http://gerrit.cloudera.org:8080/19408
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan 
Reviewed-by: Alexey Serbin 
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
4 files changed, 40 insertions(+), 23 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Zoltan Chovan: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan

[kudu-CR] KUDU-3292 Show non-default flags on WEB UI

2023-01-10 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19408 )

Change subject: KUDU-3292 Show non-default flags on WEB UI
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan 
Gerrit-Comment-Date: Tue, 10 Jan 2023 19:25:44 +
Gerrit-HasComments: No

[kudu-CR] KUDU-3292 Show non-default flags on WEB UI

2023-01-10 Thread Zoltan Chovan (Code Review) 
Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19408 )

Change subject: KUDU-3292 Show non-default flags on WEB UI
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan 
Gerrit-Comment-Date: Tue, 10 Jan 2023 15:54:33 +
Gerrit-HasComments: No

[kudu-CR] KUDU-3292 Show non-default flags on WEB UI

2023-01-09 Thread Code Review 
Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19408

to look at the new patch set (#2).

Change subject: KUDU-3292 Show non-default flags on WEB UI
..

KUDU-3292 Show non-default flags on WEB UI

Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
4 files changed, 40 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19408/2
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3292 Show non-default flags on WEB UI

2023-01-09 Thread Code Review 
Ádám Bakai has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19408


Change subject: KUDU-3292 Show non-default flags on WEB UI
..

KUDU-3292 Show non-default flags on WEB UI

Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
4 files changed, 42 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19408/1
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai