[kudu-CR] KUDU-586. Upgrade to protobuf 3
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-586. Upgrade to protobuf 3 .. KUDU-586. Upgrade to protobuf 3 Upgrades Kudu to use protoc 3.3.0 and adds `syntax = "proto2”;` to the proto files. Does not leverage the new protobuf allocation arenas, but that should be considered in a follow up patch. Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Reviewed-on: http://gerrit.cloudera.org:8080/6857 Reviewed-by: Adar DemboTested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/cfile/cfile.proto M src/kudu/client/client.proto M src/kudu/common/common.proto M src/kudu/common/wire_protocol.proto M src/kudu/consensus/consensus.proto M src/kudu/consensus/log.proto M src/kudu/consensus/metadata.proto M src/kudu/consensus/opid.proto M src/kudu/fs/fs.proto M src/kudu/master/master.proto M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rpc_introspection.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/rtest_diff_package.proto M src/kudu/security/token.proto M src/kudu/server/server_base.proto M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet.proto M src/kudu/tserver/tablet_copy.proto M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_admin.proto M src/kudu/tserver/tserver_service.proto M src/kudu/util/compression/compression.proto M src/kudu/util/histogram.proto M src/kudu/util/jsonwriter_test.proto M src/kudu/util/maintenance_manager.proto M src/kudu/util/pb_util.proto M src/kudu/util/pb_util_test.proto M src/kudu/util/proto_container_test.proto M src/kudu/util/proto_container_test2.proto M src/kudu/util/proto_container_test3.proto M src/kudu/util/version_info.proto M thirdparty/vars.sh 33 files changed, 33 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-586. Upgrade to protobuf 3
Todd Lipcon has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant HenkeGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-586. Upgrade to protobuf 3
Adar Dembo has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant HenkeGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-586. Upgrade to protobuf 3
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6857 to look at the new patch set (#3). Change subject: KUDU-586. Upgrade to protobuf 3 .. KUDU-586. Upgrade to protobuf 3 Upgrades Kudu to use protoc 3.3.0 and adds `syntax = "proto2”;` to the proto files. Does not leverage the new protobuf allocation arenas, but that should be considered in a follow up patch. Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c --- M src/kudu/cfile/cfile.proto M src/kudu/client/client.proto M src/kudu/common/common.proto M src/kudu/common/wire_protocol.proto M src/kudu/consensus/consensus.proto M src/kudu/consensus/log.proto M src/kudu/consensus/metadata.proto M src/kudu/consensus/opid.proto M src/kudu/fs/fs.proto M src/kudu/master/master.proto M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rpc_introspection.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/rtest_diff_package.proto M src/kudu/security/token.proto M src/kudu/server/server_base.proto M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet.proto M src/kudu/tserver/tablet_copy.proto M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_admin.proto M src/kudu/tserver/tserver_service.proto M src/kudu/util/compression/compression.proto M src/kudu/util/histogram.proto M src/kudu/util/jsonwriter_test.proto M src/kudu/util/maintenance_manager.proto M src/kudu/util/pb_util.proto M src/kudu/util/pb_util_test.proto M src/kudu/util/proto_container_test.proto M src/kudu/util/proto_container_test2.proto M src/kudu/util/proto_container_test3.proto M src/kudu/util/version_info.proto M thirdparty/vars.sh 33 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/6857/3 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant HenkeGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-586. Upgrade to protobuf 3
Adar Dembo has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant HenkeGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-586. Upgrade to protobuf 3
Todd Lipcon has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 2: Code-Review+1 Will upload 3.3 later this morning -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant HenkeGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-586. Upgrade to protobuf 3
Grant Henke has uploaded a new patch set (#2). Change subject: KUDU-586. Upgrade to protobuf 3 .. KUDU-586. Upgrade to protobuf 3 Upgrades Kudu to use protoc 3.3.0 and adds `syntax = "proto2”;` to the proto files. Does not leverage the new protobuf allocation arenas, but that should be considered in a follow up patch. Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c --- M src/kudu/cfile/cfile.proto M src/kudu/client/client.proto M src/kudu/common/common.proto M src/kudu/common/wire_protocol.proto M src/kudu/consensus/consensus.proto M src/kudu/consensus/log.proto M src/kudu/consensus/metadata.proto M src/kudu/consensus/opid.proto M src/kudu/fs/fs.proto M src/kudu/master/master.proto M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rpc_introspection.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/rtest_diff_package.proto M src/kudu/security/token.proto M src/kudu/server/server_base.proto M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet.proto M src/kudu/tserver/tablet_copy.proto M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_admin.proto M src/kudu/tserver/tserver_service.proto M src/kudu/util/compression/compression.proto M src/kudu/util/histogram.proto M src/kudu/util/jsonwriter_test.proto M src/kudu/util/maintenance_manager.proto M src/kudu/util/pb_util.proto M src/kudu/util/pb_util_test.proto M src/kudu/util/proto_container_test.proto M src/kudu/util/proto_container_test2.proto M src/kudu/util/proto_container_test3.proto M src/kudu/util/version_info.proto M thirdparty/vars.sh 33 files changed, 34 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/6857/2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30986ebe56ebb334db8f89f1652e7ef2b064925c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant HenkeGerrit-Reviewer: Kudu Jenkins