[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged.

Change subject: KUDU-687: add replication factor to KuduTable
..


KUDU-687: add replication factor to KuduTable

This is generally useful, and necessary if ksck is to use the C++ client.

While I was at it, I reduced the use of a second table in client-test to
only those tests that actually needed it.

Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Reviewed-on: http://gerrit.cloudera.org:8080/4123
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
7 files changed, 65 insertions(+), 26 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: KUDU-687: add replication factor to KuduTable
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: KUDU-687: add replication factor to KuduTable
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4123/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 3262:   for (int i : { 1, 3, 5, 7, 9 }) {
> hrm, how does this work if there are not 9 tablet servers in the minicluste
ClientTest::CreateTable() is magical; it adds enough tservers to satisfy the 
table's replication factor.


-- 
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: KUDU-687: add replication factor to KuduTable
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4123/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 3262:   for (int i : { 1, 3, 5, 7, 9 }) {
hrm, how does this work if there are not 9 tablet servers in the minicluster?


-- 
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-687: add replication factor to KuduTable
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3067/

-- 
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4123

Change subject: KUDU-687: add replication factor to KuduTable
..

KUDU-687: add replication factor to KuduTable

This is generally useful, and necessary if ksck is to use the C++ client.

While I was at it, I reduced the use of a second table in client-test to
only those tests that actually needed it.

Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
7 files changed, 65 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4123/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo