[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. KUDU-854 - [python] Expose additional scanner projection methods Kudu's python client does not currently expose all Scanner projection methods. This patch adds the bindings for the SetProjectedColumnIndexes and GetProjectionSchema methods of the KuduScanner class. The patch includes a unit test to validate the column index projection method and to ensure that the GetProjectionSchema method returns a result. Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Reviewed-on: http://gerrit.cloudera.org:8080/4344 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon Reviewed-by: David Ribeiro Alves --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py 4 files changed, 86 insertions(+), 0 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Todd Lipcon: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Todd Lipcon has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Jordan Birdsell has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/schema.pyx File python/kudu/schema.pyx: Line 327: fluid programming style. This method allows the SchemaBuilder to be > typo Done Line 328: more easily used to build a new Schema from an existing one. > period at the end Done http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: Line 100: def test_index_projection_with_schema(self): > seems like these should be two different tests (even 2 different patches) Done -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Kudu Jenkins has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3310/ -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4344 to look at the new patch set (#3). Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. KUDU-854 - [python] Expose additional scanner projection methods Kudu's python client does not currently expose all Scanner projection methods. This patch adds the bindings for the SetProjectedColumnIndexes and GetProjectionSchema methods of the KuduScanner class. The patch includes a unit test to validate the column index projection method and to ensure that the GetProjectionSchema method returns a result. Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py 4 files changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/4344/3 -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/schema.pyx File python/kudu/schema.pyx: Line 327: fuild programming style. This method allows the SchemaBuilder to be typo Line 328: more easily used to build a new Schema from an existing one period at the end http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: Line 100: def test_scan_rows_int_predicate_and_index_projection_with_schema(self): seems like these should be two different tests (even 2 different patches) -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Kudu Jenkins has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3309/ -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4344 to look at the new patch set (#2). Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. KUDU-854 - [python] Expose additional scanner projection methods Kudu's python client does not currently expose all Scanner projection methods. This patch adds the bindings for the SetProjectedColumnIndexes and GetProjectionSchema methods of the KuduScanner class. The patch includes a unit test to validate the column index projection method and to ensure that the GetProjectionSchema method returns a result. Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py 4 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/4344/2 -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Kudu Jenkins has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3302/ -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4344 Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. KUDU-854 - [python] Expose additional scanner projection methods Kudu's python client does not currently expose all Scanner projection methods. This patch adds the bindings for the SetProjectedColumnIndexes and GetProjectionSchema methods of the KuduScanner class. The patch includes a unit test to validate the column index projection method and to ensure that the GetProjectionSchema method returns a result. Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_scanner.py 3 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/4344/1 -- To view, visit http://gerrit.cloudera.org:8080/4344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell