[kudu-CR] LookupRpc use the meta cache's client
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19321 ) Change subject: LookupRpc use the meta_cache's client .. LookupRpc use the meta_cache's client If kudu::internal::LookupRpc is consturcted it gets access to two clients, one from the table and one from the meta_cache. They can be different when the table was created with an other client. This can be problematic if KuduSession::Apply(KuduWriteOperation*) is used because the RPC timeout is extracted from the operation's table's client instead of the session's client. Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b Reviewed-on: http://gerrit.cloudera.org:8080/19321 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/client/meta_cache.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b Gerrit-Change-Number: 19321 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] LookupRpc use the meta cache's client
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19321 ) Change subject: LookupRpc use the meta_cache's client .. Patch Set 3: Code-Review+2 Thank you for the fix! -- To view, visit http://gerrit.cloudera.org:8080/19321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b Gerrit-Change-Number: 19321 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Dec 2022 20:38:27 + Gerrit-HasComments: No
[kudu-CR] LookupRpc use the meta cache's client
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19321 to look at the new patch set (#3). Change subject: LookupRpc use the meta_cache's client .. LookupRpc use the meta_cache's client If kudu::internal::LookupRpc is consturcted it gets access to two clients, one from the table and one from the meta_cache. They can be different when the table was created with an other client. This can be problematic if KuduSession::Apply(KuduWriteOperation*) is used because the RPC timeout is extracted from the operation's table's client instead of the session's client. Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b --- M src/kudu/client/meta_cache.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/19321/3 -- To view, visit http://gerrit.cloudera.org:8080/19321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b Gerrit-Change-Number: 19321 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] LookupRpc use the meta cache's client
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19321 to look at the new patch set (#2). Change subject: LookupRpc use the meta_cache's client .. LookupRpc use the meta_cache's client If kudu::internal::LookupRpc is consturcted it gets access to two clients, one from the table and one from the meta_cache. They can be different when the table was created with an other client. This can be problematic if KuduSession::Apply(KuduWriteOperation*) is used because the RPC timeout is extracted from the operation's table's client instead of the session's client. Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b --- M src/kudu/client/meta_cache.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/19321/2 -- To view, visit http://gerrit.cloudera.org:8080/19321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b Gerrit-Change-Number: 19321 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] LookupRpc use the meta cache's client
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19321 Change subject: LookupRpc use the meta_cache's client .. LookupRpc use the meta_cache's client If kudu::internal::LookupRpc is consturcted it gets access to two clients, one from the table and one from the meta_cache. They can be different when the table was created with an other client. This can be problematic if KuduSession::Apply(KuduWriteOperation*) is used because the RPC timeout is extracted from the operation's table's client instead of the session's client. Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b --- M src/kudu/client/meta_cache.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/19321/1 -- To view, visit http://gerrit.cloudera.org:8080/19321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b Gerrit-Change-Number: 19321 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai
